This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 2: (5 comments) https://gerrit.osmocom.org/#/c/3195/2/include/openbsc/gsm_data.h File include/openbsc/gsm_data.h: Line 117: uint8_t classmark3[14]; > classmark3 length gets extended every so often when new 3GPP releases are c Indeed the code did not handle over-length well. Fixed in upcoming patch set. See osmo_msc.c: msc_classmark_chg() https://gerrit.osmocom.org/#/c/3195/2/include/openbsc/osmo_msc.h File include/openbsc/osmo_msc.h: Line 13: #define MSC_HLR_REMOTE_PORT_DEFAULT 2222 > we should probably go for a more 'reasonable' port number closer to the oth pending discussion and/or change in osmo-hlr https://gerrit.osmocom.org/#/c/3195/2/src/libbsc/bsc_vty.c File src/libbsc/bsc_vty.c: Line 840: TODO: add in libvlr? > a VLR by definition holds all of its state in volatile memory (i.e. RAM). S I interpret the keep-in-ram as "don't discard the subscriber info even when it is not needed anymore and would normally be cleaned out of the RAM (to possibly be retrieved from the HLR later)". The purpose I guess to be able to query its properties from the vty easily, like MSISDN or pending SMS, and set it as log context without fear of it getting removed... but yes, since we don't ever remove any subscr info yet, we can drop the comment now, and worry about non-deletion when there is a gc mechanism in the VLR (OS#1974). https://gerrit.osmocom.org/#/c/3195/2/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: Line 1112: lai.lac = 23; /* FIXME bts->location_area_code; */ > I'm really not sure we can simply use hard-coded location area information whoa, this is certainly a dev hack. Need to check how we *should* know the LAC. https://gerrit.osmocom.org/#/c/3195/2/src/libmsc/transaction.c File src/libmsc/transaction.c: Line 194: void trans_conn_closed(struct gsm_subscriber_connection *conn) > all other functions have received nice doxygen documentation, not this one? heh, since we don't even generate doxygen from openbsc.git / osmo-msc.git it's academic :) Also I notice those others lack the doxygen comment marker. Might as well keep them :) -- To view, visit https://gerrit.osmocom.org/3195 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I639544a6cdda77a3aafc4e3446a55393f60e4050 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes