[PATCH] osmo-msc[master]: Use libvlr in libmsc (large refactoring)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Jul 21 16:37:10 UTC 2017


Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/3195

to look at the new patch set (#9).

Use libvlr in libmsc (large refactoring)

Original libvlr code is by Harald Welte <laforge at gnumonks.org>,
polished and tweaked by Neels Hofmeyr <nhofmeyr at sysmocom.de>.

This is a long series of trial-and-error development collapsed in one patch.
This may be split in smaller commits if reviewers prefer that. If we can keep
it as one, we have saved ourselves the additional separation work.

SMS:

The SQL based lookup of SMS for attached subscribers no longer works since the
SQL database no longer has the subscriber data. Replace with a round-robin on
the SMS recipient MSISDNs paired with a VLR subscriber RAM lookup whether the
subscriber is currently attached.

If there are many SMS for not-attached subscribers in the SMS database, this
will become inefficient: a DB hit returns a pending SMS, the RAM lookup will
reveal that the subscriber is not attached, after which the DB is hit for the
next SMS. It would become more efficient e.g. by having an MSISDN based hash
list for the VLR subscribers and by marking non-attached SMS recipients in the
SMS database so that they can be excluded with the SQL query already.

There is a sanity limit to do at most 100 db hits per attempt to find a pending
SMS. So if there are more than 100 stored SMS waiting for their recipients to
actually attach to the MSC, it may take more than one SMS queue trigger to
deliver SMS for subscribers that are actually attached.

This is not very beautiful, but is merely intended to carry us over to a time
when we have a proper separate SMSC entity.

Introduce gsm_subscriber_connection ref-counting in libmsc.

Remove/Disable VTY and CTRL commands to create subscribers, which is now a task
of the OsmoHLR. Adjust the python tests accordingly.

Remove VTY cmd subscriber-keep-in-ram.

Use OSMO_GSUP_PORT = 4222 instead of 2222. See
I4222e21686c823985be8ff1f16b1182be8ad6175.

So far use the LAC from conn->bts, will be replaced by conn->lac in
Id3705236350d5f69e447046b0a764bbabc3d493c.

Related: OS#1592 OS#1974
Change-Id: I639544a6cdda77a3aafc4e3446a55393f60e4050
---
M configure.ac
M doc/examples/osmo-bsc/osmo-bsc.cfg
M doc/examples/osmo-nitb/rbs2308/openbsc.cfg
M include/openbsc/Makefile.am
M include/openbsc/abis_rsl.h
M include/openbsc/auth.h
M include/openbsc/bsc_api.h
M include/openbsc/chan_alloc.h
M include/openbsc/db.h
M include/openbsc/gsm_04_08.h
M include/openbsc/gsm_04_11.h
M include/openbsc/gsm_data.h
M include/openbsc/gsm_data_shared.h
M include/openbsc/gsm_subscriber.h
M include/openbsc/osmo_msc.h
M include/openbsc/signal.h
M include/openbsc/silent_call.h
D include/openbsc/token_auth.h
M include/openbsc/transaction.h
M include/openbsc/vlr.h
M include/openbsc/vty.h
M src/gprs/sgsn_main.c
M src/libbsc/abis_rsl.c
M src/libbsc/bsc_api.c
M src/libbsc/bsc_init.c
M src/libbsc/bsc_vty.c
M src/libbsc/handover_logic.c
M src/libbsc/paging.c
M src/libcommon-cs/common_cs.c
M src/libcommon-cs/common_cs_vty.c
M src/libcommon/debug.c
M src/libcommon/gsm_data.c
M src/libcommon/gsm_subscriber_base.c
M src/libcommon/gsup_client.c
M src/libcommon/gsup_test_client.c
M src/libmsc/Makefile.am
M src/libmsc/auth.c
M src/libmsc/ctrl_commands.c
M src/libmsc/db.c
M src/libmsc/gsm_04_08.c
M src/libmsc/gsm_04_11.c
M src/libmsc/gsm_subscriber.c
M src/libmsc/meas_feed.c
M src/libmsc/osmo_msc.c
M src/libmsc/rrlp.c
M src/libmsc/silent_call.c
M src/libmsc/smpp_openbsc.c
M src/libmsc/smpp_smsc.h
M src/libmsc/sms_queue.c
M src/libmsc/subscr_conn.c
D src/libmsc/token_auth.c
M src/libmsc/transaction.c
M src/libmsc/ussd.c
M src/libmsc/vty_interface_layer3.c
M src/libvlr/vlr_access_req_fsm.c
M src/osmo-nitb/bsc_hack.c
M tests/Makefile.am
M tests/channel/Makefile.am
M tests/channel/channel_test.c
M tests/channel/channel_test.ok
M tests/ctrl_test_runner.py
M tests/db/db_test.c
D tests/mm_auth/Makefile.am
D tests/mm_auth/mm_auth_test.c
D tests/mm_auth/mm_auth_test.ok
A tests/sms_queue/Makefile.am
A tests/sms_queue/sms_queue_test.c
A tests/sms_queue/sms_queue_test.err
A tests/sms_queue/sms_queue_test.ok
M tests/subscr/Makefile.am
D tests/subscr/subscr_test.c
D tests/subscr/subscr_test.ok
M tests/testsuite.at
M tests/vty_test_runner.py
74 files changed, 2,166 insertions(+), 4,244 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/95/3195/9


-- 
To view, visit https://gerrit.osmocom.org/3195
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I639544a6cdda77a3aafc4e3446a55393f60e4050
Gerrit-PatchSet: 9
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list