[PATCH] libosmo-sccp[master]: sccp: ensure addressbook entry names are unique

[dexter]

Hello Neels Hofmeyr, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/3292

to look at the new patch set (#3).

sccp: ensure addressbook entry names are unique

It is possible to add two (or more) different
sccp-addresses under the same name, when the
addresses are defined in different cs7 instances.

Add a check to make sure an address name is not
used multiple times

Change-Id: I63227cd87bc24f7d9ac995430b869f0393818335
---
M src/osmo_ss7_vty.c
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/92/3292/3

diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index 8a03303..c859eb9 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -1205,6 +1205,16 @@
 		return CMD_WARNING;
 	}
 
+	/* Ensure that we do not use address names that
+	 * are already used in other ss7 instances. */
+	entry = addr_entry_by_name_global(name);
+	if (entry != NULL) {
+		vty_out(vty,
+			"address name (%s) already used in ss7 instance %u%s",
+			entry->name, entry->inst->cfg.id, VTY_NEWLINE);
+		return CMD_WARNING;
+	}
+
 	entry = addr_entry_by_name_local(name, inst);
 
 	/* Create a new addressbook entry if we can not find an

-- 
To view, visit https://gerrit.osmocom.org/3292
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I63227cd87bc24f7d9ac995430b869f0393818335
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>