libosmo-sccp[master]: sccp: ensure addressbook entry names are unique

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jul 20 14:40:15 UTC 2017


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/3292/2/src/osmo_ss7_vty.c
File src/osmo_ss7_vty.c:

Line 1212: 			"address-name already used in other ss7 instance!%s",
You are relying on the "happened during this line" output to tell the user which address? I'd still prefer including the name in the error message itself. Maybe even tell the user which ss7 instance already uses that name.

(also I personally dislike '!' in log and eror messages, but that's just my bikeshed)


-- 
To view, visit https://gerrit.osmocom.org/3292
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63227cd87bc24f7d9ac995430b869f0393818335
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list