[PATCH] libosmo-sccp[master]: sccp_scoc: Fix compilation warning and leave a pragma message

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Jul 5 18:14:54 UTC 2017


Review at  https://gerrit.osmocom.org/3135

sccp_scoc: Fix compilation warning and leave a pragma message

Following warning was being printed:
warning: statement will never be executed [-Wswitch-unreachable]

The code in there seems not to be finished, so better leave the code and a
pragma message to get notified when we compile.

Change-Id: I4e2c482803954c984cb6792b11b4ea0fe674e269
---
M src/sccp_scoc.c
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/35/3135/1

diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c
index 3a2cb47..3d43448 100644
--- a/src/sccp_scoc.c
+++ b/src/sccp_scoc.c
@@ -938,10 +938,10 @@
 	struct osmo_scu_prim *prim = NULL;
 
 	switch (event) {
-	/* TODO: internal disco */
+#pragma message ("TODO: internal disco: send N-DISCONNECT.ind to user")
 		/* send N-DISCONNECT.ind to user */
-		scu_gen_encode_and_send(conn, event, xua, OSMO_SCU_PRIM_N_DISCONNECT,
-					PRIM_OP_INDICATION);
+		/*scu_gen_encode_and_send(conn, event, xua, OSMO_SCU_PRIM_N_DISCONNECT,
+					PRIM_OP_INDICATION);*/
 		/* fall-through */
 	case SCOC_E_SCU_N_DISC_REQ:
 		prim = data;

-- 
To view, visit https://gerrit.osmocom.org/3135
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e2c482803954c984cb6792b11b4ea0fe674e269
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list