[MERGED] libosmo-sccp[master]: configure.ac: Fix C(PP)FLAGS for BSD build

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Jul 8 10:46:32 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: configure.ac: Fix C(PP)FLAGS for BSD build
......................................................................


configure.ac: Fix C(PP)FLAGS for BSD build

Issue first found in libosmocore. It seems the BSD build doesn't use
bash which means using += to append to a variable doesn't work
correctly.

Change-Id: I33f6b9de4990de0c4d3a6fc0bd7df632094e79ac
---
M configure.ac
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/configure.ac b/configure.ac
index 36cbb59..200f55d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -53,8 +53,8 @@
 CFLAGS="$saved_CFLAGS"
 AC_SUBST(SYMBOL_VISIBILITY)
 
-CFLAGS+=" -Wall"
-CPPFLAGS+=" -Wall"
+CFLAGS="$CFLAGS -Wall"
+CPPFLAGS="$CFLAGS -Wall"
 
 AC_OUTPUT(
     libosmo-sigtran.pc

-- 
To view, visit https://gerrit.osmocom.org/3133
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I33f6b9de4990de0c4d3a6fc0bd7df632094e79ac
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list