osmo-bts[master]: octphy: set tx attenuation via VTY

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jan 16 13:10:44 UTC 2017


Patch Set 11: Code-Review+2

(2 comments)

minor cosmetics remain ...

https://gerrit.osmocom.org/#/c/905/11/src/osmo-bts-octphy/octphy_vty.c
File src/osmo-bts-octphy/octphy_vty.c:

Line 157: 	if (strcmp(argv[0],"oml") == 0) {
(space after comma)
(could omit these '{' '}')


Line 222: 	}
(could omit both of these '{' '}')


-- 
To view, visit https://gerrit.osmocom.org/905
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76bb8660eb1d8baeb6b8f69da4a6ba9ab7319981
Gerrit-PatchSet: 11
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list