This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 10: Code-Review+1 (3 comments) some details... https://gerrit.osmocom.org/#/c/906/10//COMMIT_MSG Commit Message: Line 7: octphy: Improving OML ADM state handling "Improve", rather avoid "ing"s as discussed last week :) https://gerrit.osmocom.org/#/c/906/10/src/osmo-bts-octphy/l1_oml.c File src/osmo-bts-octphy/l1_oml.c: Line 1561: "pending procedure on RC %d\n", trx->nr); "RC <trx-nr>" ? why not "TRX <trx-nr>" ? Line 1579: "Cannot close TRX, it is already closed!\n"); ah, missed this one: generally in all log messages, we should identify the object. Can we also log the TRX number plz? Personally I dislike exclamation marks in log messages, but one is better than three -- which do exist in our code base... :P -- To view, visit https://gerrit.osmocom.org/906 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034114beca95210169429d8ac1eb8648df12fc6c Gerrit-PatchSet: 10 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes