osmo-gsm-manuals[master]: BSC, BTS: add diagrams of PCU-BTS-NITB-SGSN relationships

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jan 4 23:27:59 UTC 2017

Patch Set 3: Code-Review-1


File OsmoBSC/chapters/overview.adoc:

Line 32: 	BSC;
you're still mixing tab indenting with space indenting

Line 36: 	SMSC
either semicoli everywhere or nowhere: consistent please

Line 80: 	EXTMNCC [label="Linux Call Router / SoftSwitch / PBX\n(optional)"];
preferably put EXTMNCC on top with the others

File OsmoBTS/chapters/interfaces.adoc:

Line 116: The GPRS network architecture including PCU in BTS is shown in
"PCU in BTS"?

Line 132: 	GGSN;
another tab here

To view, visit https://gerrit.osmocom.org/1514
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eb09706efb768fa4f6810872fb6568cbc9838cb
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Owner: ikostov <ikostov at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes

More information about the gerrit-log mailing list