openbsc[master]: add struct bsc_subscr, separating libbsc from gsm_subscriber

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Feb 22 15:20:01 UTC 2017


Patch Set 6:

> I believe we used _find_or_alloc or find_or_create in other/previosu code. yes, it's longer. But "have" might easily be read as "do we have one?", IMHO

ah ok. "have" is probably my personal dialect for find-or-create, I've often used it in private projects and it seemed very clear to me, in the sense of "go on, have a cookie". It's indeed ambiguous like "can I have a cookie?" and "do we have a cookie?" -- Will go for find_or_create instead.

-- 
To view, visit https://gerrit.osmocom.org/1682
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e
Gerrit-PatchSet: 6
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list