This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 6: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/1682/6/openbsc/src/libbsc/bsc_subscriber.c File openbsc/src/libbsc/bsc_subscriber.c: Line 86: struct bsc_subscr *bsc_subscr_have_by_imsi(struct llist_head *list, it was not obvious to me what this function is doing (and how it differs from find) before reading the implementation. I believe we used _find_or_alloc or find_or_create in other/previosu code. yes, it's longer. But "have" might easily be read as "do we have one?", IMHO -- To view, visit https://gerrit.osmocom.org/1682 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e Gerrit-PatchSet: 6 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes