osmo-pcu[master]: dl tbf: initialize punct values and verify

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Feb 14 11:26:51 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/1775/1/src/tbf_dl.cpp
File src/tbf_dl.cpp:

Line 634: 	enum egprs_puncturing_values punct[2] = {
> Check if this initialization can be moved to for loop below. With this modi
This initialization cannot be moved to the for loop. If num_data_blocks is 1, we will not initialize the second punct val and hence will run into the very same sanitizer issue that we're trying to fix. And still, again, and all the time: we are passing *two* arguments to gprs_rlc_mcs_cps(), so we *have* to know that punct has *exactly* two elements. Right?


-- 
To view, visit https://gerrit.osmocom.org/1775
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I004cbbab15e6ffa2749f4b7f1df651517c2ae693
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list