osmo-pcu[master]: dl tbf: initialize punct values and verify

arvind.sirsikar gerrit-no-reply at lists.osmocom.org
Mon Feb 13 21:50:21 UTC 2017


Patch Set 2: -Code-Review

(1 comment)

Please see if you can address my latest comment.

https://gerrit.osmocom.org/#/c/1775/1/src/tbf_dl.cpp
File src/tbf_dl.cpp:

Line 634: 	enum egprs_puncturing_values punct[2] = {
> ARRAY_SIZE(rlc.block_info) always results in 2.
Check if this initialization can be moved to for loop below. With this modification, you may not need to bother about what would be the size of punct.


-- 
To view, visit https://gerrit.osmocom.org/1775
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I004cbbab15e6ffa2749f4b7f1df651517c2ae693
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list