This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review-1 (8 comments) https://gerrit.osmocom.org/#/c/862/2//COMMIT_MSG Commit Message: Line 10: according to section 9.1.8.2.4 in 44.060 version 7.27.0 Release 7. "The fix is made according to that section" would mean that the spec describes this patch... maybe rather "Fix alignment of EPDAN outside the RLC transmit window, according to section..." ? Line 11: The specification explains that A bit within the uncompressed bitmap If the bit is called "A", then say "that the 'A' bit", otherwise "that a bit" (same in previous commit log). Line 13: ignored Again please clearly state the problem. I kind of assume that we're failing to ignore some bit, but it should not need guess work by the reader. https://gerrit.osmocom.org/#/c/862/2/src/rlc.cpp File src/rlc.cpp: Line 108: unsigned num_blocks = rbb->cur_bit > (unsigned)distance() can distance() be negative? Casting a negative value to unsigned is inviting trouble. https://gerrit.osmocom.org/#/c/862/2/src/tbf_dl.cpp File src/tbf_dl.cpp: Line 848: unsigned num_blocks = strlen(show_rbb) > (unsigned)m_window.distance() again negative to unsigned? Line 849: ? m_window.distance() : strlen(show_rbb); don't call strlen twice. (Does the compiler optimize this? I guess not.) Line 929: unsigned num_blocks = rbb->cur_bit > (unsigned)m_window.distance() unsigned distance Line 953: "V(A)..V(S) range %s\n", tbf_name(this)); Do above "this might happen..." comments need to be adjusted, or do they still reflect what is happening here? Or, maybe, does the case described in the comment need some special handling? -- To view, visit https://gerrit.osmocom.org/862 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id07d178970f168f5389016c1eea31eb6b82057b6 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes