This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
arvind.sirsikar gerrit-no-reply at lists.osmocom.orgPatch Set 2: (4 comments) https://gerrit.osmocom.org/#/c/862/2/src/rlc.cpp File src/rlc.cpp: Line 108: unsigned num_blocks = rbb->cur_bit > (unsigned)distance() > can distance() be negative? Casting a negative value to unsigned is invitin The distance is supposed to be positive. But earlier return type is signed. so there needs to be type casting. https://gerrit.osmocom.org/#/c/862/2/src/tbf_dl.cpp File src/tbf_dl.cpp: Line 849: ? m_window.distance() : strlen(show_rbb); > don't call strlen twice. (Does the compiler optimize this? I guess not.) Ok. I will modify the patch. Line 929: unsigned num_blocks = rbb->cur_bit > (unsigned)m_window.distance() > unsigned distance The distance is supposed to be positive. But earlier return type is signed. so there needs to be type casting. Line 953: "V(A)..V(S) range %s\n", tbf_name(this)); > Do above "this might happen..." comments need to be adjusted, or do they st This if condition shall never be hit after this fix. so I will remove the conditional along with comments. -- To view, visit https://gerrit.osmocom.org/862 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id07d178970f168f5389016c1eea31eb6b82057b6 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes