osmo-pcu[master]: Update the function immediate assignment for EGPRS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Sep 6 17:04:18 UTC 2016


Patch Set 7: Code-Review+2

(5 comments)

I still have some final polishing you could do,
but I leave this at your discretion. These are no blockers.

https://gerrit.osmocom.org/#/c/431/7/src/encoding.cpp
File src/encoding.cpp:

Line 206: 		}
we would typically omit the curly braces when there is only one line of code in the if {} block.


Line 252: 	if (((burst_type == GSM_L1_BURST_TYPE_ACCESS_1) ||
I would appreciate in-code comments here about where the
ra bits go, like: ...


Line 254: 		bitvec_write_field(dest, wp, 0x7f, 8);  /* RACH value */
/* 11bit RA: the ra value is written below by write_ia_rest_egprs_uplink() */


Line 256: 		bitvec_write_field(dest, wp, ra, 8);	/* RACH value */
/* 8bit RA: only the lower 8 bit of ra are used */


Line 257: 	}
we would typically omit the curly braces when there is only one line of code in the if {} block.

(though I'm not so sure how we do this when there are also comments)


-- 
To view, visit https://gerrit.osmocom.org/431
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5e309156e5dbbb6add74a1b4d257c4ee2332e52
Gerrit-PatchSet: 7
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list