This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
bhargava_abhyankar gerrit-no-reply at lists.osmocom.orgPatch Set 5: (6 comments) https://gerrit.osmocom.org/#/c/430/5/src/bts.cpp File src/bts.cpp: Line 520: /* class yet */ > /* multi okay, I will change and submit Line 576: if ((is_11bit == 0) && (burst_type == GSM_L1_BURST_TYPE_ACCESS_0)) { > is_11bit is boolean, right? It should be only 0 or 1? okay. I will be changed and submitted Line 584: "phase access,but we force two phase access\n"); > (space after comma) okay Line 588: } else if ((is_11bit == 1) && > if (is_11bit && ... I think else if is good enough, since only one condition will be true for one rach. Line 603: *priority = ((ra & 0x18) >> 3); > (unnecessary outer braces) okay Line 612: } else if ((is_11bit == 1) && > boolean okay -- To view, visit https://gerrit.osmocom.org/430 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61d74a32f7764644ed86f7fdf97fa3c2f61503f7 Gerrit-PatchSet: 5 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com> Gerrit-HasComments: Yes