[MERGED] osmo-pcu[master]: Fix GPRS PUAN encoding: wrong BSN status

[arvind.sirsikar]

arvind.sirsikar has submitted this change and it was merged.

Change subject: Fix GPRS PUAN encoding: wrong BSN status
......................................................................


Fix GPRS PUAN encoding: wrong BSN status

Earlier there was an incorrect encoding of BSN status in GPRS PUAN message.
This was a bottle neck for GPRS performance testing for UL. Which has been fixed
in this patch.

Related: OS#1806

Change-Id: I98e586aa5cb9200cf03e092556304211d4d459aa
---
M src/rlc.cpp
M tests/types/TypesTest.cpp
2 files changed, 3 insertions(+), 4 deletions(-)

Approvals:
  arvind.sirsikar: Verified
  Holger Freyther: Looks good to me, approved



diff --git a/src/rlc.cpp b/src/rlc.cpp
index e69d1fc..ee2635a 100644
--- a/src/rlc.cpp
+++ b/src/rlc.cpp
@@ -227,7 +227,7 @@
 {
 	int i;
 	for (i=0; i < ws(); i++) {
-		if (m_v_n.is_received(ssn()-1-i))
+		if (m_v_n.is_received((ssn()-1-i) & mod_sns()))
 			rbb[ws()-1-i] = 'R';
 		else
 			rbb[ws()-1-i] = 'I';
diff --git a/tests/types/TypesTest.cpp b/tests/types/TypesTest.cpp
index c5654f6..8b3cfd1 100644
--- a/tests/types/TypesTest.cpp
+++ b/tests/types/TypesTest.cpp
@@ -325,10 +325,9 @@
 
 		/*
 		 * SSN wrap around case
-		 * TODO: Should not expect any BSN as nacked.
-		 * should be fixed in subsequent patch
+		 * Should not expect any BSN as nacked.
 		 */
-		rbb = "IIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIRR";
+		rbb = "RRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRR";
 		for (int i = 0; i < 128; ++i) {
 			ul_win.receive_bsn(i);
 			ul_win.raise_v_q();

-- 
To view, visit https://gerrit.osmocom.org/771
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I98e586aa5cb9200cf03e092556304211d4d459aa
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>