This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
arvind.sirsikar gerrit-no-reply at lists.osmocom.orgarvind.sirsikar has submitted this change and it was merged. Change subject: GPRS: PUAN encoding: add test case to show wrong BSNs status ...................................................................... GPRS: PUAN encoding: add test case to show wrong BSNs status This patch adds a test case which expects a current bug with GPRS PUAN encoding. The test's expectation is corrected along with the bug fix in a subsequent commit Related: OS#1806 Change-Id: Ied0f1dd3037d8fac6a772f4e097defb72634f955 --- M tests/types/TypesTest.cpp 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Holger Freyther: Looks good to me, approved diff --git a/tests/types/TypesTest.cpp b/tests/types/TypesTest.cpp index c56b125..c5654f6 100644 --- a/tests/types/TypesTest.cpp +++ b/tests/types/TypesTest.cpp @@ -322,6 +322,24 @@ ul_win.receive_bsn(4); count = ul_win.raise_v_q(); OSMO_ASSERT(count == 0); + + /* + * SSN wrap around case + * TODO: Should not expect any BSN as nacked. + * should be fixed in subsequent patch + */ + rbb = "IIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIRR"; + for (int i = 0; i < 128; ++i) { + ul_win.receive_bsn(i); + ul_win.raise_v_q(); + } + ul_win.receive_bsn(0); + ul_win.raise_v_q(); + ul_win.receive_bsn(1); + ul_win.raise_v_q(); + ul_win.update_rbb(win_rbb); + OSMO_ASSERT_STR_EQ(win_rbb, rbb); + OSMO_ASSERT(ul_win.ssn() == 2); } { -- To view, visit https://gerrit.osmocom.org/770 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied0f1dd3037d8fac6a772f4e097defb72634f955 Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>