[PATCH] libosmo-abis[master]: Remove code duplication, extend logging

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri Dec 30 14:14:33 UTC 2016


Review at  https://gerrit.osmocom.org/1515

Remove code duplication, extend logging

Call function to obtain IPA address once and use the result. Also, log
explicitly IP address and ports to which IPA is bound.

Change-Id: I841c40abdcba0fdd695a43231391c5d7cee20fae
---
M src/input/ipaccess.c
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/15/1515/1

diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index 35465e3..09c9ec5 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -839,11 +839,13 @@
 	switch(line->ops->cfg.ipa.role) {
 	case E1INP_LINE_R_BSC: {
 		struct ipa_server_link *oml_link, *rsl_link;
+		const char *ipa = e1inp_ipa_get_bind_addr();
 
-		LOGP(DLINP, LOGL_NOTICE, "enabling ipaccess BSC mode\n");
+		LOGP(DLINP, LOGL_NOTICE, "enabling ipaccess BSC mode on %s "
+		     "with OML %u and RSL %u TCP ports\n", ipa,
+		     IPA_TCP_PORT_OML, IPA_TCP_PORT_RSL);
 
-		oml_link = ipa_server_link_create(tall_ipa_ctx, line,
-						  e1inp_ipa_get_bind_addr(),
+		oml_link = ipa_server_link_create(tall_ipa_ctx, line, ipa,
 						  IPA_TCP_PORT_OML,
 						  ipaccess_bsc_oml_cb, NULL);
 		if (oml_link == NULL) {
@@ -857,8 +859,7 @@
 			ipa_server_link_destroy(oml_link);
 			return -EIO;
 		}
-		rsl_link = ipa_server_link_create(tall_ipa_ctx, line,
-						  e1inp_ipa_get_bind_addr(),
+		rsl_link = ipa_server_link_create(tall_ipa_ctx, line, ipa,
 						  IPA_TCP_PORT_RSL,
 						  ipaccess_bsc_rsl_cb, NULL);
 		if (rsl_link == NULL) {

-- 
To view, visit https://gerrit.osmocom.org/1515
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I841c40abdcba0fdd695a43231391c5d7cee20fae
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list