osmo-gsm-manuals[master]: Diagrams of relationship between osmo-{pcu, bts, nitb, sgsn} ar...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Dec 31 18:33:43 UTC 2016


Patch Set 1: Code-Review-1

(9 comments)

https://gerrit.osmocom.org/#/c/1514/1//COMMIT_MSG
Commit Message:

Line 7: Diagrams of relationship between osmo-{pcu,bts,nitb,sgsn} are added
commit log conventions:

* have one summary line at the top, less than 80 chars
  (even better: less than 60 chars)
* use present tense imperative, e.g. "add diagrams"
* prefix the general area: "OsmoBSC, OsmoBTS:..."

e.g.

"BSC,BTS: add diagrams of PCU-BTS-NITB-SGSN relationships"


https://gerrit.osmocom.org/#/c/1514/1/OsmoBSC/chapters/overview.adoc
File OsmoBSC/chapters/overview.adoc:

Line 16: The difference between classic The difference between classic GSM network 
please read your own text. This is clearly some copy paste bug.

No whitespace at ends of lines.


Line 18: in next figures.
rather use direct references:

  in <<fig-gsm-classic>> and <<fic-gsm-nitb>>.


Line 33:         HLR [label="HLR/AUC"]
BSC, EIR and SMSC are not declared. That may be the reason for differening ordering of the rightmost elements in the rendered graphs.


Line 69:                 HLR [label="HLR/AUC"]
again EIR, SMSC missing


Line 70:                 BSC->MSC [label="A"]
well, it would be nice to have an actual A interface, but we don't. What else could we write here? "internal API"? Or maybe rather don't label the arrows within the NITB at all?


Line 74:         }
should we add indicators for an external MNCC?


https://gerrit.osmocom.org/#/c/1514/1/OsmoBTS/chapters/interfaces.adoc
File OsmoBTS/chapters/interfaces.adoc:

Line 116: The GPRS network architecture including PCU in BTS is presented below.
"to present" is more like someone talking. Rather say "shown".

You can't rely on the ordering. Some layouts may put the diagrams on other pages. Rather use a reference:

  ...is shown in <<fig-gprs-pcubts>>.


Line 125:         MS1 [label="MS"]
BTS, BSC, MSC, PCU, SGSN not declared. It seems to work to just declare them implicitly, but IIUC by explicit declaration the ordering of the graph items will remain fixed.


-- 
To view, visit https://gerrit.osmocom.org/1514
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eb09706efb768fa4f6810872fb6568cbc9838cb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Owner: ikostov <ikostov at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list