[PATCH] mobile_app: fix some configuration r/w bugs

Harald Welte laforge at gnumonks.org
Sat Jan 2 19:19:57 UTC 2016


Hi Vadim,

thanks for your patch, but..

On Sun, Jan 03, 2016 at 01:14:23AM +0600, Вадим Яницкий wrote:
> -        set->sap_socket_path[0] = 0;
> +        // set->sap_socket_path[0] = 0;
> +        ms->sap_entity.sap_state == SAP_SOCKET_ERROR;

a) if you remove code, remove it for good, not just comment it out

b) the double-equals will not cause an assignment. I don't think you
   tested this code...

Regards,
	Harald
-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)



More information about the baseband-devel mailing list