[PATCH] Add generic LE/BE load/store uint type convertors and use them in msgb

Holger Hans Peter Freyther holger at freyther.de
Fri Mar 7 07:44:31 UTC 2014


On Thu, Mar 06, 2014 at 06:27:38PM +0100, ☎ wrote:

Dear Max,


> >> I'll add more comments to clarify - in general, I do not see better approach for
> >> serialize/deserialize kind of functions than trying to read/write and compare the
> >> results.
> > 
> > Max, what do you want to test?
> > 
> 
> Commented.

That was not the point. I tried to ask you what you intend to test. E.g.
if you take a look at Jacob's range encoding tests in OpenBSC. There is a
simple list of fixes values that are tested and then some random numbers.

Now I find your testcase very hard to comprehend. This is why I want to
understand the goal first and then propose a more simple/straight forward
approach. But now I did propose something. ;)

You are still having
	for (...) 	but we have for (...) {
	{

sorry about that. But we still have some time until Sunday. :)





More information about the baseband-devel mailing list