[PATCH] Add A5/3-4 cipher support

Max.Suraev at fairwaves.co
Tue Jun 17 15:30:09 UTC 2014


17.06.2014 17:21, Sylvain Munaut пишет:
> As I stated in the previous comment, I don't even see why you need
> that header. Just make your test go through the public API and test
> the whole chain. It gets rid of the header, the need to static link,
> that extraneous param and only add one new inline function in the test

Well, that's a function which will only be used once - and it got to be written,
debugged and tested. And all that for the sake of? I do not consider extra non-public
header to be of such great burden that it justifies extra work necessary to get rid
of it.

-- 
best regards,
Max, http://fairwaves.co




More information about the baseband-devel mailing list