[PATCH 3/3] Add Kasumi cipher implementation

Sylvain Munaut 246tnt at gmail.com
Sun Jun 15 22:33:41 UTC 2014


Hi,

> What do you mean by "all before that"?

Like change all libosmocore headers to use #pragma once.

We pretty much only target gcc/llvm AFAIK so that shouldn't be a problem.

Any one see an objection to that ?


> I think I've asked it already but I don't recall an answer: I do not want to make it
> a part of public API (hence - no osmo_ prefix) but I still need to call it explicitly
> in test/ - how can I do that without adding it to map file?

I think the header should be in noinst_HEADER then (don't remember the
exact name).

As for the testing, linking the test statically should do right ? I
didn't test but since this only changes the presence of the symbol in
the dynamic symbol table, linking to the static lib should work.

Cheers,

   Sylvain




More information about the baseband-devel mailing list