[PATCH] Add generic LE/BE load/store uint type convertors and use them in msgb

Sylvain Munaut 246tnt at gmail.com
Sat Feb 1 18:53:45 UTC 2014


> I've converted my comments but I'd like to point out that libosmocore does not
> actually follow this style - just do
> git grep -n "//"|grep -v http
> to verify.

There is a _LOT_ less // than /* */ style comments.

bash$ git grep -n "/\*"|grep -v http | grep -v git | grep -v \\\.in |
grep -v rules | wc -l
4859
bash$ git grep -n "//"|grep -v http | grep -v git | grep -v \\\.in |
grep -v rules | wc -l
26

Just because a few slipped by the review in previous merges doesn't
mean it should be encouraged.

Also not that among those few, only 2 of them are actually comments
really, the others are deactivated code that really should have been
removed instead of commented.

Cheers,

   Sylvain




More information about the baseband-devel mailing list