This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/baseband-devel@lists.osmocom.org/.
☎ Max.Suraev at fairwaves.ruAll fixed. Let me know if I've overlooked something. 22.11.2013 16:44, Harald Welte пишет: > Hi Max, > > I would like to merge your patch, but: > > On Tue, Nov 19, 2013 at 12:25:52PM +0100, ☎ wrote: >> +int >> +comp128v2(const uint8_t *ki, const uint8_t *rand, uint8_t *sres, uint8_t *kc) >> +{ >> + int r = comp128v3(ki, rand, sres, kc); >> + kc[7] = 0; /* 10 last bits of Kc forced to 0 */ >> + kc[6] &= 0xfc; >> + return r; >> +} > this is space-indented, not tab-indented. > >> +static struct osmo_sub_auth_data test_aux2 = { >> + .type = OSMO_AUTH_TYPE_GSM, >> + .algo = OSMO_AUTH_ALG_COMP128v2, >> + .u.gsm = { >> + .ki = { 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA }, > those lienes are too long for 80-character wide terminals > >> + uint8_t buf[12]; >> + osmo_hexparse(res, buf, 12); >> + if (0 != memcmp(buf, vec->sres, 4)) { >> + printf("%d FAIL SRES:\n", rc); > there's again mixed space and tab indentation. > >> +void test_comp128v3(char * rand, char * res) { > we put the curly braces at the beginning of the line, not at the end of > the line. And again the functions are space indented. > > Furthermore, your patch does not apply on top of master. > > It's sad to see that valuable contributions are lost due to basic coding > style issues not being observed. We had this back in April with your > KASUMI related patches, and it was never fixed. Please take the time > to fix those issues, thanks. > > Regards, > Harald -- best regards, Max, http://fairwaves.ru