[PATCH] l1: add CBCH flag to dedicated mode

Sylvain Munaut 246tnt at gmail.com
Thu Jan 3 00:16:18 UTC 2013


> Add a .cbch_mode member to struct l1ctl_dm_est_req.  If set, this
> instructs L1 to use the CBCH variant of SDCCH for dedicated mode (no
> uplink, no SACCH).

I would make it a generic 'flags' bit fields with a DM_FLAG_CBCH or
something like that.
This way we can re-use this for other special modes (I'm thinking like
a sniff more or no tx or role swap modes).

> The extra struct member might be a bit excessive;  an alternative would
> be to abuse audio_mode, which is not used for signalling channels.

I don't like the idea of abusing audio_mode, but I'll look into the
code tomorrow see if it worth combining more stuff into a parameters.



More information about the baseband-devel mailing list