[PATCH] l23 sysinfo: defer SI4 CBCH mobile allocation until SI1 is received

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/baseband-devel@lists.osmocom.org/.

Alex Badea vamposdecampos at gmail.com
Wed Jan 2 15:34:25 UTC 2013


When parsing SI4, there's a check and a log message saying that CBCH
MA is ignored until SI1 is received.  Then the MA is decoded anyway --
incorrectly -- such that it remains incorrect even after receiving
the next SI1.

Fix that with an "else".

Signed-off-by: Alex Badea <vamposdecampos at gmail.com>
---
 src/host/layer23/src/common/sysinfo.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/host/layer23/src/common/sysinfo.c b/src/host/layer23/src/common/sysinfo.c
index 2816c26..b42bd65 100644
--- a/src/host/layer23/src/common/sysinfo.c
+++ b/src/host/layer23/src/common/sysinfo.c
@@ -753,6 +753,7 @@ short_read:
 			LOGP(DRR, LOGL_NOTICE, "Ignoring CBCH allocation of "
 				"SYSTEM INFORMATION 4 until SI 1 is "
 				"received.\n");
+		} else {
 			gsm48_decode_mobile_alloc(s->freq, data + 2, data[1],
 				s->hopping, &s->hopp_len, 1);
 		}
-- 
1.7.0.4





More information about the baseband-devel mailing list