[PATCH] COMP128v23 improvements

Harald Welte laforge at gnumonks.org
Sun Dec 1 13:39:22 UTC 2013


Hi Max,

On Mon, Nov 25, 2013 at 12:20:33PM +0100, ☎ wrote:
> All fixed. Let me know if I've overlooked something.

thanks. it looks fine to me, and if it was applying to
libosmocore/master, I would have merged it today :)

Just for sake of completeness, the linux kernel checkpatch.pl script
finds the following issues (which I would ignore, but just as a general
rule, it is a good way to catch coding style issues):

------------
WARNING: line over 80 characters
#45: FILE: include/osmocom/gsm/comp128v23.h:20:
+int comp128v2(const uint8_t *ki, const uint8_t *rand, uint8_t *sres, uint8_t *kc);

WARNING: line over 80 characters
#46: FILE: include/osmocom/gsm/comp128v23.h:21:
+int comp128v3(const uint8_t *ki, const uint8_t *rand, uint8_t *sres, uint8_t *kc);

WARNING: please, no spaces at the start of a line
#225: FILE: tests/comp128/comp128_test.c:18:
+    }$

WARNING: please, no spaces at the start of a line
#234: FILE: tests/comp128/comp128_test.c:27:
+    }$

ERROR: "foo * bar" should be "foo *bar"
#237: FILE: tests/comp128/comp128_test.c:30:
+void print_check(int rc, char * res, struct osmo_auth_vector *vec)

ERROR: trailing statements should be on next line
#251: FILE: tests/comp128/comp128_test.c:44:
+	else printf("%d OK\n", rc);

ERROR: else should follow close brace '}'
#251: FILE: tests/comp128/comp128_test.c:44:
+	}
+	else printf("%d OK\n", rc);

ERROR: "foo * bar" should be "foo *bar"
#254: FILE: tests/comp128/comp128_test.c:47:
+void test_comp128v3(char * rand, char * res)

ERROR: "foo * bar" should be "foo *bar"
#254: FILE: tests/comp128/comp128_test.c:47:
+void test_comp128v3(char * rand, char * res)

ERROR: "foo * bar" should be "foo *bar"
#264: FILE: tests/comp128/comp128_test.c:57:
+void test_comp128v2(char * rand, char * res)

ERROR: "foo * bar" should be "foo *bar"
#264: FILE: tests/comp128/comp128_test.c:57:
+void test_comp128v2(char * rand, char * res)
------------

Regards,
-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)




More information about the baseband-devel mailing list