[PATCH 2/2] rearm_timer: update run-time and re-activate

Harald Welte laforge at gnumonks.org
Sun Jan 29 08:33:24 UTC 2012


Hi Christian,

On Sat, Jan 28, 2012 at 09:41:35PM +0100, Christian Vogel wrote:
> Instead of calling schedule_timer() inside the
> callback (which causes list-reshuffling) just call
> rearm_timer(self,milliseconds) to have it re-execute
> after the specified time.

this may make sense from an efficiency point of view, but it is a
deviation from the API we use in libosmocore.  Which brings me to the
next issue:  The osmo_timer_* rename has not yet been applied to the
timer implementation.

If other developers agree to introduce a 'rearm_timer', then we should
also add it to osmo_timer_rearm() to libosmocore for consistency.

Also, it might be a good idea to verify that it actually is in the list,
at least durinig DEBUG / development builds.

Regards,
	Harald
-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)




More information about the baseband-devel mailing list