[PATCH] Added option for mobile-app to bind to other interfaces than localhost. Signed-off-by: Tim Ehlers <osmocom at ehlers.info>

Peter Stuge peter at stuge.se
Tue Feb 21 13:09:25 UTC 2012


Tim Ehlers wrote:
> +++ b/src/shared/libosmocore/src/vty/telnet_interface.c
..
> @@ -101,6 +102,50 @@ int telnet_init(void *tall_ctx, void *priv, int port)
>  	return 0;
>  }
>  
> +int telnet_init_dynif(void *tall_ctx, void *priv, const char *ip, int port)
> +{
> +	struct sockaddr_in sock_addr;
> +	int fd, rc, on = 1;

Rather than keeping the previous code around duplicated, perhaps the
old telnet_init() can now call telnet_init_dynif() with 127.0.0.1 as
ip parameter.

Updating a commit is also easy. Make changes, then:

git commit -a --amend

-a tells git commit (like last time) that everything you have changed
in the whole worktree (repository) should be committed. (Can also use
git add file.c file2.c before git commit, in order to only mark some
files, or even only some parts of files, for inclusion.)


Thanks!

//Peter




More information about the baseband-devel mailing list