[PATCH 8/8] firmware: mark some structs as packed

Alexander Huemer alexander.huemer at xx.vu
Thu Nov 24 10:36:47 UTC 2011


On Thu, Nov 24, 2011 at 10:49:43AM +0100, Holger Hans Peter Freyther wrote:
> On 11/24/2011 10:36 AM, Alexander Huemer wrote:
> 
> > Steve and Holger raised some reasonable concerns on some of the other
> > patches, it seems I was quite unconcentrated and they are mostly crap.
> 
> crap? no, not at all. I agree that we should get the number of warnings down,
> sometimes a warning just needs something else than the straight forward fix.
> 
Compiler warnings are of course controversial.
I personally think that osmocom-bb and friends are fine pieces of code
and deserve a kind of "polished" look when compiling.

Some warnings are also quite strong indications of bugs like "... makes
pointer from integer without a cast" and things like that.

I myself don't know how to handle e.g. "discards qualifiers from pointer
target type" when the constness of lvalue and rvalue don't match.

Maybe it doesn't actually matter so much and I am just pedantic.




More information about the baseband-devel mailing list