[PATCH]: Implement SMS decoding

Gianni Tedesco gianni at scaramanga.co.uk
Thu May 12 09:22:57 UTC 2011


On Thu, 2011-05-12 at 08:48 +0200, Harald Welte wrote:
> Hi Gianni,
> 
> On Thu, May 12, 2011 at 03:27:15AM +0100, Gianni Tedesco wrote:
>  
> > Attached patch implements SMS decoding. 
> 
> are you aware that we already have 7bit decoding routines in libosmogsm,
> as well as other SMS parsing code in OpenBSC?  I would prefer if we have
> one implementation that is in the shared library and re-used by all the
> various Osmocom projects.

The 7bit decoding routines are useful as is, I'll go ahead and use them.

However, the SMS decode in OpenBSC (gsm_04_11.c) is very nice but its
decoding everything we want to transmit and constructing everything we
want to decode! Not sure how to share that? Maybe some strings, structs
and numbers, unless it was an off the cuff suggestion or I am missing
something?

> Maybe the existing routines are not suitable right-away, then they
> should be adapted.  But two implementations for the same task doesn't
> sound like a good solution to me.

If you can propose a way to move us there incrementally (for the
CP/RP/SMS-DELIVER etc.), I'm all ears. I've only just dipped my toe in
the pool here don't forget :)

Gianni





More information about the baseband-devel mailing list