[PATCH] uart: make *_UART_NR platform independent

Sylvain Munaut 246tnt at gmail.com
Sat May 7 05:21:05 UTC 2011


Hi,

> * convert *_UART_NR to enum uart_type in uart.h
> * make uart-functions use uart_type consistently
>  (was uint8_t and int)
> * map uart_type to correct uart for mtk
> * (remove forgotten calypso-include for mtk while we are here)
>
> Binaries have been successfully tested with a Sciphone G2 and a Motorola C155.
>
> Signed-off-by: Wolfram Sang <wolfram at the-dreams.de>
> ---


This looks very weird to me ...

The uart paraemeter is not a 'type', it's the index of the UART. And
we use define so we can easily change if we use UART0 or UART1 for the
console / sercomm.

With your modification you have to change the order of the enum if you
want to swap them ? (like it's required on the freerunner)

There is someclean up to be made, but IMHO that's not it at all.

Cheers,

    Sylvain




More information about the baseband-devel mailing list