[PATCH] Adjust top-level Makefile for arm-none-eabi toolchain
peter at stuge.se
Tue Jan 25 21:55:08 UTC 2011
Thanks for review!
Sylvain Munaut wrote:
> On Tue, Jan 25, 2011 at 10:31 PM, Peter Stuge <peter at stuge.se> wrote:
> > The gnuarm.com toolchain works fine but is very old. And although it is
> > based on newlib, the os name in the tuple that we used to configure for
> > is arm-elf-linux, which is of course bogus since we are not building
> > Linux applications.
> Well, I don't really agree here.
> arm-elf- is a perfectly valid prefix and not only used by the gnuarm
> toolchain ...
Note the difference between arm-elf and arm-elf-linux. The latter is
what we configure for. But because that compiler doesn't work CC is
overridden with a hard code to arm-elf-gcc. (Which works fine!)
> Also, the cross prefix to use should _always_ be entirely selectable
> by an env variable, and it looks to me like your patch removes that.
> (i.e. if I do make CROSS_TOLL_PREFIX=arm-elf- it's not gonna work
> anymore AFAICT)
It looks like the other way around to me. I added ?= so that the
variable only gets set if it does not already have a value, while
previously I think it was overwritten by the value in Makefile?
Anyway I reworked a little, so that HOST= can be used to specify the
desired host tuple, which is then used both for configure, and passed
on to the target/firmware Makefile. Patch attached.
More information about the baseband-devel