laforge at gnumonks.org
Wed Feb 16 14:13:50 UTC 2011
On Tue, Feb 15, 2011 at 05:37:48PM +0100, Dario Lombardo wrote:
> Hi guys
> Any news this side? Are patches ok? Are you planning to merge them? If not,
> tell me what's wrong so I can change it.
Andreas said he is OK with applying them, so I will do that.
However, if I read your code correctly, it still seems to me that there is
a fixed compile time decision if gpsd or built-in gps support is to be used.
I think it would be better to keep it a runtime decision, i.e.
1) if gpsd headers/library available during compilation,
build support for _both_ gpsd and built-in gps into the program,
2) if they are not available, only include the built-in gps support.
The decision which method to use should be a config file option. Please make sure
that a config file configured for built-in gps support will work with both versions
of the program.
A config file requesting the use of gpsd support should make the program abort if
it was compiled without gpsd support included.
So I will apply your patch now, but I would really appreciate if you could improve
it the way I described in an incremental patch at some later point.
- Harald Welte <laforge at gnumonks.org> http://laforge.gnumonks.org/
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
More information about the baseband-devel