From perrier.vincent0210 at gmail.com  Fri Jul 12 14:02:07 2019
From: perrier.vincent0210 at gmail.com (Vincent Perrier)
Date: Fri, 12 Jul 2019 10:02:07 -0400
Subject: Patch submission
Message-ID: <CAO2LckYAHgouavQbpw9S1vMJ_ygVu=TYYS5kOyUiPWcXL_bcHw@mail.gmail.com>

Fix memory leak in librtlsdr.

The problem came up when using rtlsdr_open() twice with the same index.
The variable dev->devh is never cleaned if libusb_claim_interface() fails.
This causes a leak if the device is already claimed by another handle.
rtlsdr_close() did not free that space since the returned handle is invalid
if libusb_claim_interface fails

Here is the patch file in text format. (it is also joined to this email).

~~~~
diff --git a/src/librtlsdr.c b/src/librtlsdr.c
index a71609b..89ec903 100644
--- a/src/librtlsdr.c
+++ b/src/librtlsdr.c
@@ -1520,10 +1520,6 @@ int rtlsdr_open(rtlsdr_dev_t **out_dev, uint32_t
index)
        r = libusb_claim_interface(dev->devh, 0);
        if (r < 0) {
                fprintf(stderr, "usb_claim_interface error %d\n", r);
-               if (dev)
-               {
-               libusb_close(dev->devh);
-               }
                goto err;
        }
~~~~

-Vincent Perrier
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/osmocom-sdr/attachments/20190712/22849f18/attachment.htm>

From oliver.jowett at gmail.com  Sat Jul 20 10:08:06 2019
From: oliver.jowett at gmail.com (Oliver Jowett)
Date: Sat, 20 Jul 2019 18:08:06 +0800
Subject: ADS-B reed-solomon ?
In-Reply-To: <CAPKZHbUZr2d1rJxR32V0gECQigerb6p9Ju2ZoO6ZgvGyfB7K8Q@mail.gmail.com>
References: <CAPKZHbUZr2d1rJxR32V0gECQigerb6p9Ju2ZoO6ZgvGyfB7K8Q@mail.gmail.com>
Message-ID: <CAAjXfu8OrUHcHSu+7EDkpHdeAzCm9kao7cOeVWh4j7pdn72rMw@mail.gmail.com>

On Fri, 19 Jul 2019 at 15:58, Brad Walker <bwalker at musings.com> wrote:

> I've been studying the rtl_adsb.c code and it's very interesting how it
> works..
>
> But, I have question.
>
> I noticed that if I request verbose output using the "-V" option, then the
> CRC is printed out. But, it doesn't look like the code actually does any
> Reed-Soloman error correction to the data  the ADS-B specification
> documents.
>

1090MHz (Mode S extended squitter) ADS-B does not use R-S error correction,
it's just a 24-bit CRC (or an xor of that with the aircraft address for
some message types). Maybe you are thinking of 978Mhz (UAT) ADS-B, which is
not handled by rtl_adsb at all?

There is some error correction that's possible even with just the CRC but
it's not particularly reliable.

Oliver
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/osmocom-sdr/attachments/20190720/e535493a/attachment.htm>

From oliver.jowett at gmail.com  Sat Jul 20 10:10:46 2019
From: oliver.jowett at gmail.com (Oliver Jowett)
Date: Sat, 20 Jul 2019 18:10:46 +0800
Subject: Receiving UTAs on 978 Mhz
In-Reply-To: <e0d9c40f-68da-9ac6-d7c4-d15a1fe670e6@rontalcolour.ca>
References: <e0d9c40f-68da-9ac6-d7c4-d15a1fe670e6@rontalcolour.ca>
Message-ID: <CAAjXfu9JRTyUrnDO=u7zd3ufRBCsMXurBUpi1_0GC0sQV3cjTA@mail.gmail.com>

On Fri, 19 Jul 2019 at 15:58, Yaron Haddi <yaron at rontalcolour.ca> wrote:

Is it possible to adapt rtl_adsb to receive UTAs on 978 MHz as well? I wish
> something like this was included in the library as a binary for Windows.
>

UAT is an entirely different protocol with different modulation and message
formats; it does not have much in common with 1090MHz ADS-B.

You might want to look at dump978:
https://github.com/flightaware/dump978 (though
there's no Windows build)

Oliver
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/osmocom-sdr/attachments/20190720/a59ef050/attachment.htm>

From yaron at rontalcolour.ca  Sun Jul 21 11:49:41 2019
From: yaron at rontalcolour.ca (Yaron Haddi)
Date: Sun, 21 Jul 2019 07:49:41 -0400
Subject: Receiving UTAs on 978 Mhz
In-Reply-To: <CAAjXfu9JRTyUrnDO=u7zd3ufRBCsMXurBUpi1_0GC0sQV3cjTA@mail.gmail.com>
References: <e0d9c40f-68da-9ac6-d7c4-d15a1fe670e6@rontalcolour.ca>
 <CAAjXfu9JRTyUrnDO=u7zd3ufRBCsMXurBUpi1_0GC0sQV3cjTA@mail.gmail.com>
Message-ID: <71d39438-c139-befb-db37-180ba897bd68@rontalcolour.ca>

An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/osmocom-sdr/attachments/20190721/227d5a54/attachment.htm>

From oliver.jowett at gmail.com  Mon Jul 22 03:20:05 2019
From: oliver.jowett at gmail.com (Oliver Jowett)
Date: Mon, 22 Jul 2019 11:20:05 +0800
Subject: Receiving UTAs on 978 Mhz
In-Reply-To: <71d39438-c139-befb-db37-180ba897bd68@rontalcolour.ca>
References: <e0d9c40f-68da-9ac6-d7c4-d15a1fe670e6@rontalcolour.ca>
 <CAAjXfu9JRTyUrnDO=u7zd3ufRBCsMXurBUpi1_0GC0sQV3cjTA@mail.gmail.com>
 <71d39438-c139-befb-db37-180ba897bd68@rontalcolour.ca>
Message-ID: <CAAjXfu_zHqydJBX_uieL4jP3Q3ZeT5+bAYzwzgY8NWvFbkY4vg@mail.gmail.com>

UAT uses different modulation / preamble / message length and framing etc.
A Mode S demodulator on a different frequency is not going to work; you
need a demodulator specifically for UAT.

The underlying modulation is BFSK so you could maybe use a generic BFSK
demodulator (or even rtl_fm) and build on top of that, but you do only have
~2 samples per bit to play with on a 2832 so YMMV.

Oliver


On Sun, 21 Jul 2019 at 19:49, Yaron Haddi <yaron at rontalcolour.ca> wrote:

> Hi Oliver,
>
> I know that the frequency is different and that messages have other
> structures. I have created my own message parser, so I was hopping that all
> is needed is just changing the frequency in the rtl_adsb program or,
> alternately, the ability to specify the desired frequency in the command
> line.
>
> Yaron
>
> On 20/07/2019 06:10, Oliver Jowett wrote:
>
> On Fri, 19 Jul 2019 at 15:58, Yaron Haddi <yaron at rontalcolour.ca> wrote:
>
> Is it possible to adapt rtl_adsb to receive UTAs on 978 MHz as well? I
>> wish something like this was included in the library as a binary for
>> Windows.
>>
>
> UAT is an entirely different protocol with different modulation and
> message formats; it does not have much in common with 1090MHz ADS-B.
>
> You might want to look at dump978: https://github.com/flightaware/dump978 (though
> there's no Windows build)
>
> Oliver
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/osmocom-sdr/attachments/20190722/1e40adb9/attachment.htm>

From yaron at rontalcolour.ca  Mon Jul 22 10:51:02 2019
From: yaron at rontalcolour.ca (Yaron Haddi)
Date: Mon, 22 Jul 2019 06:51:02 -0400
Subject: Receiving UTAs on 978 Mhz
In-Reply-To: <CAAjXfu_zHqydJBX_uieL4jP3Q3ZeT5+bAYzwzgY8NWvFbkY4vg@mail.gmail.com>
References: <e0d9c40f-68da-9ac6-d7c4-d15a1fe670e6@rontalcolour.ca>
 <CAAjXfu9JRTyUrnDO=u7zd3ufRBCsMXurBUpi1_0GC0sQV3cjTA@mail.gmail.com>
 <71d39438-c139-befb-db37-180ba897bd68@rontalcolour.ca>
 <CAAjXfu_zHqydJBX_uieL4jP3Q3ZeT5+bAYzwzgY8NWvFbkY4vg@mail.gmail.com>
Message-ID: <82f4b7e6-a69d-9e7e-cab3-85fcb1fb0495@rontalcolour.ca>

An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/osmocom-sdr/attachments/20190722/04f6cd51/attachment.htm>

From oliver.jowett at gmail.com  Mon Jul 22 12:02:36 2019
From: oliver.jowett at gmail.com (Oliver Jowett)
Date: Mon, 22 Jul 2019 20:02:36 +0800
Subject: Receiving UTAs on 978 Mhz
In-Reply-To: <82f4b7e6-a69d-9e7e-cab3-85fcb1fb0495@rontalcolour.ca>
References: <e0d9c40f-68da-9ac6-d7c4-d15a1fe670e6@rontalcolour.ca>
 <CAAjXfu9JRTyUrnDO=u7zd3ufRBCsMXurBUpi1_0GC0sQV3cjTA@mail.gmail.com>
 <71d39438-c139-befb-db37-180ba897bd68@rontalcolour.ca>
 <CAAjXfu_zHqydJBX_uieL4jP3Q3ZeT5+bAYzwzgY8NWvFbkY4vg@mail.gmail.com>
 <82f4b7e6-a69d-9e7e-cab3-85fcb1fb0495@rontalcolour.ca>
Message-ID: <CAAjXfu-R-2O_v_QNySCB9a+-ZT_JVVwSKxBM8t1v45bf2Jn5hA@mail.gmail.com>

The Stratux UAT demodulator is actually from an older version of dump978,
FWIW.

Oliver

On Mon, 22 Jul 2019 at 18:51, Yaron Haddi <yaron at rontalcolour.ca> wrote:

> I understand now. I'll consider your suggestion, but I think that it would
> be easier for me to adapt my application to work with Stratux.
>
> Thanks for the clarification.
>
> Yaron
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/osmocom-sdr/attachments/20190722/1a75a6da/attachment.htm>

From osmith at sysmocom.de  Wed Jul 24 08:57:39 2019
From: osmith at sysmocom.de (Oliver Smith)
Date: Wed, 24 Jul 2019 10:57:39 +0200
Subject: [PATCH] contrib/jenkins.sh: osmo-fl2k build verification
Message-ID: <20190724085739.24321-1-osmith@sysmocom.de>

Related: OS#3203
Signed-off-by: Oliver Smith <osmith at sysmocom.de>
---
 contrib/jenkins.sh | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100755 contrib/jenkins.sh

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
new file mode 100755
index 0000000..8c3b1cf
--- /dev/null
+++ b/contrib/jenkins.sh
@@ -0,0 +1,18 @@
+#!/bin/sh -ex
+# This is how we build on jenkins.osmocom.org.
+
+CFLAGS="-Werror"
+
+if ! [ -x "$(command -v osmo-clean-workspace.sh)" ]; then
+	echo "Error: We need to have scripts/osmo-clean-workspace.sh from osmo-ci.git in PATH!"
+	exit 2
+fi
+
+osmo-clean-workspace.sh
+cmake \
+	-DINSTALL_UDEV_RULES=ON \
+	-DCMAKE_C_FLAGS="$CFLAGS" \
+	.
+make $PARALLEL_MAKE
+make DESTDIR="_install" install
+osmo-clean-workspace.sh
-- 
2.11.0



From richard at codingstudios.com  Mon Jul 29 14:37:36 2019
From: richard at codingstudios.com (Richard Frye)
Date: Mon, 29 Jul 2019 10:37:36 -0400
Subject: rtl_tcp update
Message-ID: <CAAoi5zs6d2kMgfPb+uhDCYT7CatoxYTVrzYsHRfyZ=a48CPZjw@mail.gmail.com>

I have enabled the direct sampling option to the rtl_tcp. I would like to
submit it as a PR but I need authorization. How do we get authorization?

Thanks,
Richard Frye
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/osmocom-sdr/attachments/20190729/2203eb1b/attachment.htm>

From nunojpg at gmail.com  Thu Jul 25 13:13:35 2019
From: nunojpg at gmail.com (=?UTF-8?Q?Nuno_Gon=C3=A7alves?=)
Date: Thu, 25 Jul 2019 13:13:35 -0000
Subject: usbfs zerocopy broken on ARM/ARM64
Message-ID: <CAEXMXLRwdx=+aPhB3byh3-ft2veuAvbTDAuJfKzbAZ2oBQC5qQ@mail.gmail.com>

Dear Steve,

Could you give a note if there is still work in progress for a linux fix?

I noticed I am affected by this on 5.2, and the last message I find
about this is yours on the arm-kernel list dating back to 9 Nov 2018.

Thanks,
Nuno