[PATCH] Related: OS#3663 Fix failed compilation on macOS Mojave with clang in CMakeLists.txt

Greg Troxel gdt at lexort.com
Mon Oct 22 23:49:38 UTC 2018


Michael Auß <michael.auss at gmail.com> writes:

> I only added the flag for compilers based on the existing pattern *.clang and my new pattern matching "c++“.
> So the Build system is setting the language only for clang at this point.

So this is not really about your change, but it seems that the modern
C++ world is complicated enough and various compilers have various
defaults (which itself seems buggy), so my point is that we should be
setting --std always (to a value that matches what the README says is
needed), rather than special casing which is building up a record of
defaults that don't work.

> I tested the output for c++98 which resulted in the bugs original
> errors:

And there is c++03.  But if it really needs C++11, that's how it is.
The last release does not, but it seems master and the last release are
very far apart.


More information about the osmocom-sdr mailing list