[PATCH] Related: OS#3663 Fix failed compilation on macOS Mojave with clang in CMakeLists.txt

Greg Troxel gdt at lexort.com
Fri Oct 19 23:45:42 UTC 2018


Michael Auß <michael.auss at gmail.com> writes:

> I did encounter problems with syntax errors when compiling with clang, see
> OS#3663 for details. (Relating to rtl_tcp)
>
> I did not add something to the README.

I can certainly believe you had errors.  But, changing the compiler
requirement is significant -- particularly on platforms that don't have
last week's compiler -- and if it isn't the plan to require C++14, then
it seems like a workaround to enable that.    My point really is that
there should be a decision about the language, that should  be in the
README, and the build system should set --std for that chosen language,
and then whatever needs to be fixed should be fixed.


More information about the osmocom-sdr mailing list