This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.
gitosis at osmocom.org gitosis at osmocom.orgThis is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, neels/sanitize has been updated
discards a1b83e292a0f92158eb4eb76eb04e01ffe9f5f96 (commit)
discards e10f427233f77e31c165bcf2742b3e47ef7410f1 (commit)
discards d84d23fdeb792cfbe814b92756af1a82d2513954 (commit)
discards a42a383e17f639021257f692faadfb0a8d703840 (commit)
discards 83a25d7b49d5b31395e0f8fa4598f57ef2c613de (commit)
discards 3f8083140af1570805d994d0d405957b64d5284a (commit)
discards 6b50f8c21dc92f3fad2ea2bc62971efe08749fbf (commit)
discards 865ef453152657b844be1c587f8883baa6a74b54 (commit)
discards b583af90b52bcd90eb3188e7cf3031a511689e95 (commit)
discards 252f1f2ca853b9498e9107dec5334ed4f4b01d38 (commit)
discards f236a4cf60a6900f9282974f3d7a826e1d8775eb (commit)
discards 6c891f1dada3a60edd00c94a5dd8e865c9c6c60a (commit)
discards 860e1055027fcb9af9adf16017eab98cd5ca9eed (commit)
discards 5984f1751cb27073a035e66680b4894e1b3e62b8 (commit)
discards 8b148ab96c1663ef9f2501c7dc7942214f4ed5ab (commit)
via 467559c0bde2d79d369dd6fae0676b6e6b9dfdc1 (commit)
via 140ad0657e8cdcd650d5f23f917b9bc740cccec3 (commit)
via d390a2cfcd30194a6d883ee55e57570b47aa0485 (commit)
via c69a9f2724a3d79e061ef600ac186a93aac9d04a (commit)
via d14112a98534350275b18af704267f05b20c32fa (commit)
via 213e5185c321d626ea9f9b5d357b5c773fdb1eb5 (commit)
via 6662784105e9cf7b6dbd0cce26e962388336d1aa (commit)
via a6a0519b22ed28a90b26eb8ac9076067372fd07c (commit)
via cbfdcddfa9b2cd0e8eab3a27a87d8d9e04c03dd5 (commit)
via 1470b59d2031378fbdf9a70055f5a48343ae62b7 (commit)
via 83b3afbf22491e8ae1e709e430326aef4bdbca68 (commit)
via e311004eb40ecada318356955fd1e24e132a8649 (commit)
via 3e098c78aaf81e1de92360fb99768587bcdb6929 (commit)
via 0083c2433b03f47b95c1ac39c3ef6beaef051fd0 (commit)
via a3584bf13467d79a681fbef8508759362e001986 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (a1b83e292a0f92158eb4eb76eb04e01ffe9f5f96)
\
N -- N -- N (467559c0bde2d79d369dd6fae0676b6e6b9dfdc1)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=467559c0bde2d79d369dd6fae0676b6e6b9dfdc1
commit 467559c0bde2d79d369dd6fae0676b6e6b9dfdc1
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date: Fri Nov 17 00:15:44 2017 +0100
sercomm_test: sanitize: fix msgb mem leak
This should fix the last current remaining sanitizer build failure in
libosmocore regression tests.
Helps fix sanitizer build on debian 9.
Change-Id: I4d6dd7f4348675bc77d4df5a7a0ce41f12d4a043
http://cgit.osmocom.org/libosmocore/commit/?id=140ad0657e8cdcd650d5f23f917b9bc740cccec3
commit 140ad0657e8cdcd650d5f23f917b9bc740cccec3
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date: Thu Nov 16 23:34:33 2017 +0100
tlv_put: guard against NULL val and 0 len
For example encode_auth_info() from gsup.c calls
msgb_tlv_put(msg, iei, 0, NULL)
to put a tag and len with content data following later.
However, this would cause a memcpy() from a NULL pointer, in tlv_put(). Allow
passing NULL and len = 0 for cases like the above:
If val is NULL, use memset(0) instead of memcpy().
If len is zero, do not copy nor memset anything.
Hence make tlv_put() behave in a well-defined and valid way for any and all
input args; no negative fallout is possible from this patch.
Add proper API doc comment.
Fixes a sanitizer build failure in gsup_test:
../../../../src/libosmocore/include/osmocom/gsm/tlv.h:99:2: runtime error: null pointer passed as argument 2, which is declared to never be null
Helps fix sanitizer build on debian 9.
Change-Id: I13dce9cd1228817890d3e81edeeb660c893c1d64
http://cgit.osmocom.org/libosmocore/commit/?id=d390a2cfcd30194a6d883ee55e57570b47aa0485
commit d390a2cfcd30194a6d883ee55e57570b47aa0485
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date: Thu Nov 16 22:31:57 2017 +0100
bssgp_fc_test: sanitize: free fc struct when done
Helps fix sanitizer build on debian 9.
Change-Id: I0ef95ee8185a4789f0732b9420243dda5104d181
http://cgit.osmocom.org/libosmocore/commit/?id=c69a9f2724a3d79e061ef600ac186a93aac9d04a
commit c69a9f2724a3d79e061ef600ac186a93aac9d04a
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date: Thu Nov 16 22:32:36 2017 +0100
gprs_bssgp: bssgp_fc_in(): fix mem leak on queue overflow
All successful and all error code paths of bssgp_fc_in() free the msgb, except
the code path calling fc_enqueue() when the msg is dropped (due to queue being
full, or failure to allocate).
Callers could theoretically catch the -ENOSPC return value and discard the
msgb. However, in other code paths, a callback's return value is returned,
which is expected to free the msgb, so such callback would have to never return
-ENOSPC when it freed the msgb. Much simpler semantics would be to free the
msgb in every code path, no matter which kind of error occurred.
Who is currently calling bssgp_fc_in and how do they handle the return value?
- bssgp_fc_test.c ignores the return value (and hits a mem leak aka sanitizer
build failure if the queue is full).
- fc_timer_cb() ignores the return value.
- bssgp_tx_dl_ud() returns the bssgp_fc_in() rc.
- which is returned by a cascade of functions leading up to being returned,
for example, by gprs_llgmm_reset(), which is usually called with ignored
return code.
At this point it is already fairly clear that bssgp_fc_in() should always free
the msgb, since the callers don't seem to distinguish even between error or
success, let alone between -ENOSPC or other errors.
bssgp_fc_test: assert that no msgbs remain unfreed after the tests.
Adjust expected results.
Helps fix sanitizer build on debian 9.
Change-Id: I00c62a104baeaad6a85883c380259c469aebf0df
http://cgit.osmocom.org/libosmocore/commit/?id=d14112a98534350275b18af704267f05b20c32fa
commit d14112a98534350275b18af704267f05b20c32fa
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date: Thu Nov 16 22:32:36 2017 +0100
bssgp_fc_test: sanitizer: free msgb context when done
Print remaining msgbs when done, then free the entire tall_msgb_context. To be
able to do that, call msgb_talloc_ctx_init() and use its return value.
A subsequent patch will fix a known mem leak and add assertions for 0b in 1
blocks remaining in the tall_msgb_context.
Helps fix sanitizer build on debian 9.
Change-Id: I67d347ab2642b0bfc27b21b44231a7f3146ff641
http://cgit.osmocom.org/libosmocore/commit/?id=213e5185c321d626ea9f9b5d357b5c773fdb1eb5
commit 213e5185c321d626ea9f9b5d357b5c773fdb1eb5
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date: Thu Nov 16 22:55:02 2017 +0100
bssgp_fc_test: clarify by outputting ok / failure messages
The test fills up the queue / sends too large PDUs on purpose. Make that
obvious by outputting returned errors in the expected output.
Cosmetic:
- fc_in()'s return value is ignored, hence don't return anything.
- add comment.
Change-Id: I57d6fce2515a65f6dd037e75af5397079215cb46
http://cgit.osmocom.org/libosmocore/commit/?id=6662784105e9cf7b6dbd0cce26e962388336d1aa
commit 6662784105e9cf7b6dbd0cce26e962388336d1aa
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date: Thu Nov 16 22:29:38 2017 +0100
bssgp_fc_test: remove rounding to deciseconds
Ever since this test was changed to use osmo_gettimeofday_override, the times
it sees are exact every time and don't need rounding to pass the expected
output.
Change-Id: I4a9a5d31fc02eb55caf7ba9c141426d8115bb740
http://cgit.osmocom.org/libosmocore/commit/?id=a6a0519b22ed28a90b26eb8ac9076067372fd07c
commit a6a0519b22ed28a90b26eb8ac9076067372fd07c
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date: Thu Nov 16 18:31:57 2017 +0100
rate_ctr_group_alloc: use ctx; adjust stats_test
Using the NULL context creates mem leaks that bother sanitizer builds.
Allocating from the rate counter context allows cleaning up at the end of
stats_test.
Remove the comment concerning osmo-msc: one way to fix if the talloc becomes
unexpected from this patch is to adjust the talloc expectations, another
(preferred) way is to have no invalid rate counter names in osmo-msc.
Change-Id: Ief9abfeb78b7706200bcc6aaa5dcb04fbeaa9b5b
http://cgit.osmocom.org/libosmocore/commit/?id=cbfdcddfa9b2cd0e8eab3a27a87d8d9e04c03dd5
commit cbfdcddfa9b2cd0e8eab3a27a87d8d9e04c03dd5
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date: Thu Nov 16 18:26:21 2017 +0100
stats_test: clarify talloc contexts
Change-Id: I0eda27cd3e322fb43a825382b37185048ebcd509
http://cgit.osmocom.org/libosmocore/commit/?id=1470b59d2031378fbdf9a70055f5a48343ae62b7
commit 1470b59d2031378fbdf9a70055f5a48343ae62b7
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date: Thu Nov 16 18:23:52 2017 +0100
rate_ctr: doc: explain intentional "mem leak" for mangled group names
Change-Id: I35363c4c1fa0d62fd7fed40fe689487244248a3f
http://cgit.osmocom.org/libosmocore/commit/?id=83b3afbf22491e8ae1e709e430326aef4bdbca68
commit 83b3afbf22491e8ae1e709e430326aef4bdbca68
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date: Thu Nov 16 17:34:07 2017 +0100
gsm0808_test: sanitize: fix msgb memleak
Helps fix sanitizer build on debian 9.
Change-Id: I0097d63bbb4e7ee20eb4a8474f4fef32d39e625f
http://cgit.osmocom.org/libosmocore/commit/?id=e311004eb40ecada318356955fd1e24e132a8649
commit e311004eb40ecada318356955fd1e24e132a8649
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date: Thu Nov 16 17:30:44 2017 +0100
gsm0408_test: sanitize: cleanup msgb
Remove initial msgb talloc context creation: if we create a root ctx for msgb
that all msgb are allocated in, we would in a final cleanup discard all msgbs,
i.e. we would not verify that all msgb are cleaned up properly.
If we create the msgb context and *don't* clean it up in the end, the sanitizer
build fails because the context root is not cleaned up.
Easiest is to actually allocate all msgb at NULL ctx, because then any msgb
that aren't cleaned up properly would still linger, while we don't leave a root
ctx that we need to clean up either.
Helps fix sanitizer build on debian 9.
Change-Id: I1f2d1d05c75bbf4d92787f9735083f18cdc90f6f
http://cgit.osmocom.org/libosmocore/commit/?id=3e098c78aaf81e1de92360fb99768587bcdb6929
commit 3e098c78aaf81e1de92360fb99768587bcdb6929
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date: Thu Nov 16 16:25:08 2017 +0100
lapd_test: sanitize: fix msgb memleaks
Helps fix sanitizer build on debian 9.
Change-Id: I0add9eac7225db23bc02fc2aaee5f42258d34e25
http://cgit.osmocom.org/libosmocore/commit/?id=0083c2433b03f47b95c1ac39c3ef6beaef051fd0
commit 0083c2433b03f47b95c1ac39c3ef6beaef051fd0
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date: Thu Nov 16 16:24:36 2017 +0100
abis_test: sanitize: fix msgb memleak
Helps fix sanitizer build on debian 9.
Change-Id: I69750d9cd2b8f30bfc6d2dfd9e62576e46989fab
http://cgit.osmocom.org/libosmocore/commit/?id=a3584bf13467d79a681fbef8508759362e001986
commit a3584bf13467d79a681fbef8508759362e001986
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date: Thu Nov 16 16:24:04 2017 +0100
memleak: osmo_config_list_parse: getline() needs free also on error
Helps fix sanitizer build on debian 9.
Change-Id: Iddf0a6cc733cd81d5f6c1eb62fc079ad319db119
-----------------------------------------------------------------------
Summary of changes:
hooks/post-receive
--
An utility library for Open Source Mobile Communications