This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.
gitosis at osmocom.org gitosis at osmocom.orgThis is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/sndcp_bisect has been created at 205e0d4421135485069fd39f1e4b89210bfed37d (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=205e0d4421135485069fd39f1e4b89210bfed37d commit 205e0d4421135485069fd39f1e4b89210bfed37d Author: Philipp <pmaier at sysmocom.de> Date: Fri Sep 2 13:38:01 2016 +0200 SNDCP: add V.42bis data compression functionality - Add compression control for V.42bis Add code to handle compression (gprs_sndcp_dcomp.c/h) - Add Adjustments in SNDCP - Add VTY commands Change-Id: I6d36cbdf2f5c5f83ca9ba57c70452f02b8582e7e http://cgit.osmocom.org/openbsc/commit/?id=25cc3daa78482280c96e8cb744c6b147741e02a1 commit 25cc3daa78482280c96e8cb744c6b147741e02a1 Author: Philipp <pmaier at sysmocom.de> Date: Fri Sep 2 13:32:38 2016 +0200 V.42bis: integration and unit test - Edit previously committed V.42bis implementation to function outside IAXmodem. - Add unit test to verify the correct function of V.42bis Change-Id: I689413f2541b6def0625ce6bd96f1f488f05f99d Conflicts: openbsc/include/openbsc/Makefile.am openbsc/include/openbsc/debug.h http://cgit.osmocom.org/openbsc/commit/?id=068483cc81130d23cbdd2e935aa68c5a8c2cd329 commit 068483cc81130d23cbdd2e935aa68c5a8c2cd329 Author: Philipp <pmaier at sysmocom.de> Date: Mon Aug 1 18:13:40 2016 +0200 V.42bis: add sourcecode from IAXmodem (SPANDSP) V.42bis is a data compression method found in modems. It has also been specified for GPRS as data compression algorithm. The implementation has been taken from IAXmodem: https://sourceforge.net/p/iaxmodem/code/HEAD/tree/ svn checkout svn://svn.code.sf.net/p/iaxmodem/code/ iaxmodem-code Revision: r36 Change-Id: Iabedece9f97ca944a1e3f747bb073e532c4e9dca http://cgit.osmocom.org/openbsc/commit/?id=97991d56800fdc913e6fdf95cac68d598f66b498 commit 97991d56800fdc913e6fdf95cac68d598f66b498 Author: Philipp <pmaier at sysmocom.de> Date: Fri Aug 26 17:00:21 2016 +0200 SNDCP: add RFC1144 header compression functionality - Add module to handle compression entities - Add module to control header compression - Introduce VTY commands for heade compression configuration - Add changes in sndcp and llc to integrate header compression Change-Id: Ia00260dc09978844c2865957b4d43000b78b5e43 http://cgit.osmocom.org/openbsc/commit/?id=4b12e5f142bc368676ae091de5cbbbe933be8d12 commit 4b12e5f142bc368676ae091de5cbbbe933be8d12 Author: Philipp <pmaier at sysmocom.de> Date: Fri Aug 26 16:58:41 2016 +0200 RFC1144: integration and unit-test The previously pushed slhc implementation has been modified to compile and function outside of the kernel. Also debug log messages were added and datatypes ware matched. The implementation is now ready to be used Change-Id: I7a638e88a43b3eb9d006751a03ef2570e36613f0 http://cgit.osmocom.org/openbsc/commit/?id=6a1d3b3b1e9c640dbaa3df23def6848a8dac5485 commit 6a1d3b3b1e9c640dbaa3df23def6848a8dac5485 Author: Philipp <pmaier at sysmocom.de> Date: Mon Aug 22 10:26:35 2016 +0200 RFC1144: add slhc code from linux kernel SLHC is an Implementation of RFC1144 TCP/IP header compression. We will need RFC1144 compression to compress GPRS TCP/IP traffic. The implementation pushed with this commit was taken from: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git commit 29b4817d4018df78086157ea3a55c1d9424a7cfc Change-Id: Ied69c143678dc4a64cecc671f5c4dfebe19d8519 http://cgit.osmocom.org/openbsc/commit/?id=1bbb2fb2dd155504cc985a9018c2c2213704199d commit 1bbb2fb2dd155504cc985a9018c2c2213704199d Author: Philipp <pmaier at sysmocom.de> Date: Wed Aug 10 12:08:03 2016 +0200 SNDCP: add SNDCP-XID encoder/decoder and unit test The SNDCP-XID (or layer-3 xid) is used to exchange layer-3 parameters such as compression. The encoder encodes a bytestream that is then sent as regular XID field from LLC. We will need the SNDCP-XID to negotiate the parameters for our upcomming GPRS data and header compression features Change-Id: If2d63fe2550864cafef3156b1dc0629037c49c1e http://cgit.osmocom.org/openbsc/commit/?id=79ef9aee911335bb128e8f1e9a62bdfc4d4c0f28 commit 79ef9aee911335bb128e8f1e9a62bdfc4d4c0f28 Author: Alexander Couzens <lynxis at fe80.eu> Date: Mon Aug 29 18:45:42 2016 +0200 bts: extend bts_chan_load to allow counting tch only Change-Id: I86f1d502649747b6b9aefcb39081b14110e8f494 http://cgit.osmocom.org/openbsc/commit/?id=d1ee84c7065fc07464e9c6916941b79fd28a226a commit d1ee84c7065fc07464e9c6916941b79fd28a226a Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue Sep 27 19:28:40 2016 +0200 tmp log Change-Id: Ie14d37b9a573e8eb748308665580103916d415a2 http://cgit.osmocom.org/openbsc/commit/?id=13ce4e7c12fa3f8a2dc9e4e7bdea11416c9b1ca3 commit 13ce4e7c12fa3f8a2dc9e4e7bdea11416c9b1ca3 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue Sep 27 19:28:30 2016 +0200 sccp_sap_up: check for null UE, add len to msg log Change-Id: I7cb4477cc088e17ddf20ff3d5c4e1d4b4cafee7e http://cgit.osmocom.org/openbsc/commit/?id=84a14fce5b3f5d2696fcb51fc9310d683a9307b9 commit 84a14fce5b3f5d2696fcb51fc9310d683a9307b9 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Thu Sep 22 20:00:16 2016 +0200 sgsn_ranap_iu_event: handle some events without valid MM context Change-Id: Ia7e74087d56996104b6d3935b1cf12166ff67f3a http://cgit.osmocom.org/openbsc/commit/?id=574cbbe876aff068e1134de6b70f711d30147bc1 commit 574cbbe876aff068e1134de6b70f711d30147bc1 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon Sep 19 18:30:49 2016 +0200 IuCS: store assigned rab_id in gsm_subscriber_connection Change-Id: I7fda4304631fc24bbd1bebe911b8403a942fcf53 http://cgit.osmocom.org/openbsc/commit/?id=6d9daf418e7473e43921cb036ef67db824fb208a commit 6d9daf418e7473e43921cb036ef67db824fb208a Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Thu Sep 22 20:28:35 2016 +0200 bridge calls via mgcpgw Change-Id: Ie259e30bc532fe9817c96562022ac33443d5747a http://cgit.osmocom.org/openbsc/commit/?id=0552a8775a585948f3796e45e751c11c5a28dea6 commit 0552a8775a585948f3796e45e751c11c5a28dea6 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Thu Sep 22 20:29:30 2016 +0200 also do call assignment for MT calls, upon Call Confirmed Change-Id: I863fa73948f61aaffd7f4472f3abc3e44228e31f http://cgit.osmocom.org/openbsc/commit/?id=a0de633e63733f9392e92844f25c48fb29b1b172 commit a0de633e63733f9392e92844f25c48fb29b1b172 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Wed Sep 7 13:39:07 2016 +0200 IuCS: implement msc_call_assignment() for IuCS Send IuCS RAB Activation upon MNCC_CALL_PROC_REQ. Implement function msc_call_assignment(): decide between sending A-iface BSSMAP Assignment Request or IuCS RAB Assignment Request. Implement iu_rab_act_cs() to send the IuCS RAB Assignment Request. The IP address and port of the MGCPGW sent in the RAB Assignment are still hardcoded. The A-interface extension is not implemented yet. Declare ranap_new_msg_rab_assign_voice() to avoid including ranap_msg_factory.h, which would require adding ASN1 CFLAGS to Makefile.am. The mgcpgw_client as well as some more osmo-iuh functions are now linked from libmsc, hence add some dummy stubs to libiudummy and db_test.c. Change-Id: Iaae51d1fbbfc28fad1c0b85e161d53d80a420a19 http://cgit.osmocom.org/openbsc/commit/?id=84681a41d7e4b2f5ef7e5dc12a0878ceb83095ef commit 84681a41d7e4b2f5ef7e5dc12a0878ceb83095ef Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Thu Sep 22 20:21:10 2016 +0200 cscn: add mgcpgw client (with dummy read cb so far) Store the mgcpgw client data in struct gsm_network. Initialize VTY and bind the client. Change-Id: Ifc4efb1ca44fa34c29bf23b35addb54155296d68 http://cgit.osmocom.org/openbsc/commit/?id=f122e7c49bbf3c485b0ff200591e3b65d9dfb689 commit f122e7c49bbf3c485b0ff200591e3b65d9dfb689 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Wed Sep 7 13:39:07 2016 +0200 libmgcp: add mgcpgw client API Add an API to send MGCP messages to an MGCP GW, from the perspective of an MSC instructing the GW to setup RTP streams. The mgcp_protocol.h is mostly for the MGCP GW itself, other implementations forward incoming MGCP messages. So a simpler approach for an MGCP GW client is useful. osmo-cscn is going to use this to route RTP streams (for 3G). Change-Id: I6fe365c4c89207f2172943cc456b508a207b1135 http://cgit.osmocom.org/openbsc/commit/?id=920375e5522997dded3a01e93bc587ef9f9dde68 commit 920375e5522997dded3a01e93bc587ef9f9dde68 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue Sep 6 20:08:58 2016 +0200 IuCS: cosmetic prep for msc_call_assignment() Rename gsm48_cc_tx_call_proc() to gsm48_cc_tx_call_proc_and_assign() to mark the place where the A-interface will send a BSSAP Assignment Request / where the IuCS-interface will send a RAB Assignment Request. Add function msc_call_assignment() to decide between A-iface and IuCS assignment, to be implemented in subsequent commit. Change-Id: I0695e233d57d13658793b0e63bb7c3ff224909a0 http://cgit.osmocom.org/openbsc/commit/?id=9fb14a7485800ed492f5cb44e996f1cfd570d951 commit 9fb14a7485800ed492f5cb44e996f1cfd570d951 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Wed Sep 7 17:52:32 2016 +0200 IuCS: send RANAP CommonID Add libiu function to send a CommonID message down a UE connection, iu_tx_common_id(); add also a corresponding stub to libiudummy for linking with tests. Add libmsc function msc_tx_common_id() to call the above. Add this mostly to clearly indicate in msc_ifaces.h that libmsc is calling out of the MSC; also to do conn->via_iface checking. Call msc_tx_common_id() after ciphering is established, in _gsm48_rx_mm_serv_req_sec_cb()'s GSM_SECURITY_SUCCEEDED case. Change-Id: I576ddd5bbabfc989149debd2f8a9743db6d26043 http://cgit.osmocom.org/openbsc/commit/?id=05d9c765fe73e86517ba3acf23a920563f1de163 commit 05d9c765fe73e86517ba3acf23a920563f1de163 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Wed Aug 31 15:40:18 2016 +0200 cosmetic: msc_handler, bsc_handler: drop extra whitespace The extra ws made me not find these lines when grepping for 'dtap ='. Change-Id: I45e5c9e7df4704546872aab15adf407298943435 http://cgit.osmocom.org/openbsc/commit/?id=46c93cf221c470d971a4a8485fa46836625b44d6 commit 46c93cf221c470d971a4a8485fa46836625b44d6 Author: Harald Welte <laforge at gnumonks.org> Date: Mon May 2 08:34:57 2016 +0200 SGSN: Don't indicate GERAN in Iu mode PDP CTX ACT REQ to GGSN http://cgit.osmocom.org/openbsc/commit/?id=86d0af6436b256a7c6deb3e592a0a9be34df167d commit 86d0af6436b256a7c6deb3e592a0a9be34df167d Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Thu Aug 18 01:06:18 2016 +0200 cscn: add cmdline error message Change-Id: I30c13a604160268756b7413f1733f92300eb241b http://cgit.osmocom.org/openbsc/commit/?id=aca1e104987196d663b44939ddd30ab1f388666f commit aca1e104987196d663b44939ddd30ab1f388666f Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 9 13:21:55 2016 +0200 cosmetic: remove legacy comment from gsm0408_loc_upd_rej() http://cgit.osmocom.org/openbsc/commit/?id=bc3f068bf8b2bf52e715caa3ea9b9f1491540860 commit bc3f068bf8b2bf52e715caa3ea9b9f1491540860 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 9 13:20:54 2016 +0200 cosmetic: make gsm0408_loc_upd_rej() static http://cgit.osmocom.org/openbsc/commit/?id=74c436ae77bdabb039c9881da85f41cfedc4612a commit 74c436ae77bdabb039c9881da85f41cfedc4612a Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 9 13:18:03 2016 +0200 LU counters: count completion and failure, not messages sent From a human admin viewpoint it doesn't make sense to count the messages sent: When we use TMSIs, we first send a LU Accept with a new TMSI, and then expect the MS to respond with a TMSI Realloc Complete message. When that fails to come through, the LU actually ends in failure, even though a LU Accept was sent. In 3G, if a UE sends an Iu Release during LU (e.g. user enables flight mode), we cancel the LU without sending any reply at all, so nothing would be counted. Instead, count Location Updating results, i.e. completion and failures. http://cgit.osmocom.org/openbsc/commit/?id=7111a938c20b17faf652058d5da8f23eada838c8 commit 7111a938c20b17faf652058d5da8f23eada838c8 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:21:52 2016 +0200 remove handle_abisip_signal() Change-Id: I9cf80f9c2c8a53a29e42f000029e680a9922cb41 http://cgit.osmocom.org/openbsc/commit/?id=9053652c63a667a70a934c0e056d56791cf87855 commit 9053652c63a667a70a934c0e056d56791cf87855 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Wed May 4 15:35:37 2016 +0200 gsm0408_clear_request(): actually free the released conn By having conn->in_release == 1, calling msc_release_connection() has no effect and thus never frees the conn. So, after all pending requests have been discarded, also discard and free the unused connection. http://cgit.osmocom.org/openbsc/commit/?id=6b77bde77d8dd1cf33cd475295e0344c09685061 commit 6b77bde77d8dd1cf33cd475295e0344c09685061 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:24:12 2016 +0200 add iu.h to gsm_subscriber.c Change-Id: I398aaa4a7328a58fb0d563725f3bea26482929ef http://cgit.osmocom.org/openbsc/commit/?id=6f957f60dd960ac697a809213cfa5481b585da0a commit 6f957f60dd960ac697a809213cfa5481b585da0a Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:11:39 2016 +0200 gsm_04_08.c: iu.h Change-Id: I624612b5d5cd70770326347634aee2a42ba88945 http://cgit.osmocom.org/openbsc/commit/?id=e67c3d1761fe60646c32e36f7d002d49babb0b8f commit e67c3d1761fe60646c32e36f7d002d49babb0b8f Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:09:47 2016 +0200 temporary dev: set debug log level almost everywhere Change-Id: I0d5a36560e7edde27497de57e579f5b1d00eb525 http://cgit.osmocom.org/openbsc/commit/?id=9f4c17408bdf1f18c4a4d23a03c9a5275bbe69c3 commit 9f4c17408bdf1f18c4a4d23a03c9a5275bbe69c3 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 13:26:47 2016 +0200 comment on mscsplit, indent comment http://cgit.osmocom.org/openbsc/commit/?id=4a410ebea61ae16fb6c004b26dc6ed753a4c23ff commit 4a410ebea61ae16fb6c004b26dc6ed753a4c23ff Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 13:44:39 2016 +0200 move to libbsc: lchan_next_meas_rep() -- TODO really? Change-Id: I4ea799c5fa61f81c404e6ef1b9ac86a8faa1fb49 http://cgit.osmocom.org/openbsc/commit/?id=b4384765b8ca20d97dbe3d0eb46a18eb4b6255e9 commit b4384765b8ca20d97dbe3d0eb46a18eb4b6255e9 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 13:59:16 2016 +0200 move to libbsc: gsm_bts_neighbor() -- TODO really? Change-Id: I63d4835dc7aabdf176e0ca634a6a4ca527612693 http://cgit.osmocom.org/openbsc/commit/?id=505e4aef9fce3c664b7f3dccb721f0a65dfe7f83 commit 505e4aef9fce3c664b7f3dccb721f0a65dfe7f83 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Wed May 11 14:21:58 2016 +0200 gsm0408_test: use NULL for root ctx -- TODO really? http://cgit.osmocom.org/openbsc/commit/?id=1869da888c877af902c4b789458020e995085ba3 commit 1869da888c877af902c4b789458020e995085ba3 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 9 21:30:26 2016 +0200 gsm_04_08: remove apply_codec_restrictions() -- TODO really? This function is wrongly placed on the MSC level. Unfortunately I cannot remember the very plausible details that hwelte had back in the days to argue for this change. (Refactoring an old commit that fails to explain in more detail.) Change-Id: I82623847e652a59a921d2fb142b77cf22420a746 http://cgit.osmocom.org/openbsc/commit/?id=f29b13db28449891a35c70e7d9b17e16ce9f3a87 commit f29b13db28449891a35c70e7d9b17e16ce9f3a87 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Thu May 12 02:14:33 2016 +0200 move to libmsc: osmo_stats_vty_add_cmds() -- todo MSCSPLIT http://cgit.osmocom.org/openbsc/commit/?id=74aecc63901127b5a75eadedf8374c3c49b837bf commit 74aecc63901127b5a75eadedf8374c3c49b837bf Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 14:04:28 2016 +0200 include msc_ifaces.h in gsm_04_08.c Change-Id: I11be1bdfe6993f89b34319e7d1526c729d6e0cde http://cgit.osmocom.org/openbsc/commit/?id=3b8a6712f71f5d9fbe91d1ea5524ff3c39146735 commit 3b8a6712f71f5d9fbe91d1ea5524ff3c39146735 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:04:56 2016 +0200 complete IuCS paging implementation Add paging timeout to struct gsm_subscriber. Previously, paging timeout was implemented only on BSC level, where each request has its own timeout value. The MSC will still send individual requests to BSC or RNC level, where they timeout individually. However, the MSC must also have an own timeout to be sure to discard stale pagings that the BSC or RNC never replied for. Add handle_paging_resp(), copying the few libmsc relevant parts of gsm48_handle_paging_resp(). http://cgit.osmocom.org/openbsc/commit/?id=cf63ce4059fbd8b869ff6b13eddb12788376d411 commit cf63ce4059fbd8b869ff6b13eddb12788376d411 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 13:57:25 2016 +0200 paging: add todo comments for paging and mscsplit Change-Id: I7e72c9db2837ea5edf45f6037cb0288a264d492c http://cgit.osmocom.org/openbsc/commit/?id=e340c8f04089ac52d1b43f2839a85d8adc63b9fd commit e340c8f04089ac52d1b43f2839a85d8adc63b9fd Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 2 15:57:53 2016 +0200 paging: actually verify subscriber authorization Before this, any paging response would be accepted by the CN, without checking the database whether the subscriber is in fact authorized. The probability that a subscriber would be able to take unauthorized action is slim, nevertheless checking authorization status with the database should happen before we accept a connection. http://cgit.osmocom.org/openbsc/commit/?id=315b597cb2c0d70a8f2d4e382930dfbcffc8896f commit 315b597cb2c0d70a8f2d4e382930dfbcffc8896f Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 2 15:55:22 2016 +0200 paging: change subscr_paging_cb() into subscr_rx_paging_response() Remove one layer of callback indirection in paging. When a paging response arrives, we always want to first secure the connection, thus a fixed subscr_rx_paging_response() function is more appropriate and avoids having to store a cbfn. The actual actions to be taken upon successful paging are of course still in callback functions stored with each subscriber. Remove paging_request_stop() call from subscr_paging_dispatch(), which stops paging on all BTSs, which is not the responsibility of libmsc. Change-Id: Ic2c785c9cc48b2c2c6557cbe1060d25afa89e38d http://cgit.osmocom.org/openbsc/commit/?id=066c3afe03cc2dd13876f3f109bb2ced33c498e9 commit 066c3afe03cc2dd13876f3f109bb2ced33c498e9 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:06:55 2016 +0200 move subscr auth check to gsm_subscriber.c add subscr_authorized(), subscr_authorized_imsi() Change-Id: If2ef06b1229351127c61477ca14653d6ae4cb6bb http://cgit.osmocom.org/openbsc/commit/?id=0a234a58838bb91d41c719664216046472546b47 commit 0a234a58838bb91d41c719664216046472546b47 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Fri Aug 12 16:11:25 2016 +0200 auth log Change-Id: Icd9f8505388a06ee768d2176cb2b9187953098ef http://cgit.osmocom.org/openbsc/commit/?id=50acdcc7cd6d924f4e21859058cae2b162446cd9 commit 50acdcc7cd6d924f4e21859058cae2b162446cd9 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Fri Aug 12 16:09:46 2016 +0200 iu auth wip Change-Id: Icc2522252cf15c54f1a1ea5255314a0de8bfba03 http://cgit.osmocom.org/openbsc/commit/?id=2ef201fe095c62ccb80c16599354e5e74a7c02f4 commit 2ef201fe095c62ccb80c16599354e5e74a7c02f4 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Fri Aug 12 16:03:09 2016 +0200 Iu auth wip Change-Id: I44effcca80dc6850178174dc957bcd5608b0ae14 http://cgit.osmocom.org/openbsc/commit/?id=cff4f9d604948213f00394e5f625c978577ccb90 commit cff4f9d604948213f00394e5f625c978577ccb90 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Fri Aug 12 16:21:32 2016 +0200 cosmetic prep: change int -> bool authorize_subscriber() Upcoming function subscr_authorized() will flip this to bool, so separate this change cosmetically. Change-Id: Iba0184a71afa01141ef06c474cb554e79ad8f5d5 http://cgit.osmocom.org/openbsc/commit/?id=272798b22773d391bc01feffaddfd3af96dd3d3d commit 272798b22773d391bc01feffaddfd3af96dd3d3d Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:07:23 2016 +0200 subscr_request_channel() -> subscr_request_conn() Change-Id: Ife8e10b240693a8d369139881774f1892044aa65 http://cgit.osmocom.org/openbsc/commit/?id=13b8124704b26f42a55421512272d381dfcd00fe commit 13b8124704b26f42a55421512272d381dfcd00fe Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:05:13 2016 +0200 move subscr_request to gsm_subscriber.h Change-Id: Idbbd39b0e068da17aafa97e315143509c69c50ea http://cgit.osmocom.org/openbsc/commit/?id=183ac45372743d87a4ecc2eb77c98ff214dc748b commit 183ac45372743d87a4ecc2eb77c98ff214dc748b Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:01:01 2016 +0200 add gsm_encr to subscr_conn Change-Id: Id5797cd1f1bfa2cca2d3fbabc1981aa75546421b http://cgit.osmocom.org/openbsc/commit/?id=4b7d89092a09a6ba1194ca7d68ccb915fe624a67 commit 4b7d89092a09a6ba1194ca7d68ccb915fe624a67 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 14:57:14 2016 +0200 osmo-nitb becomes osmo-cscn Change-Id: I3787050b524954d8a4dd13495c458f3ee293807b http://cgit.osmocom.org/openbsc/commit/?id=14f5026aa2d2ae877ca416a11bb6bb3e501e5b50 commit 14f5026aa2d2ae877ca416a11bb6bb3e501e5b50 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Wed May 11 17:13:28 2016 +0200 remove unneccessary linking from some tests The recent shifts and cuts have made some library linking for bsc, channel and db tests unnecessary. http://cgit.osmocom.org/openbsc/commit/?id=2c2f46465d2b9cd3838fee203c3c6f4ef86abc1d commit 2c2f46465d2b9cd3838fee203c3c6f4ef86abc1d Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 14:46:23 2016 +0200 msc_release_connection(): don't call gsm0808_clear() gsm0808_clear() is all about clearing lchans. To be able to link libmsc without libbsc, don't call it directly. Change-Id: I149146fc3cb99ef4a21ee2a798231bb070f398cd http://cgit.osmocom.org/openbsc/commit/?id=272cb0ad738468bb67b530112b8774a3d1376da8 commit 272cb0ad738468bb67b530112b8774a3d1376da8 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 21:44:32 2016 +0200 cut off libbsc paging, pending paging in libmsc Temporarily disable all paging to be able to link libmsc without libbsc. Skip the paging part of channel_test because the paging is now disabled. In osmo-nitb, paging is done on BSC level and MSC level "at the same time". When the new CSCN is fully operational, paging will be controlled separately on the MSC level, and the BSC (RNC) level will be instructed over an IuCS or A-interface to negotiate paging with the MS (UE). This MSC level paging does not yet exist and will be added in subsequent commits. Change-Id: I8b6920ddc54fc3f2876a59664e6722666d8a8a4a http://cgit.osmocom.org/openbsc/commit/?id=17403d60fb878bbaf721c20d0fcafe4e3b6c199a commit 17403d60fb878bbaf721c20d0fcafe4e3b6c199a Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 13:09:14 2016 +0200 libmsc: duplicate gsm0808 / gsm48 functions (towards BSC) In osmo-nitb, libmsc would directly call the functions on the BSC level, not always via the bsc_api. When separating libmsc from libbsc, some functions are missing from the linkage. Hence duplicate these functions to libmsc, add an msc_ prefix for clarity, also add a _tx to gsm0808_cipher_mode(): * add msc_gsm0808_tx_cipher_mode() (dummy/stub) * add msc_gsm48_tx_mm_serv_ack() * add msc_gsm48_tx_mm_serv_rej() Call these from libmsc instead of * gsm0808_cipher_mode() * gsm48_tx_mm_serv_ack() * gsm48_tx_mm_serv_rej() Also add a comment relatd to msc_gsm0808_tx_cipher_mode() in two places. Change-Id: I5b276853d3af71f5e3f0a031fd17b4fff0580020 http://cgit.osmocom.org/openbsc/commit/?id=f5bcde0efc166d633ebf36edc3010cc4479ce1aa commit f5bcde0efc166d633ebf36edc3010cc4479ce1aa Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Fri May 20 20:40:34 2016 +0200 Use new msc_tx_dtap() instead of gsm0808_submit_dtap() Aim: msc_tx_dtap() shall redirect to IuCS or A interfaces depending on subscr conn. Change-Id: I30d961f16eb7b9c0ab9cc3f43198098d3f1a909f http://cgit.osmocom.org/openbsc/commit/?id=88d61a232cdd6fe4fb1c2c7bf9c86a6eb1dd3677 commit 88d61a232cdd6fe4fb1c2c7bf9c86a6eb1dd3677 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Fri May 20 21:41:08 2016 +0200 add libiudummy, to avoid linking Iu deps in tests Change-Id: I4a66c4122011dbc87c6fcb336ab0461b86522c98 http://cgit.osmocom.org/openbsc/commit/?id=287ae7f98a743e05b4d28396e5c7da0572c86f90 commit 287ae7f98a743e05b4d28396e5c7da0572c86f90 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 14:59:02 2016 +0200 move to libxsc: gsm48_extract_mi(), gsm48_paging_extract_mi() -- TODO move to libfilter instead? Change-Id: I00ca0caf8224de029f53f4dedb1146e3cf7650ec http://cgit.osmocom.org/openbsc/commit/?id=e1627a2f555082f397a5a457f5f8ab8b6dccabf6 commit e1627a2f555082f397a5a457f5f8ab8b6dccabf6 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 13:37:59 2016 +0200 msc_compl_l3(): publish in .h, tweak return value Use new libmsc enum values for return val, to avoid dependency on libbsc headers. Make callable from other scopes: publish in osmo_msc.h and remove 'static' in osmo_msc.c Change-Id: If24007445899e9c75553a0dbf843ada3566b3380 http://cgit.osmocom.org/openbsc/commit/?id=91d291a8799ea51d2cba16dc88ecf219a765f190 commit 91d291a8799ea51d2cba16dc88ecf219a765f190 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 14:58:46 2016 +0200 add cscn vty, remove nitb vty Change-Id: I8f8980d6cfbf26f1b0e0197939833e55dbe521fb http://cgit.osmocom.org/openbsc/commit/?id=02da797ee2e8bf4191a1a26f1b01b1e3804ce125 commit 02da797ee2e8bf4191a1a26f1b01b1e3804ce125 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 14:56:06 2016 +0200 add iucs.[hc] Change-Id: I88e981f4c31393a98ae8d61176c65c9251a6f28b http://cgit.osmocom.org/openbsc/commit/?id=9053d88a4bd1920544cd72c55e38e0bc39a310d8 commit 9053d88a4bd1920544cd72c55e38e0bc39a310d8 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Fri May 20 21:59:55 2016 +0200 add DIUCS debug log constant Change-Id: Id347a3024fa495a1ab680db7320648d933a4018b http://cgit.osmocom.org/openbsc/commit/?id=2b9f029334abbfedee15ff77759593d20733a84f commit 2b9f029334abbfedee15ff77759593d20733a84f Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:16:45 2016 +0200 gsm0408_loc_upd_rej(): remove bts use (used only for debug log) Change-Id: I3ac38f4b701ad8308470573260fa91a4b04c2f18 http://cgit.osmocom.org/openbsc/commit/?id=aecc06d1495ad0efe8e8be68b2fbf24a84b7f53e commit aecc06d1495ad0efe8e8be68b2fbf24a84b7f53e Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:05:43 2016 +0200 gsm_04_08, gsm_subscriber: decouple lac from bts The idea is to not have a direct pointer to a bts struct (into BSC land), but a LAC to resolve the BSC or RNC depending on the appropriate A or IuCS interface. subscr_update(): remove bts arg, add lac arg. Pass conn->lac to gsm48_generate_lai() instead of bts->location_area_code. Change-Id: I9f2b298a785bf4b2a1b3fcdd91b8256106b2d9de http://cgit.osmocom.org/openbsc/commit/?id=0c27588e75c5a04793ca865806568b8d1278adc2 commit 0c27588e75c5a04793ca865806568b8d1278adc2 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:06:35 2016 +0200 subscr_update_expire_lu(): remove bts arg Change-Id: I26cafd9389aac65e53dc4280a1687c6b8bce3106 http://cgit.osmocom.org/openbsc/commit/?id=d90fad1323431b1c27e182692852352aedbb8355 commit d90fad1323431b1c27e182692852352aedbb8355 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:03:18 2016 +0200 move t3212 to network level (periodic lu) Set the T3212 default value in struct gsm_network and take that value when creating a BTS. Adjust VTY accordingly. Change-Id: Ifb730f9d0106fe195adc30459a39290a07313b50 http://cgit.osmocom.org/openbsc/commit/?id=ea2f3eb0609d9660824cccc6faf98beb1dfe5614 commit ea2f3eb0609d9660824cccc6faf98beb1dfe5614 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:11:50 2016 +0200 libmsc: iucs dev: disable large parts of the code Change-Id: I3ef6ca26150b6102a0fa22a88a60d9a442d640b4 http://cgit.osmocom.org/openbsc/commit/?id=fb779f1b3a1a2763bc6e8fdd1633d39bb689e3a1 commit fb779f1b3a1a2763bc6e8fdd1633d39bb689e3a1 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 12:50:31 2016 +0200 Prepare entry/exit point for MSC -> BSC and MSC -> RNC communication. Add msc_ifaces.[hc], a_iface.c, with a general msc_tx_dtap() to redirect to different interfaces depending on the actual subscriber connection. While iu_tx() is going to be functional fairly soon, the a_tx() is going to be just a dummy for some time (see comment). Add via_iface marker to gsm_subscriber_connection with enum values IFACE_A and IFACE_IU so far. Add Iu specific fields in a sub-struct: the UE connection pointer and an indicator for the Integrity Protection status on Iu (to be fully implemented in later commits). Add lac member to gsm_subscriber_connection, to allow decoupling from bts->location_area_code. The conn->lac will actually be set in iu.c in an upcoming commit ("add iucs.[hc]"). Change-Id: Idf8020a30562426e8f939706bf5c2188d5a09798 http://cgit.osmocom.org/openbsc/commit/?id=f6ff1ad7e86d86e0edb5489e4ba7d8f65fef06ce commit f6ff1ad7e86d86e0edb5489e4ba7d8f65fef06ce Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:13:32 2016 +0200 don't use lchan in libmsc Change-Id: Ic7ed7faa2bcc7aae799f41ed4abc2c001bfb61b7 http://cgit.osmocom.org/openbsc/commit/?id=cc80bbdc9a110a0dc20e747d8aa8598871257061 commit cc80bbdc9a110a0dc20e747d8aa8598871257061 Author: Harald Welte <laforge at gnumonks.org> Date: Thu Dec 24 17:06:42 2015 +0100 gsm_04_08.c: Don't set msg->lchan nor msg->dst the BSC-side of the API behind gsm0808_submit_dtap() is doing this resolving again anyway. So let's avoid doing it twice, and avoid having more dependency of the MSC down into the lchan details. Conflicts: openbsc/src/libmsc/gsm_04_08.c Change-Id: I14254be68ee1a48e9f1ce968233414d86c6ba9d5 http://cgit.osmocom.org/openbsc/commit/?id=70e087e5170286a74d2fe122d57e4ca003461024 commit 70e087e5170286a74d2fe122d57e4ca003461024 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 30 15:00:23 2016 +0200 gsm_subscriber_connection: mark BSC specific items The struct shall be split in two later. Change-Id: Ib9666225fb9bfec2cf1e364343560571869fe6a7 http://cgit.osmocom.org/openbsc/commit/?id=8a84beb396b76ef0a34814fdc2fb38d59f534c88 commit 8a84beb396b76ef0a34814fdc2fb38d59f534c88 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 9 21:56:42 2016 +0200 osmo-nitb: exit when MNCC socket init failed http://cgit.osmocom.org/openbsc/commit/?id=26d7568cc5923f3bded14d06307c6d660e18f451 commit 26d7568cc5923f3bded14d06307c6d660e18f451 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Wed May 11 14:12:00 2016 +0200 split bsc_bootstrap_network() in alloc and config Change-Id: I480a09a31a79766ad07b627dd5238b7e37f3be7a http://cgit.osmocom.org/openbsc/commit/?id=8aa3dbd6966ceb265dea4117b3d5e001e586b073 commit 8aa3dbd6966ceb265dea4117b3d5e001e586b073 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Fri May 20 17:15:44 2016 +0200 split subscr_con_allocate()/_free() in bsc_ and msc_ Rename current subscr_con_allocate() and subscr_con_free to bsc_*, and add two separate msc_subscr_con_allocate() and _free(). The msc_subscr_con_free() ignores all lchan members. In libbsc use bsc_*, in libmsc use msc_*. Change-Id: I3cf7c7cafdf4672ec7b26058bba8a77159855257 Future: there will be distinct subscr conns for libbsc and libmsc. http://cgit.osmocom.org/openbsc/commit/?id=4252217cd1de390f6c1107a17ef7d87394418af1 commit 4252217cd1de390f6c1107a17ef7d87394418af1 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Sat May 14 03:24:41 2016 +0200 move to libxsc: net timezone VTY config Leave the timezone VTY output in libbsc's config_write_net(), until the BSC/MSC separation of struct gsm_network is completed. Change-Id: I9712b2e07b4f1ab8d2e4ad40a8d771e98ed25b20 http://cgit.osmocom.org/openbsc/commit/?id=9e4a1e537a1a835cbe67e51e2e0a7c228ca04a15 commit 9e4a1e537a1a835cbe67e51e2e0a7c228ca04a15 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 13:29:33 2016 +0200 Move timezone settings up to network level Time zone used to be configurable per-BTS. In the upcoming MSC-split, no BTS structures will be available on the MSC level. To simplify, drop the ability to manage several time zones in a core network and place the time zone config on the network VTY level, i.e. in gsm_network. If we are going to re-add fine grained time zone settings, it should probably be tied to the LAC. Adjust time zone VTY config code (to be moved to libxsc in subsequent commit). Adjust time zone Ctrl Interface code. Change-Id: I69848887d92990f3d6f969be80f6ef91f6bdbbe8 http://cgit.osmocom.org/openbsc/commit/?id=d2dfcf2926772533ebd448df2e62db90cf39de05 commit d2dfcf2926772533ebd448df2e62db90cf39de05 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 13:56:43 2016 +0200 reinvent connection_for_subscr() and move to libmsc Implement connection_for_subscr() from a completely different angle: instead of looking up lchans in bts structs, look up the subscriber in the global list of gsm_subscriber_connection. static lchan_find() is thus obsoleted. All callers of connection_for_subscr() live in libmsc, so move to libmsc. The move and edit are done in a single commit since the old and new implementation have nothing in common. Future: osmo-cscn will use this, without bts being present. Remove implementation of connection_for_subscr() from channel_test.c -- it is possible that the abort() in there was intended for a regression test, but actually it seems the implementation was merely added for linking reasons, and the abort() added to guard against the NULL return value: no comment nor the commit log indicate that the abort() is test critical; the addition was the only change in channel_test.c for that commit; at the same time a connection_for_subscr() call was added in libmsc. http://cgit.osmocom.org/openbsc/commit/?id=be6f4771e2fe44b752e5f713bc9953c005838f24 commit be6f4771e2fe44b752e5f713bc9953c005838f24 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Thu May 12 01:53:23 2016 +0200 bsc vty: rename show_net_cmd to bsc_show_net_cmd Future: there will be an MSC-land show-net-cmd, so rename to something with bsc in its name. http://cgit.osmocom.org/openbsc/commit/?id=98f036f2dea491b3cfccc68759b7c6c38b4261bb commit 98f036f2dea491b3cfccc68759b7c6c38b4261bb Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Thu May 12 01:16:58 2016 +0200 move to libxsc: network VTY that isn't BSC-specific Keep only BSC specific bits of the 'network' VTY node in bsc_vty.c, move more general VTY commands to xsc_vty.c. Add arg to xsc_vty_init() to pass a config_write_net() function. Pass a libbsc specific config_write_net() function. Future: upcoming omso-cscn will re-use the VTY bits moved to libxsc and pass a different config_write_net() function. Change-Id: I871b7b32a0c56fdce983e409cf244ec487d24e71 http://cgit.osmocom.org/openbsc/commit/?id=25d291b735f67699b6f3ff193465cda4b1bcec10 commit 25d291b735f67699b6f3ff193465cda4b1bcec10 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Wed May 11 18:48:39 2016 +0200 move to libxsc: global vty gsm_network pointer Move gsmnet_from_vty() and the bsc_gsmnet global to xsc_vty.c. Rename bsc_gsmnet to vty_global_gsm_network and make it static to xsc_vty.c, to clearly mark the global variable for VTY use only. Introduce xsc_vty_init() to set vty_global_gsm_network. Change-Id: I26c5c47de08f899b896813d09612d5cb2f8e42d6 http://cgit.osmocom.org/openbsc/commit/?id=e7a1f9707916804a27d0cf68cf8502f3a48ec3cb commit e7a1f9707916804a27d0cf68cf8502f3a48ec3cb Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Thu May 12 03:03:50 2016 +0200 tests: drop unused libmsc, unneeded duplicate libbsc linking Because of libxsc, tests/gsm0408,subscr,trau no longer need libmsc. http://cgit.osmocom.org/openbsc/commit/?id=a7644ce66178799ff21589998e7f85511ed52231 commit a7644ce66178799ff21589998e7f85511ed52231 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 13:27:32 2016 +0200 sms_next_rp_msg_ref(): use direct pointer to next_rp_ref counter libbsc and libmsc will have separate subscriber connection structs. Hence don't rely on gsm_subscriber_connection, but work on a direct pointer to the counter for the next RP reference. The only very thin function in gsm_04_11_helper.c thus becomes obsolete: drop the entire file. Change-Id: I2a2e9ba6a981a385d1f8f07acbe03536ffed0072 http://cgit.osmocom.org/openbsc/commit/?id=65e16e1d8f4b0e52071558331e31719abfbb0283 commit 65e16e1d8f4b0e52071558331e31719abfbb0283 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 13:30:17 2016 +0200 factor out & introduce struct gsm_encr, in xsc.h Factor out encryption info from struct gsm_lchan as struct gsm_encr, placed in xsc.h. Change-Id: I94015fb9dd511c37c1e3058a0963c780b3f700ac Future: this will be used by libmsc's subscriber connection, for osmo-cscn. http://cgit.osmocom.org/openbsc/commit/?id=6ed57776cbaa0bbc8b83504a4531cfb9de9e65ee commit 6ed57776cbaa0bbc8b83504a4531cfb9de9e65ee Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Wed May 11 18:04:00 2016 +0200 fix build: osmo-bsc_nat: change linking order Moving gsm48_create* to libxsc affected linking of osmo-bsc_nat, resulting in an undefined reference to gsm48_extract_mi(). Fix the issue by placing libfilter.a left of libbsc.a. http://cgit.osmocom.org/openbsc/commit/?id=cf79e0953b8ade074e793ad9fd9737f44e3913cc commit cf79e0953b8ade074e793ad9fd9737f44e3913cc Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 12:50:31 2016 +0200 move to libxsc: factor out gen of USSD notify and release complete -- TODO subscr_conn Both libmsc and libbsc need distinct gsm0480_send_ussdNotify() and gsm0480_send_releaseComplete() functions to account for the distinct subscriber connection structs. The current functions live in libmsc, so add the same in libbsc in new file gsm_04_80_utils.c. To avoid too much code dup, move the message generation part of gsm0480_send_ussdNotify() and gsm0480_send_releaseComplete() to new functions gsm0480_gen_ussdNotify() and gsm0480_gen_releaseComplete(), placed in libxsc. Change-Id: I33a84e3c28576ced91d2ea24103123431f551173 http://cgit.osmocom.org/openbsc/commit/?id=e2e0782b1e42d2cb104dd9a896c89dcf911ee6c7 commit e2e0782b1e42d2cb104dd9a896c89dcf911ee6c7 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 14:58:51 2016 +0200 move to libxsc: gsm48_create_mm_serv_rej(), gsm48_create_loc_upd_rej() Used by libbsc, libmsc as well as osmo-bsc and osmo-bsc_nat. http://cgit.osmocom.org/openbsc/commit/?id=f55495a28aee2f033609ade8170011c943e55769 commit f55495a28aee2f033609ade8170011c943e55769 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Sat May 14 00:46:29 2016 +0200 move to libxsc: net init 3: actual move Reincarnate gsm_network_init() as the parts not specific to libbsc. Move from bsc_network_init() those bits that are not BSC specific (and useful for upcoming osmo-cscn). Add libxsc to all linkages that use gsm_network_init(). Note: the only requirement to allow linking gsm_network_init() without libbsc is to keep the call to gsm_net_update_ctype() out of libxsc. The other items are kept out of libxsc because it makes sense semantically. But the separation is not strong in that the BSC specific data members are of course still omnipresent in struct gsm_network. If bsc_network_init() is not called, these are not initialized properly -- for now no users of uninitialized members exist. So this is just a first step towards a sensible split of the BSC and MSC gsm_network structs. The long term aim should be to have entirely separate structs with some common general items. http://cgit.osmocom.org/openbsc/commit/?id=58a8c07ce64bff6ce72b4399fc9240648640ae9f commit 58a8c07ce64bff6ce72b4399fc9240648640ae9f Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Sat May 14 00:57:04 2016 +0200 move to libxsc: net init 2: move bsc_network_init decl to osmo_bsc.h bsc_network_init() is more fit to live in a BSC specific header. Change-Id: I9edfb1e748bb1cb484fadd48b0406f5b3098e89b http://cgit.osmocom.org/openbsc/commit/?id=127d04860074eb69ceac01252e91e9e6da948dd4 commit 127d04860074eb69ceac01252e91e9e6da948dd4 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Sat May 14 00:45:26 2016 +0200 move to libxsc: net init 1: rename to bsc_network_init The gsm_network_init() function initializes a whole lot of BSC specific stuff. Aiming to move some of it to libxsc, first rename it to bsc_network_init(). This will retain the BSC specific stuff when the move is done. Adjust all callers. Future: osmo-cscn will call the more generic part and not the BSC specific part. Change-Id: I4816ae19374390fc5c64972f7cad2e9ec3d8bcc3 http://cgit.osmocom.org/openbsc/commit/?id=03582c6098f0c8792c224c27505fecbbb001f4a8 commit 03582c6098f0c8792c224c27505fecbbb001f4a8 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Wed May 11 14:28:25 2016 +0200 define mncc_recv_cb_t to avoid code dup Put mncc_recv_cb_t in xsc.h to avoid header include complications: if placing right above struct gsm_network, one must include gsm_data.h to use mncc_recv_cb_t as function parameter in a header, which will include gsm_data_shared.h, which will include xsc.h (future knowledge). Since I will need to use mncc_recv_cb_t in xsc.h, including gsm_data.h from there would introduce an #include loop. Avoid that and define mncc_recv_cb_t in xsc.h to begin with. Change-Id: I2e64cffa563750ce9f3172ffba6f9cf5b9280e9c http://cgit.osmocom.org/openbsc/commit/?id=f91b603bb29cdb8c93eca35ca1223d72cb809968 commit f91b603bb29cdb8c93eca35ca1223d72cb809968 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 12:50:31 2016 +0200 Add empty libxsc This will gradually soak up code shared by libbsc and libmsc. http://cgit.osmocom.org/openbsc/commit/?id=b82deb4d16bd9ef2330fc66189daf29f35999659 commit b82deb4d16bd9ef2330fc66189daf29f35999659 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon Sep 26 22:49:12 2016 +0200 log VTY telnet bind only once After libosmocore 55dc2edc89c1a85187ef8aafc09f7d922383231f which outputs 'telnet at <ip> <port>' from telnet_init_dynif(), there's no need to log the telnet VTY bind here anymore. Change-Id: I97a730b28759df1d549a5049f47a3da1c16a3447 http://cgit.osmocom.org/openbsc/commit/?id=660f2ad54b254a95db670016bce1f7e95600e416 commit 660f2ad54b254a95db670016bce1f7e95600e416 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon Sep 26 12:59:36 2016 +0200 vty_test_runner.py: raise exception when MSC socket connection fails Instead of below error, raise an exception to describe what's happening. Seen in a jenkins run on https://gerrit.osmocom.org/#/c/945/2: ERROR: testBSCreload (__main__.TestVTYNAT) ---------------------------------------------------------------------- Traceback (most recent call last): File "./vty_test_runner.py", line 787, in testBSCreload msc = nat_msc_test(self, ip, port) File "./vty_test_runner.py", line 1251, in nat_msc_test return conn UnboundLocalError: local variable 'conn' referenced before assignment Change-Id: Iae26e7345267a21aed0b108b089453832889c9fa http://cgit.osmocom.org/openbsc/commit/?id=72c781a0d61e3d08660ec96037f5bb249c6c298b commit 72c781a0d61e3d08660ec96037f5bb249c6c298b Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon Sep 26 03:18:32 2016 +0200 cosmetic: vty_test_runner.py: add comment for vim auto settings Change-Id: I61a0476a0317b011432bb4f6f593cfdcaf1c072b http://cgit.osmocom.org/openbsc/commit/?id=5822f3f2eab34edc4b4946a62d23febc4243b5b8 commit 5822f3f2eab34edc4b4946a62d23febc4243b5b8 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 9 21:09:47 2016 +0200 mscsplit: directly access gsm_network backpointer from gsm_subscriber_connection The previous commit added a network backpointer to gsm_subscriber_connection. Use it wherever it makes sense, to skip the step through the bts structure. In some places, remove local variables that become unused. Change-Id: I34537025986713291e14c8212a81539b497befd4 http://cgit.osmocom.org/openbsc/commit/?id=e88be14c3acdeb615ae1a2050a424de0ceb50090 commit e88be14c3acdeb615ae1a2050a424de0ceb50090 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 9 22:33:01 2016 +0200 mscsplit: add gsm_network backpointer to gsm_subscriber_connection We want to be able to use a network backpointer without having to go through a gsm_bts struct. This commit adds the network pointer, the subsequent commit applies direct access to the network structure from gsm_subscriber_connection. Change-Id: If8870972f1b3e333c2a4cce97cdc95bdee0382a1 http://cgit.osmocom.org/openbsc/commit/?id=8e14b8a99b424a20b79430900fb3d5d32152cd5b commit 8e14b8a99b424a20b79430900fb3d5d32152cd5b Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 9 21:18:08 2016 +0200 mscsplit: abis vty: decouple from global bsc_gsmnet variable Publish gsmnet_from_vty() in openbsc/vty.h and use in the abis VTY functions. Change-Id: Ib65a18db06b8bc4fc7d56bf56dd64a52cc1cd253 http://cgit.osmocom.org/openbsc/commit/?id=95e556085f58c0592d4faace20927ed3d957cce7 commit 95e556085f58c0592d4faace20927ed3d957cce7 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Tue May 10 13:40:19 2016 +0200 mscsplit: bsc_vty_init(): decouple from global bsc_gsmnet Add an explicit gsm_network pointer instead of using the bsc_gsmnet global. This allows passing a gsm_network struct from the main() scope, which helps to decouple libmsc from libbsc. Change-Id: I9e2c0d9c18d4cebb5efb71565ad84df2bc2e0251 http://cgit.osmocom.org/openbsc/commit/?id=1a7808838adaaea2cf7fb3ec6fae7796f37e0c1c commit 1a7808838adaaea2cf7fb3ec6fae7796f37e0c1c Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Wed May 11 13:53:47 2016 +0200 mscsplit: talloc_ctx_init(): decouple from global tall_bsc_ctx Decouple the talloc context allocations from global tall_bsc_ctx pointer. It appears that talloc_ctx_init() was intended for general use, since it is located in libcommon. It is currently used only by osmo-nitb; but the upcoming osmo-cscn will use it as well. Instead of defining in osmo-nitb main file, add definition in gsm_data.h. Change-Id: I168106599b788f586be0ff0af4699b9746c1b103 http://cgit.osmocom.org/openbsc/commit/?id=f42053f4691748ab08e9179fdc473131357d048c commit f42053f4691748ab08e9179fdc473131357d048c Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 9 19:12:44 2016 +0200 mscsplit: gsm_network_init(): add explicit root talloc ctx Decouple the root talloc context from libbsc's global talloc_bsc_ctx. This allows to define the root talloc ctx from a main() scope, which in turn helps decouple libmsc from libbsc. Change-Id: I92f6b47b1eeea2e8f3fba66f25d7e708e5659f8a http://cgit.osmocom.org/openbsc/commit/?id=0116815f01314817f49d22809bf86f01b350780e commit 0116815f01314817f49d22809bf86f01b350780e Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Mon May 9 21:03:12 2016 +0200 mscsplit: move subscriber conns list into struct gsm_network Replace the global sub_connections llist with gsm_network.subscr_conns. Initialize and apply where applicable. Remove bsc_api_sub_connections(), callers now access gsm_network->subscr_conns directly. This allows using the subscr_conns from libmsc without having to link libbsc. Change-Id: Ice2a7ca04910bcfaaff22539abe68a6349e8631c http://cgit.osmocom.org/openbsc/commit/?id=b243aac29d3a76852f80de1bd372a6365fb951f9 commit b243aac29d3a76852f80de1bd372a6365fb951f9 Author: Neels Hofmeyr <nhofmeyr at sysmocom.de> Date: Wed May 11 13:39:33 2016 +0200 mscsplit: bsc_init: don't pass telnet dummy conn We want to create the telnet for VTY only after reading the config file, and the dummy_conn was a workaround to be able to do so, but is not needed: gsmnet_from_vty() used to expect vty->priv to point to a gsm_network struct, but that is not actually the case anymore. It is using a static pointer to store the gsm_network struct instead. Change-Id: I51e7224c5a4cd5baf564bee871cf2fa6e885cda7 ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)