libosmocore.git branch neels/msgb_ctx updated. 0.9.0-248-g8a3409c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.

gitosis at osmocom.org gitosis at osmocom.org
Tue Sep 27 09:47:10 UTC 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".

The branch, neels/msgb_ctx has been updated
  discards  c69eb4585c89f5a6c28fbe8e5da8804322460f91 (commit)
  discards  c6e058be7b39ec3e91c5db5e238f7f8c0a817621 (commit)
       via  8a3409c4b7fefe4333b619498f2cad0c7c3ae81c (commit)
       via  f45334be29016a36594aacc07c90e262e4994525 (commit)
       via  8319a6799ffc9d4c5e7e094b96af30cbebf89f65 (commit)
       via  4fd6023b0383e7efa3b7b0211104a86ff5d3d4f6 (commit)
       via  e31cf8057f65ec0d8d141eb8f64d5c0e61204f6c (commit)
       via  ba34a2fd73e9803d7e13e90c4fd7e803ce5dedaa (commit)
       via  38d232ee5d2ceb045d9ad6d3a23afcb4972523f7 (commit)
       via  55dc2edc89c1a85187ef8aafc09f7d922383231f (commit)
       via  dbc68177926c7f04d42b418ee6dc559571f4d7f8 (commit)
       via  d0858c2ae9cdd065d09c3a58e60409b7af50111e (commit)
       via  255dac16a4a69e29be62bcc692dabf9cd1a586b5 (commit)
       via  d73c1cc7c25d5e38d848f40598b17d84e77b6a5b (commit)
       via  7b4d727ec5debc3d057686a0a3f0f5f14260a282 (commit)
       via  8e2f7e87f4d854e697c40545326a16e50614dd5c (commit)
       via  13a8fb84f0d83f23e65daa528f2f392ec3b83a75 (commit)
       via  9c9a04705ff431c1e10bf40f2e964a43360441ac (commit)
       via  633a0e76a2fbb31ce6dd4dadb35313aed3aa385c (commit)
       via  5b34f773e441b984d3bc98468fd015eeb4131890 (commit)
       via  2e38d358b6cd450ecf51928f7ae19e56fc6cbb97 (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (c69eb4585c89f5a6c28fbe8e5da8804322460f91)
            \
             N -- N -- N (8a3409c4b7fefe4333b619498f2cad0c7c3ae81c)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=8a3409c4b7fefe4333b619498f2cad0c7c3ae81c

commit 8a3409c4b7fefe4333b619498f2cad0c7c3ae81c
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date:   Fri Sep 16 02:37:24 2016 +0200

    gsm0408_test: initialize msgb talloc ctx
    
    Change-Id: Ib26214add1932e93651c248cc09fbc68339b4dce

http://cgit.osmocom.org/libosmocore/commit/?id=f45334be29016a36594aacc07c90e262e4994525

commit f45334be29016a36594aacc07c90e262e4994525
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date:   Fri Sep 16 00:15:56 2016 +0200

    msgb: add msgb_talloc_ctx_init(), deprecate msgb_set_talloc_ctx()
    
    So far each and every main() scope creates a msgb talloc context and either
    passes it to msgb_set_talloc_ctx() or sets tall_msgb_ctx directly (by defining
    it extern first).
    
    Remove some code duplication: add one central function that creates the "msgb"
    talloc context for all.
    
    Most users of msgb employ a talloc_named_const(), but osmo-bts uses a
    talloc_pool() instead. Offer both ways by means of the pool_size argument, and
    for both ways make sure the context is called "msgb".
    
    Suggest that msgb users should move to this new function: deprecate
    msgb_set_talloc_ctx(). To be able to do so, include core/defs.h in msgb.h.
    
    There's a tradeoff between hiding the msgb talloc context behind API that tries
    to guess all use cases versus avoiding code dup. This patch opts against code
    dup and boldly assumes that all future use is covered.
    
    Also, the new function suggests to not access tall_msgb_ctx directly, which can
    be considered a style improvement.
    
    It seems that not all main scopes that use msgb actually initialize the msgb
    ctx. As a fallback for these, explicitly initialize tall_msgb_ctx to NULL.
    
    Change-Id: I747fbbf977c4d2c868c8dead64cfc5fd86eb8d4c

-----------------------------------------------------------------------

Summary of changes:
 include/osmocom/core/timer.h   |  11 ++
 include/osmocom/gprs/gprs_ns.h |   3 +-
 src/Makefile.am                |   2 +-
 src/ctrl/control_if.c          |  42 +----
 src/gb/gprs_bssgp.c            |   8 +-
 src/gb/gprs_ns.c               |   4 +-
 src/logging.c                  |   3 +-
 src/timer.c                    |   8 +-
 src/timer_gettimeofday.c       |  58 ++++++
 src/vty/command.c              |   2 +-
 src/vty/telnet_interface.c     |   9 +-
 tests/bits/bitrev_test.c       |   9 +-
 tests/bits/bitrev_test.ok      |  50 +++--
 tests/gb/bssgp_fc_test.c       |   4 +-
 tests/testsuite.at             |   2 +-
 tests/timer/timer_test.c       | 104 ++++++-----
 tests/timer/timer_test.ok      | 372 +++++++++++++++++++++++++++++++++++-
 utils/conv_gen.py              | 414 +++++++++++++++++++++++------------------
 18 files changed, 796 insertions(+), 309 deletions(-)
 create mode 100644 src/timer_gettimeofday.c


hooks/post-receive
-- 
An utility library for Open Source Mobile Communications



More information about the osmocom-commitlog mailing list