openbsc.git branch master updated. 0.15.0-521-g87ef68e

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.

gitosis at osmocom.org gitosis at osmocom.org
Thu Nov 10 17:05:18 UTC 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, master has been updated
       via  87ef68eb33d463d8aad1511a272cbdb779f1ba19 (commit)
       via  f926f45c4bb8d261cdbefec6aba65a167c6bbc92 (commit)
      from  194b4cb4fd2bc7c0ca71fad14a314a517f5d4415 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=87ef68eb33d463d8aad1511a272cbdb779f1ba19

commit 87ef68eb33d463d8aad1511a272cbdb779f1ba19
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date:   Thu Nov 10 02:18:00 2016 +0100

    OM2000: disallow ip.access style TCH/F_PDCH pchan type
    
    For TCH/F_PDCH, return an invalid chan comb (0) and print an error message
    that hints at the proper pchan type to use instead: TCH/F_TCH/H_PDCH
    
    Change-Id: Ibe0f944573f0a6d1be4bf7cf4986c4b2b3bd6d0d

http://cgit.osmocom.org/openbsc/commit/?id=f926f45c4bb8d261cdbefec6aba65a167c6bbc92

commit f926f45c4bb8d261cdbefec6aba65a167c6bbc92
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date:   Mon Oct 31 18:16:34 2016 +0100

    OM2000: for TS conf of dyn TS, always send TCH/F chan comb
    
    When OM2K sets up the timeslots with the BTS, the dynamic channel state
    is not yet resolved to any particular pchan type. Instead of using the
    dyn state, always advertise dynamic timeslots as pchan2comb(TCH/F).
    
    In the past, the Ericsson dynamic timeslots were handled as pchan type
    TCH/F_PDCH. This is a mistake, as this pchan type is intended for
    the ip.access dynamic PDCH way of dynamic channels. In any case, in the
    initial state of this pchan type, the timeslot was initialized as
    pchan2comb(TCH/F) because the ts->flags do not reflect an active PDCH
    yet. In short, this patch does not change the behavior of TCH/F_PDCH
    timeslots, only clarifies it.
    
    It would in fact make sense to disallow use of TCH/F_PDCH for OM2K,
    but that should probably be a separate patch.
    
    The proper pchan to use for Ericsson dynamic timeslots is
    TCH/F_TCH/H_PDCH. These do not use ts->flags, but ts->dyn.* as state,
    which first reflects pchan_want == pchan_is == GSM_PCHAN_NONE. Hence
    the timeslot was initialized by OM2K as pchan type zero, which is
    unknown / invalid. So, instead of using pchan_is, which is not yet
    reflecting anything meaningful, always initialize as TCH/F chan comb,
    as Ericsson hardware apparently expects it.
    
    Change-Id: If0693f7c5c85977b0e4acbc701ee5d635434d0d1

-----------------------------------------------------------------------

Summary of changes:
 openbsc/src/libbsc/abis_om2000.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)



More information about the osmocom-commitlog mailing list