osmo-bts.git branch neels/dyn_pdch_trx updated. 0.4.0-218-g28d5e93

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.

gitosis at osmocom.org gitosis at osmocom.org
Tue Jul 19 09:32:49 UTC 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".

The branch, neels/dyn_pdch_trx has been updated
  discards  980fd1f8cdec5a3c6dee28a51fdd53165d30c080 (commit)
  discards  af7b7feb11fc13e0e81cf7619d8d2c061c9b63b8 (commit)
  discards  1eda517edd81cd464d0b658a7f8b2ae9dd6e8fff (commit)
  discards  4b0355256bdacb0cfb2a57d89595d3887aee7b42 (commit)
  discards  eeab9e75a69378ab936a8cc1dbac583f9eb51367 (commit)
  discards  cb854fd531b09f25f94a9bf987dfd777164d7352 (commit)
       via  28d5e939e9412ede73e3c4a758ff84c020e504c3 (commit)
       via  72a93b21ab2984937fd9353cdcd4965b67e041f7 (commit)
       via  9577b2e1db9476f6e30a6cfe51ca3e7b8f934fda (commit)
       via  0739406e5dadfd0c58d968284e2df83231f16689 (commit)
       via  8501d8f7f788db97aebd7500f59efc6c913f965d (commit)
       via  939dce4ce4bfb975c053a8de04d418afa0ac3d14 (commit)
       via  c890c8abe7b93693ac6d20cc0c1076b4549ae3ba (commit)
       via  cff0d44e53bce69a9c8831925d1489c4024ccb1c (commit)
       via  b8f5f4e176c5402ec529225864313f0787502049 (commit)
       via  b151301c6c91f8ecc02aa18ee746b02cf61f6fee (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (980fd1f8cdec5a3c6dee28a51fdd53165d30c080)
            \
             N -- N -- N (28d5e939e9412ede73e3c4a758ff84c020e504c3)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=28d5e939e9412ede73e3c4a758ff84c020e504c3

commit 28d5e939e9412ede73e3c4a758ff84c020e504c3
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Tue Jul 19 11:32:26 2016 +0200

    wip
    
    Change-Id: I3724b5fc2e1d9ae06444873dc6b05d61104e4025

http://cgit.osmocom.org/osmo-bts/commit/?id=72a93b21ab2984937fd9353cdcd4965b67e041f7

commit 72a93b21ab2984937fd9353cdcd4965b67e041f7
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Fri Jul 8 03:06:20 2016 +0200

    cosmetic: osmo-bts-trx: remove obsolete commented code
    
    Change-Id: I1a5b6a9d9592952877c6640e5117dc269d67925a

http://cgit.osmocom.org/osmo-bts/commit/?id=9577b2e1db9476f6e30a6cfe51ca3e7b8f934fda

commit 9577b2e1db9476f6e30a6cfe51ca3e7b8f934fda
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Fri Jul 8 03:05:46 2016 +0200

    osmo-bts-trx: clear TS flags on CHANNEL OPSTART
    
    Change-Id: Ia6de5960f910a9db32c55dc1d38527e871c76e99

http://cgit.osmocom.org/osmo-bts/commit/?id=0739406e5dadfd0c58d968284e2df83231f16689

commit 0739406e5dadfd0c58d968284e2df83231f16689
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Fri Jul 8 03:04:37 2016 +0200

    fix debug log: pick proper l1ts
    
    Change-Id: Ic3d1c1c61c2ca1adc043ec02d7249e2b0798ae12

http://cgit.osmocom.org/osmo-bts/commit/?id=8501d8f7f788db97aebd7500f59efc6c913f965d

commit 8501d8f7f788db97aebd7500f59efc6c913f965d
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Fri Jul 8 03:03:30 2016 +0200

    scores of temporary debug logs
    
    Change-Id: I4cf69f301295a70a10b920039c8b874db18de672

http://cgit.osmocom.org/osmo-bts/commit/?id=939dce4ce4bfb975c053a8de04d418afa0ac3d14

commit 939dce4ce4bfb975c053a8de04d418afa0ac3d14
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Tue Jul 5 15:32:30 2016 +0200

    WIP
    
    Change-Id: Ib2a9c7e126fe4a5c91a0ef6c3973071970292d65

http://cgit.osmocom.org/osmo-bts/commit/?id=c890c8abe7b93693ac6d20cc0c1076b4549ae3ba

commit c890c8abe7b93693ac6d20cc0c1076b4549ae3ba
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Fri Jul 8 02:21:54 2016 +0200

    osmo-bts-trx: init OML only once by sending AVSTATE_OK with OPSTATE_ENABLED
    
    When receiving an OPSTART for the BTS object, also set the availability state
    to OK.
    
    Before, the availability would remain at NM_AVSTATE_DEPENDENCY, which caused an
    unfortunate chain reaction resulting in osmo-bts-trx going through the
    initialization sequence twice:
    
      BTS    BSC
       |<-----|   SITE_MANAGER OPSTART
     n |----->|   BTS state change: OPSTATE_DISABLED, AVSTATE_DEPENDENCY
     o |      |     This signals to nm_statechg_event() in bts_ipaccess_nanobts.c
     r |      |     to (a) Set BTS Attributes and (b) send BTS OPSTART
     m |<-----|   Set BTS Attributes (a)
     a |      |     When osmo-bts-trx receives a Set BTS Attributes, it sends
     l |----->|   CHANNEL state change: OPSTATE_DISABLED  x8
       |      |     This signals the BSC to Set CHANNEL Attributes and OPSTART
     i |<-----|   Set CHANNEL Attributes  x8
     n |<-----|   CHANNEL OPSTART  x8
     i |----->|   CHANNEL state change: OPSTATE_ENABLED, AVSTATE_OK  x8
     t |      |
       |<-----|   BTS OPSTART (b)
       |      |     osmo-bts-trx immediately replies with:
       |----->|   BTS state change: OPSTATE_ENABLED, AVSTATE_DEPENDENCY
       |      |     Unfortunately, availability is left at DEPENDENCY,
       |      |     and the NM_OC_BTS case in nm_statechg_event() only
       |      |     checks for availability, not for the opstate.
       |      |     Hence nm_statechg_event() again feels inclined to
       |      |     to (a) Set BTS Attributes and (b) send BTS OPSTART,
       |      |
     --+------+----- This is where the second round starts
       |      |
     s |<-----|   Set BTS Attributes (a)
     e |      |     When osmo-bts-trx receives a Set BTS Attributes, it sends
     c |----->|   CHANNEL state change: OPSTATE_DISABLED  x8
     o |      |     All channels are disabled again, and then re-launched:
     n |<-----|   Set CHANNEL Attributes  x8
     d |<-----|   CHANNEL OPSTART  x8
       |----->|   CHANNEL state change: OPSTATE_ENABLED, AVSTATE_OK  x8
       |      |
     i |<-----|   BTS OPSTART (b)
     n |      |     osmo-bts-trx again sets the OPSTATE_ENABLED, but since
     i |      |     this time it was already enabled, no further state change
     t |      |     is sent back to the BSC.
    
    This nightmare pivots on two hinges:
    
    1. osmo-bts-trx fails to set BTS availability to AVSTATE_OK.
    2. nm_statechg_event() fails to heed the OPSTATE_ENABLED of the BTS state
       change.
    
    Note, the configured channels from the first round were not actually taken
    down, only the OML OPSTATE_DISABLED were sent.
    
    In this commit, fix the osmo-bts-trx side: send AVSTATE_OK for the BTS object
    upon sending OPSTATE_ENABLED, so that only the part marked "normal init" above
    is run.
    
    This change applies the same fix to other OML objects, which should make sense
    in the same manner, within the current hackish OML implementation:
    * NM_OC_BTS
    * NM_OC_SITE_MANAGER
    * NM_OC_BASEB_TRANSC
    * NM_OC_GPRS_NSE
    * NM_OC_GPRS_CELL
    * NM_OC_GPRS_NSVC
    
    See OS#1770 for BTS and NITB logs.
    
    Fixes: OS#1770
    
    Change-Id: I08aa861f6100568c79750f4fbc9a32e1557b9304

-----------------------------------------------------------------------

Summary of changes:
 include/osmo-bts/scheduler.h     | 4 ++--
 src/common/oml.c                 | 3 +++
 src/osmo-bts-trx/l1_if.c         | 7 ++++---
 src/osmo-bts-trx/scheduler_trx.c | 8 ++++----
 4 files changed, 13 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
Osmocom BTS-side code (Abis, scheduling, ...)



More information about the osmocom-commitlog mailing list