osmo-pcu.git branch jerlbeck/wip/edge updated. 0.2-676-g1bba7e7

gitosis at osmocom.org gitosis at osmocom.org
Tue Jan 12 16:41:25 UTC 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".

The branch, jerlbeck/wip/edge has been updated
  discards  9befd6bfffa4d90f8747ec160e884fe4adfd70c8 (commit)
  discards  70b7dcc43eaac55f3be292fc0303c45a7732bdae (commit)
  discards  d4a888abf43e0174844baf210ead086cf0d31944 (commit)
  discards  95420a04c7d63cf787115c365821f34dd5a7a72e (commit)
  discards  df2461895c66d49660ce691ae5b69c2e92430e2d (commit)
       via  1bba7e73d73a19ceee2c681066d5fd398bef0de8 (commit)
       via  397f1c6397b053d4bafb26959cc0a9f7e0857dbe (commit)
       via  973bcf27f8231d4ef1d9bb916f4acd80e02fb5a5 (commit)
       via  5fe124dd272b5fa1627b0f318ecb0f98c6cc3c57 (commit)
       via  8813302b5d06467ee41ccfe871ad29387a051efb (commit)
       via  cffe012c1b289ae559d02cf1e9617f5dd411b978 (commit)
       via  da1a3b26adb96736891c5cbad3d5a1456fbf5448 (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (9befd6bfffa4d90f8747ec160e884fe4adfd70c8)
             N -- N -- N (1bba7e73d73a19ceee2c681066d5fd398bef0de8)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 1bba7e73d73a19ceee2c681066d5fd398bef0de8
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Jan 12 17:02:49 2016 +0100

    edge: Use rlc_data_to_dl_append in create_new_bsn (TODO)
    Currently TBF related tasks (status changes, counter updates,
    LLC dummy command insertion) as well as
    RLC data block generation are done within create_new_bsn.
    The data block creation part has already been copied to
    the stateless Encoding::rlc_data_to_dl_append function.
    This commit changes create_new_bsn to use the encoder function and
    just care about the TBF related stuff.
    Since the rlc_data_to_dl_append function has been validated against
    the test cases being described in annex B of TS 44.060, this
    commit fixes an encoder bug which leads to broken LLC frames in
    a special case (see example B.2, the main header's E bit was
    erroneously set to 1 in that case). When this happens, the LLC frame
    will get discarded after reassembly, so that TCP will have to
    retransmit the lost packet.
    Sponsored-by: On-Waves ehf


commit 397f1c6397b053d4bafb26959cc0a9f7e0857dbe
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Jan 12 11:58:13 2016 +0100

    edge: Add Encoding::rlc_data_to_dl_append
    This function appends a single chunk to an RLC downlink data block.
    The implementation is basically taken from the
    gprs_rlcmac_dl_tbf::create_new_bsn method without the TBF related
    functionality and any side effects.
    Note that it still only supports GRPS.
    Sponsored-by: On-Waves ehf


commit 973bcf27f8231d4ef1d9bb916f4acd80e02fb5a5
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jan 11 16:15:45 2016 +0100

    edge: Use RLC data block encoding functions
    This commit removes the use of struct rlc_dl_header from
    gprs_rlcmac_dl_tbf::create_dl_acked_block and
    gprs_rlcmac_dl_tbf::create_new_bsn. Instead of patching the
    data area directly, the RLC block encoding functions are used.
    Note that the data unit encoding is still hard-coded to GPRS in
    create_new_bsn, so using MCS 1-4 (albeit being supported by the
    encoder) will not work yet.
    Sponsored-by: On-Waves ehf


commit 5fe124dd272b5fa1627b0f318ecb0f98c6cc3c57
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jan 11 16:12:01 2016 +0100

    test: Add function name printfs (TODO)
    Some of these are missing and added by this commit.
     - Add all of them
     - Fix ok file(s)
    Sponsored-by: On-Waves ehf


commit 8813302b5d06467ee41ccfe871ad29387a051efb
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jan 11 13:27:07 2016 +0100

    tbf: Remove obsolete TLLI functions
    This commit removes gprs_rlcmac_tbf::extract_tlli and
    Sponsored-by: On-Waves ehf


commit cffe012c1b289ae559d02cf1e9617f5dd411b978
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Jan 8 10:07:53 2016 +0100

    edge: Add encoder for downlink RLC data blocks
    Currently the (GPRS) RLC block encoding is done by setting the
    header fields directly in gprs_rlcmac_dl_tbf::create_new_bsn.
    This is much more complex with EGPRS, since the data fields are
    not byte aligned, the header formats depend on the header type,
    and the mapping of bits to bytes is LSB first.
    This commit adds Encoding::rlc_write_dl_data_header which writes
    the header according to the given gprs_rlc_data_header structure.
    Encoding::rlc_copy_from_aligned_buffer is also added to copy
    byte sequences into the message.
    Note that the actual encoding of data units is not yet present.
    Sponsored-by: On-Waves ehf


commit da1a3b26adb96736891c5cbad3d5a1456fbf5448
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jan 11 11:15:45 2016 +0100

    edge: Add init functions for gprs_rlc_data_info
    Add the functions gprs_rlc_data_info_init_dl/ul which initialise a
    gprs_rlc_data_info structure depending on the coding scheme. The
    fields num_data_blocks, data_offs_bits, cs, and the data_blocks are
    valid after this call. The other fields are set to 0.
    The data blocks are initialised to the correct data_len, e == 1
    (no extension header field), cv == 15 (not a final block). The other
    data block fields are set to 0.
    The gprs_rlc_data_block_info can also be initialised separately
    by using the gprs_rlc_data_block_info_init function.
    Sponsored-by: On-Waves ehf


Summary of changes:
 src/encoding.cpp        | 121 +++++++++++++++++++++++
 src/encoding.h          |  14 +++
 src/rlc.cpp             |  20 +++-
 src/rlc.h               |   6 +-
 src/tbf_dl.cpp          | 136 ++++----------------------
 tests/edge/EdgeTest.cpp | 253 +++++++++++++++++++++++++++++++++++++++++++++++-
 tests/edge/EdgeTest.ok  |   2 +
 tests/tbf/TbfTest.err   | 235 ++++++++++++++++++++++++++++----------------
 tests/tbf/TbfTest.ok    |   2 +
 9 files changed, 585 insertions(+), 204 deletions(-)


More information about the osmocom-commitlog mailing list