libosmocore.git branch master updated. 0.9.6-12-ga3953e0

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.

gitosis at osmocom.org gitosis at osmocom.org
Thu Dec 15 20:16:19 UTC 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".

The branch, master has been updated
       via  a3953e0536a07b571fe3314d6e257db79b2dbe64 (commit)
       via  725698a4f15b9403620951961984b68ed4148992 (commit)
       via  6a13e7f563e3983c51363704bd2a65e691bafc3e (commit)
      from  886d6fdec605e47ec19a3e37dd9596c525178a54 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=a3953e0536a07b571fe3314d6e257db79b2dbe64

commit a3953e0536a07b571fe3314d6e257db79b2dbe64
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date:   Wed Dec 14 18:34:30 2016 +0100

    typo in comment for osmo_fsm_log_addr()
    
    Change-Id: I6f683ed0c864a87bf1232994eb2deaf9b313a244

http://cgit.osmocom.org/libosmocore/commit/?id=725698a4f15b9403620951961984b68ed4148992

commit 725698a4f15b9403620951961984b68ed4148992
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date:   Wed Dec 14 17:24:54 2016 +0100

    fsm: log caller's source for events and state changes, not fsm.c lines
    
    When looking at log output, it is not interesting to see that a state
    transition's petty details are implemented in fsm.c. Rather log the *caller's*
    source file and line that caused an event, state change and cascading events.
    
    To that end, introduce LOGPSRC() absorbing the guts of LOGP(), to be able to
    explicitly pass the source file and line information.
    
    Prepend an underscore to the function names of osmo_fsm_inst_state_chg(),
    osmo_fsm_inst_dispatch() and osmo_fsm_inst_term(), and add file and line
    arguments to them. Provide the previous names as macros that insert the
    caller's __BASE_FILE__ and __LINE__ constants for the new arguments. Hence no
    calling code needs to be changed.
    
    In fsm.c, add LOGPFSMSRC to call LOGPSRC, and add LOGPFSMLSRC, and use them in
    above _osmo_fsm_inst_* functions.
    
    In addition, in _osmo_fsm_inst_term(), pass the caller's source file and line
    on to nested event dispatches, so showing where a cascade originated from.
    
    Change-Id: Iae72aba7bbf99e19dd584ccabea5867210650dcd

http://cgit.osmocom.org/libosmocore/commit/?id=6a13e7f563e3983c51363704bd2a65e691bafc3e

commit 6a13e7f563e3983c51363704bd2a65e691bafc3e
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date:   Wed Dec 14 17:37:34 2016 +0100

    fsm: add LOGPFSML to pass explicit logging level
    
    Provide one central LOGPFSML to print FSM information, take the FSM logging
    subsystem from the FSM instance but use an explicitly provided log level
    instead of the FSM's default level.
    
    Use to replace some, essentially, duplications of the LOGPFSM macro.
    
    In effect, the fsm_test's expected error changes, since the previous code dup
    for logging events used round braces to indicate the fi's state, while the
    central macro uses curly braces.
    
    Change-Id: If295fdabb3f31a0fd9490d1e0df57794c75ae547

-----------------------------------------------------------------------

Summary of changes:
 include/osmocom/core/fsm.h     | 48 +++++++++++++++++++++++++-----
 include/osmocom/core/logging.h | 27 ++++++++++++++---
 src/fsm.c                      | 67 +++++++++++++++++++++++++++++-------------
 tests/fsm/fsm_test.err         |  2 +-
 4 files changed, 110 insertions(+), 34 deletions(-)


hooks/post-receive
-- 
An utility library for Open Source Mobile Communications



More information about the osmocom-commitlog mailing list