This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.
gitosis at osmocom.org gitosis at osmocom.orgThis is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "wireshark with Osmocom specific dissectors". The branch, laforge/gsmtap-log has been created at 3a207894a493598a3047fdfce88e72e3de21f774 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/wireshark/commit/?id=3a207894a493598a3047fdfce88e72e3de21f774 commit 3a207894a493598a3047fdfce88e72e3de21f774 Author: Harald Welte <laforge at gnumonks.org> Date: Fri Dec 2 22:29:36 2016 +0100 Add GSMTAP logging sub-dissector Applications can also use GSMTAP framing to convey log messages which would traditionally be printed on strderr or on log files. This allows the ordered/interspersed display of protocol messages with log lines from the applications that send or received those messages. Change-Id: I0de723445e5b5ce0199a4081808111240a9ed047 http://cgit.osmocom.org/wireshark/commit/?id=54f48c8b92475523a49c15cd549fb5408e96ea8d commit 54f48c8b92475523a49c15cd549fb5408e96ea8d Author: Jaap Keuter <jaap.keuter at xs4all.nl> Date: Wed Nov 30 18:00:12 2016 +0100 echo: decide on req/resp based on matched port Since the use of 'Decode as' can result in another port number than the default port (7) being the service port, this should be checked against. Change-Id: I93383613115595fff621e2fb9ab7959cd448c01e Reviewed-on: https://code.wireshark.org/review/18991 Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter at xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=14bae88e0f7827ccf470704a9b997dfd5e665319 commit 14bae88e0f7827ccf470704a9b997dfd5e665319 Author: Chuck Lever <chuck.lever at oracle.com> Date: Wed Nov 9 09:48:50 2016 -0500 packet-rpcrdma: Display length and version fields in decimal Display length fields in decimal, just as they are displayed by the RDMA RETH dissector. Display version fields in decimal, just as they are displayed by the RPC dissector. RDMA offset fields are left in hexadecimal since they are essentially addresses, and at least the Linux RPC-over-RDMA implementation has debugging messages that display these as hexadecimal values. Change-Id: I7206970675ca0ca486b3a2837b6dbb1c4d764091 Signed-off-by: Chuck Lever <chuck.lever at oracle.com> Reviewed-on: https://code.wireshark.org/review/19028 Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=aecff2f67995905e58cacd9c4b7e5a7220a26e3b commit aecff2f67995905e58cacd9c4b7e5a7220a26e3b Author: Guy Harris <guy at alum.mit.edu> Date: Fri Dec 2 13:15:41 2016 -0800 Include config.h first, for large-file-related #defines. Change-Id: Iced77fb65c2db8bc370cefe4c48c972fe1262f92 Reviewed-on: https://code.wireshark.org/review/19039 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=d5bdf7bac0c829cb00def4abb08444fe96d51e06 commit d5bdf7bac0c829cb00def4abb08444fe96d51e06 Author: Chuck Lever <chuck.lever at oracle.com> Date: Wed Nov 9 10:06:45 2016 -0500 packet-rpcrdma: Dissector should exit when frame is not RPC-over-RDMA On an RDMA transport, RPC protocol never appears in a frame by itself. If RPC-over-RDMA is not present, then RPC is by definition not present as an InfiniBand data payload. Bug: 13195 Change-Id: Icaea9d4936477af32adc73140c67539e977a7a9a Signed-off-by: Chuck Lever <chuck.lever at oracle.com> Reviewed-on: https://code.wireshark.org/review/19024 Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=4dc787361202e6ba142672b312e44dd296db8852 commit 4dc787361202e6ba142672b312e44dd296db8852 Author: Guy Harris <guy at alum.mit.edu> Date: Fri Dec 2 13:05:53 2016 -0800 Include config.h first, for large-file-related #defines. Change-Id: Id71326bc89e1461b100df99b618a1c49256b93af Reviewed-on: https://code.wireshark.org/review/19037 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=6f373175396a06b8e1a91acec6031322d91ef9dd commit 6f373175396a06b8e1a91acec6031322d91ef9dd Author: Guy Harris <guy at alum.mit.edu> Date: Fri Dec 2 11:18:50 2016 -0800 Include config.h at the very beginning of all Flex scanners. That way, if we #define anything for large file support, that's done before we include any system header files that either depend on that definition or that define it themselves if it's not already defined. Change-Id: I9b07344151103be337899dead44d6960715d6813 Reviewed-on: https://code.wireshark.org/review/19035 Petri-Dish: Guy Harris <guy at alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=2ec9093ed8a21737bfad150bc9daa6b3a6bb103b commit 2ec9093ed8a21737bfad150bc9daa6b3a6bb103b Author: Michael Mann <mmann78 at netscape.net> Date: Fri Dec 2 11:57:43 2016 -0500 Make SMB2 MessageId field a FT_UINT64 Also adjust the smb2_info_t structure that handles the value. Bug: 12915 Change-Id: Ia314b8dc840b9d26d2c1d185f06ef93f242a3a7b Reviewed-on: https://code.wireshark.org/review/19019 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d2e2d7c1a820fd6612f54ed4bccd1671a720c2a4 commit d2e2d7c1a820fd6612f54ed4bccd1671a720c2a4 Author: Guy Harris <guy at alum.mit.edu> Date: Fri Dec 2 10:27:51 2016 -0800 Put tap-exportobject.h into the release tarball. Change-Id: I5c103c5b513c32c5de0ea90956f9049fd6b0edec Reviewed-on: https://code.wireshark.org/review/19022 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=20c57cb298e4f3b7ac66a22fb7477e4cf424a11b commit 20c57cb298e4f3b7ac66a22fb7477e4cf424a11b Author: Moshe Kaplan <me at moshekaplan.com> Date: Thu Nov 24 09:37:01 2016 -0500 Enable exporting objects with tshark A new "--export-object <protocol>,<destdir>" option is added to tshark. This required refactoring Export Object behavior in all GUIs to give the export object handling to the dissector, rather than the ui layer. Included in the refactoring was fixing some serious memory leaks in Qt Export Object dialog, crash due to memory scope issues in GTK Export Object dialog, and addition sorting column feature in Qt dialog (set up by creating a widget to manage the items that were previously leaking memory) Bug: 9319 Ping-Bug: 13174 Change-Id: I515d7662fa1f150f672b1476716f347ec27deb9b Reviewed-on: https://code.wireshark.org/review/18927 Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> Tested-by: Michael Mann <mmann78 at netscape.net> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=9ca313cfbe4993a0a36520d216a3e4282b0b7b99 commit 9ca313cfbe4993a0a36520d216a3e4282b0b7b99 Author: Jaap Keuter <jaap.keuter at xs4all.nl> Date: Wed Nov 30 23:37:32 2016 +0100 BOOTP: Fix V-I Vendor-Specific Information Option Apply the same value checks to the vendor generic suboption dissection as is done for the Cable lab and ADSL forum ones. See https://ask.wireshark.org/questions/57695 for an example issue. Change-Id: I4fe07d07cf0a93f4693e5ff54dd70c008701cf41 Reviewed-on: https://code.wireshark.org/review/18999 Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter at xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3b5d5adcd3cbd941509485c1ced5d0599f545ed1 commit 3b5d5adcd3cbd941509485c1ced5d0599f545ed1 Author: Dario Lombardo <lomato at gmail.com> Date: Fri Dec 2 10:19:12 2016 +0100 autotools: fix typo. The required executable is rpmbuild and not rpm. Change-Id: Iba1bff9c7fb6907659451a977ad8ab98efb169da Reviewed-on: https://code.wireshark.org/review/19015 Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=74fb68d3662881cfa9f11fd29d73144da3d294aa commit 74fb68d3662881cfa9f11fd29d73144da3d294aa Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Fri Dec 2 09:26:29 2016 +0100 simple_dialog(.h): fix parameter 'Type' not found in the function declaration [-Wdocumentation] Change-Id: I3dc476af941221b1d59f31bd6f639a49059e38a9 Reviewed-on: https://code.wireshark.org/review/19014 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6ac40522af625971a6cb7b7e1ab56c7834e335db commit 6ac40522af625971a6cb7b7e1ab56c7834e335db Author: Guy Harris <guy at alum.mit.edu> Date: Fri Dec 2 02:32:39 2016 -0800 Make sure config.h is included before inet_addr.h. Otherwise, _FILE_OFFSET_BITS might be defined by a header file included by inet_addr.h before it gets defined by config.h. Change-Id: I5987b3f1493b81fd2d427d9792b9606117b255d0 Reviewed-on: https://code.wireshark.org/review/19018 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=6e0278989c29a401f22485fd295bcc2486160241 commit 6e0278989c29a401f22485fd295bcc2486160241 Author: Guy Harris <guy at alum.mit.edu> Date: Fri Dec 2 01:29:26 2016 -0800 Do *NOT* strip newlines from the standard input of sed. There is *NO* guarantee that sed will do anything useful with input that doesn't have a newline and, in fact, the default sed in Solaris 11 doesn't produce *any* output if you hand it input with no newline. Furthermore, doing xxx=`yyy` will, if the output of yyy has newlines at the end, strip them; to quote section 2.6.3 "Command Substitution" of the Single UNIX Specification: The shell shall expand the command substitution by executing command in a subshell environment (see Shell Execution Environment) and replacing the command substitution (the text of command plus the enclosing "$()" or backquotes) with the standard output of the command, removing sequences of one or more <newline> characters at the end of the substitution. so there's no need to strip the newline. Change-Id: Ia710f67a42739c1e218eb9fec53a54bde6e010da Reviewed-on: https://code.wireshark.org/review/19016 Petri-Dish: Guy Harris <guy at alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=8d927a98fdac92b562cfd5c769f7ae7bed0ace2d commit 8d927a98fdac92b562cfd5c769f7ae7bed0ace2d Author: Gerald Combs <gerald at wireshark.org> Date: Thu Dec 1 14:32:29 2016 -0800 Qt: Fix QStyledItemDelegate assertions. QStyledItemDelegate::paint asserts if you pass it an empty QModelIndex. We were doing this in PercentBarDelegate and TimelineDelegate in order to keep it from drawing any text. Return an empty string from ::displayText instead, which appears to be the correct way to paint without text. Bug: 13180 Change-Id: I8064d9575e04e95a926797eec7f6ad2b0bfef1c0 Reviewed-on: https://code.wireshark.org/review/19007 Reviewed-by: Gerald Combs <gerald at wireshark.org> Petri-Dish: Gerald Combs <gerald at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=672a5bd5468322cc3264886cf1655519f2dbf503 commit 672a5bd5468322cc3264886cf1655519f2dbf503 Author: Guy Harris <guy at alum.mit.edu> Date: Thu Dec 1 18:24:58 2016 -0800 The Kerberos dissector include Kerberos header, and needs KRB5_CFLAGS. Change-Id: I9a0e6ff09292fafca970e8ff423f18a835b5f2c4 Reviewed-on: https://code.wireshark.org/review/19011 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=333832ebf7718dd6d43a89a4e370683bae062a4b commit 333832ebf7718dd6d43a89a4e370683bae062a4b Author: Gerald Combs <gerald at wireshark.org> Date: Thu Dec 1 16:15:10 2016 -0800 Prefs: Use g_utf8_strlen instead of strlen. Change-Id: I99e2906b3c31f4aebcda44f4433f0fdd457ced3b Reviewed-on: https://code.wireshark.org/review/19008 Petri-Dish: Gerald Combs <gerald at wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Gerald Combs <gerald at wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=007976b3abeb762b362b3c9d65f8d8bee28b7e81 commit 007976b3abeb762b362b3c9d65f8d8bee28b7e81 Author: Guy Harris <guy at alum.mit.edu> Date: Thu Dec 1 16:42:30 2016 -0800 Clean up error messages. Also, use elif in some chains of tests, to make it a bit clearer that the cases in question are disjoint. Change-Id: I6dc92d536450c7ac3db6ee118581a5ed0c3ce80c Reviewed-on: https://code.wireshark.org/review/19009 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=d28a68717c45132269c734284bc1ce58cf193026 commit d28a68717c45132269c734284bc1ce58cf193026 Author: Jeff Morriss <jeff.morriss.ws at gmail.com> Date: Thu Dec 1 13:04:08 2016 -0500 RPM: fix the date in a recent changelog entry. RPM complains when the date isn't valid. Change-Id: I859a9900ba87d52159071b06310d5873c092231a Reviewed-on: https://code.wireshark.org/review/19003 Reviewed-by: Jeff Morriss <jeff.morriss.ws at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=58746cb6d6a4ef7dafa28289bbab13c32e1ae6fe commit 58746cb6d6a4ef7dafa28289bbab13c32e1ae6fe Author: Роман ÐонÑенко <dpb at corrigendum.ru> Date: Thu Dec 1 01:44:52 2016 +0300 ssh: add DSA host key dissection Change-Id: Ib1e2b4e57832e94b94d34102c0079f820b18f350 Reviewed-on: https://code.wireshark.org/review/19000 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cbf89c8ed842a58c282872cf8c42adf9b8b2ffee commit cbf89c8ed842a58c282872cf8c42adf9b8b2ffee Author: Gerald Combs <gerald at wireshark.org> Date: Tue Sep 20 14:11:29 2016 -0700 Check preference titles and descriptions. When registering preferences, make sure our titles and descriptions are valid UTF-8. Make sure our titles are short and only contain printable characters. Fix problematic titles and descriptions. Change-Id: I20d3f93438f2b3c30266f934297feb79897f2ee5 Reviewed-on: https://code.wireshark.org/review/18998 Reviewed-by: Gerald Combs <gerald at wireshark.org> Petri-Dish: Gerald Combs <gerald at wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=9887cd7feb7c377a3d046b924fe86907479be413 commit 9887cd7feb7c377a3d046b924fe86907479be413 Author: Peter Wu <peter at lekensteyn.nl> Date: Mon Nov 28 15:53:59 2016 +0100 Qt: fix crash when closing RTP player while playing For some time, the RTP Player has been crashing for me (Arch Linux, Qt 5.7.0) when the RTP Player is active (affects also Wireshark 2.0.5). This call trace was observed: + RtpPlayerDialog::reject (closing dialog via Escape / Close button) + RtpAudioStream::stopPlaying + RtpAudioStream::outputStateChanged(QAudio::StoppedState) + QAudioOutput::deleteLater // problematic! + RtpPlayerDialog::~RtpPlayerDialog + RtpAudioStream::~RtpAudioStream As the QAudioOutput instance is a child of RtpAudioStream, it is also destroyed after that. QAudioOutput's destructor somehow invokes (via libqtmedia_pulse.so) a main loop iteration which invokes the previously scheduled deleteLater call. As QAudioOutput was already being destructed, this results in a crash. Workaround this by removing this child from RtpAudioStream (no cruelty intended). Change-Id: I88f2e929ac566534be5d2270e2e0b194685533eb Reviewed-on: https://code.wireshark.org/review/18970 Petri-Dish: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Gerald Combs <gerald at wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=72427192723869535fb938425ddf8c5c4568ab5c commit 72427192723869535fb938425ddf8c5c4568ab5c Author: Gerald Combs <gerald at wireshark.org> Date: Tue Nov 29 09:32:47 2016 -0800 Qt: Fix simple_dialog formatting. Make sure that simple_dialog displays plain text. Trim whitespace and remove excessive newlines in order to improve message formatting. Add a comment about simple_dialog's behavior in Qt and GTK+ and how it might be improved. Bug: 13178 Change-Id: Ic6ff3cecd5ef1d76ec095d7a409f38e602b41ce2 Reviewed-on: https://code.wireshark.org/review/18985 Petri-Dish: Gerald Combs <gerald at wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> Reviewed-by: Gerald Combs <gerald at wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=ff0371e89802047a0b2ed31f127526b945d27069 commit ff0371e89802047a0b2ed31f127526b945d27069 Author: Peter Wu <peter at lekensteyn.nl> Date: Sat Nov 26 14:39:24 2016 +0100 ssl,dtls: add expert info for overly large record lengths All TLS and DTLS RFCs (and SSLv3) limit the record length to 2^14, so add expert info if this is exceeded. Spotted in the wild via https://ask.wireshark.org/questions/57641/tls12-record-length-gt-16k-valid Tested with a synthetic pcap having length 2^14+1 using Python: from scapy.all import IP, TCP, UDP, wrpcap len_plus_frag = b'\x40\x01' + 0x4001 * b'\0' wrpcap('bad-record-length.pcap', [ IP()/TCP(sport=2000, dport=443)/(b'\x17\x03\x03' + len_plus_frag), IP()/UDP(sport=2000, dport=853)/(b'\x17\xfe\xfd' + 8*b'\0' + len_plus_frag) ]) Change-Id: I5eac48775333d8d222e013a24a6d06da79892b77 Reviewed-on: https://code.wireshark.org/review/18959 Reviewed-by: Graham Bloice <graham.bloice at trihedral.com> Petri-Dish: Graham Bloice <graham.bloice at trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=1c9e061ea65fb630d18f5e9e4e4ecd3523dea651 commit 1c9e061ea65fb630d18f5e9e4e4ecd3523dea651 Author: Peter Wu <peter at lekensteyn.nl> Date: Wed Nov 30 12:24:18 2016 +0100 sip: register with Websocket dissector (RFC 7118) The subprotocol is also listed in the IANA registry at https://www.iana.org/assignments/websocket/websocket.xhtml#subprotocol-name Tested with the pcap from the linked bug. Bug: 11420 Change-Id: I4ba8e6c55889f72f5aca37c4ae759e2cd20a22b7 Reviewed-on: https://code.wireshark.org/review/18989 Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4ace7ce80dc11010f78202ab742f749f85cbdd6b commit 4ace7ce80dc11010f78202ab742f749f85cbdd6b Author: Роман ÐонÑенко <dpb at corrigendum.ru> Date: Wed Nov 30 02:11:06 2016 +0300 Fix the build when a different version of Qt is in PATH When we add our Qt to PATH, prepend it so that it will be found first. Change-Id: I405496d6a08d676b5a2e0d9bd792de7ba9abe7f9 Reviewed-on: https://code.wireshark.org/review/18988 Petri-Dish: Graham Bloice <graham.bloice at trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Graham Bloice <graham.bloice at trihedral.com> http://cgit.osmocom.org/wireshark/commit/?id=7fe45cc0ec4e8bc1c3d5cd27c98feb8ecbb2b1b4 commit 7fe45cc0ec4e8bc1c3d5cd27c98feb8ecbb2b1b4 Author: Peter Wu <peter at lekensteyn.nl> Date: Wed Nov 23 16:28:34 2016 +0100 Qt: fix GoToPacket when Voip Calls dialog is closed After opening the Call Flows dialog from the Voip Calls dialog, followed by closing the Voip Calls dialog, the Go To Packet functionality in the Call Flows dialog is broken. That happens because the signal is not proxied anymore. Just remove all these indirections via signals and directly update the selected packet. Change-Id: I9c6d519dbe800e4dfdf0407d832f17819b344e46 Reviewed-on: https://code.wireshark.org/review/18933 Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Gerald Combs <gerald at wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=f96ef34b19dd074fd013b06667e6c368fa31150c commit f96ef34b19dd074fd013b06667e6c368fa31150c Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Tue Nov 29 14:27:35 2016 +0100 3GPP NAS: shorten some value_string to avoid truncation during display Change-Id: I50f9bbec5405c17a59c5eaac9833929737b8c145 Reviewed-on: https://code.wireshark.org/review/18984 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0cb44e4277f3366234019c2f919ab1aea308822d commit 0cb44e4277f3366234019c2f919ab1aea308822d Author: Guy Harris <guy at alum.mit.edu> Date: Mon Nov 28 19:16:55 2016 -0800 Handle FT_CHAR, and report unsupported types as such. FT_CHAR is straightforward to support. Split the list of "invalid" types into a list of "unsupported" types and a short list of "invalid" types, containing FT_PCRE (which isn't a valid type for a field) and "everything else". Add FT_IEEE_11073_SFLOAT and FT_IEEE_11073_FLOAT to the "unsupported" list. Flag the whole unsupported list as just "not handled yet". Change-Id: I62d2d7eead53377e4e601594a035b4395fdbeead Reviewed-on: https://code.wireshark.org/review/18979 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=a222812787c83fb4f91e677c24ea40576864ac0a commit a222812787c83fb4f91e677c24ea40576864ac0a Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Mon Nov 28 16:34:46 2016 +0100 3GPP NAS: add an expert info when APN encoding exceeds 100 bytes As stated in 3GPP 23.003: "the APN has, after encoding as defined in the paragraph below, a maximum length of 100 octets" Change-Id: Iae23117f44ea5b668f6cb23dbd0e726e4e56ce41 Reviewed-on: https://code.wireshark.org/review/18972 Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=591e63366b4b04602fe40e7d016ce4d7dbe97010 commit 591e63366b4b04602fe40e7d016ce4d7dbe97010 Author: Stig Bjørlykke <stig at bjorlykke.org> Date: Sun Nov 27 20:54:45 2016 +0100 Qt: Position UAT hint label just below the list. Place the UAT hint label at the same position as in other dialogs; just below the main widget. Also use smaller font and italic. Change-Id: I51251825ff08122e17ca60144ef53fed5c6142ef Reviewed-on: https://code.wireshark.org/review/18969 Petri-Dish: Stig Bjørlykke <stig at bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=c4aba11ee32411bcd31d08c5ff9798c56e806271 commit c4aba11ee32411bcd31d08c5ff9798c56e806271 Author: Stig Bjørlykke <stig at bjorlykke.org> Date: Sun Nov 27 20:08:26 2016 +0100 Qt: Update UAT OK button enabled on delete. Check if the OK button should be enabled when removing a row in a UAT dialog. Also update the error hint. Change-Id: Icb5c47c2b2e65ed266fd2c7e3a1535f6a3a50279 Reviewed-on: https://code.wireshark.org/review/18967 Petri-Dish: Stig Bjørlykke <stig at bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=7c3aa5a88ca78bf029fd16aea2a9a1f4861227db commit 7c3aa5a88ca78bf029fd16aea2a9a1f4861227db Author: Gerald Combs <gerald at wireshark.org> Date: Sat Nov 26 18:31:19 2016 -0600 Qt: Fix conversation buttons. Move parts of currentTabChanged to conversationSelectionChanged. This lets us enable the "Follow Stream" and "Graph" buttons when either the current tab or the current selection changes. Bug: 12893 Change-Id: I025447d26073a938f2d8b5a8fcad7c0d5e855650 Reviewed-on: https://code.wireshark.org/review/18963 Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Petri-Dish: Gerald Combs <gerald at wireshark.org> Reviewed-by: Gerald Combs <gerald at wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=1239336af00215172c94d5d2af3926a72ea998c3 commit 1239336af00215172c94d5d2af3926a72ea998c3 Author: Peter Wu <peter at lekensteyn.nl> Date: Mon Nov 28 16:50:25 2016 +0100 Qt: fix heap-use-after-free when double-clicking a packet number On double-clicking a packet number, the current field item is invalidated by goToPacket. Skip the URL since a field can either have a URL or a frame number (but not both). Change-Id: I58e5445fa74071fa0fd203df77ebdecdd1478d31 Reviewed-on: https://code.wireshark.org/review/18971 Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=13adab211815b09e5fc2925eed4cbf07749913c1 commit 13adab211815b09e5fc2925eed4cbf07749913c1 Author: Matthieu Coudron <mattator at gmail.com> Date: Sat Nov 26 19:18:37 2016 +0100 Update message on outdated precommit hook Change-Id: I3afb93cced09df7844c0810438ee6d760f8237a5 Reviewed-on: https://code.wireshark.org/review/18960 Reviewed-by: Michael Mann <mmann78 at netscape.net> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=99aacf8612f6c528a86c5212d7bace9cbfadf1ad commit 99aacf8612f6c528a86c5212d7bace9cbfadf1ad Author: Gerald Combs <gerald at wireshark.org> Date: Sun Nov 27 08:14:07 2016 -0800 [Automatic update for 2016-11-27] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I3dae07ff98d80f02d1aaf7408e81faf6614d7058 Reviewed-on: https://code.wireshark.org/review/18964 Reviewed-by: Gerald Combs <gerald at wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=f975020121d613762c6ffa3fe5852869c29f574d commit f975020121d613762c6ffa3fe5852869c29f574d Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Sat Nov 26 14:00:11 2016 +0100 DOCSIS: fix an infinite recursion introduced in g3e1828e Bug: 13179 Change-Id: I4c510dab463f7c223bcaabd3157ca791dd86d690 Reviewed-on: https://code.wireshark.org/review/18958 Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Seth Alexander <pxsdaemon at gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d0fa82b825c15fbd9f3b6037f3d9ad4fc78d87fd commit d0fa82b825c15fbd9f3b6037f3d9ad4fc78d87fd Author: Gerald Combs <gerald at wireshark.org> Date: Fri Nov 25 11:42:26 2016 -0600 Qt: Clean up the byte view hover highlight. Rename the text highlight enum "HighlightMode" to make its use and intent more clear. Add a mode for the offset highlight instead of using a separate variable. Use our palette to draw the hover highlight colors. Add a note about colors to the Developer's Guide. Change-Id: I488b2512a5058e17eb5b49c8ac55616100f32fbc Reviewed-on: https://code.wireshark.org/review/18953 Petri-Dish: Gerald Combs <gerald at wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Gerald Combs <gerald at wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=ff4b272180b4f52432dadb9c93f43d01a001900f commit ff4b272180b4f52432dadb9c93f43d01a001900f Author: Michael Mann <mmann78 at netscape.net> Date: Fri Nov 25 17:02:20 2016 -0500 GlusterFS: Insert missing FORGET command. Apparently, it was forgotten ;) Bug: 12614 Change-Id: Id1a2d98e3ea2b381c5fa60faeb342256d4c7d9f8 Reviewed-on: https://code.wireshark.org/review/18955 Reviewed-by: Michael Mann <mmann78 at netscape.net> Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9022877411a539d0561c0d71be3ca63095819d13 commit 9022877411a539d0561c0d71be3ca63095819d13 Author: Guy Harris <guy at alum.mit.edu> Date: Fri Nov 25 18:50:49 2016 -0800 We only need the tvbuff length for EAP messages. Change-Id: I22a5990e12a151c209288b9e879ae1f88c866904 Reviewed-on: https://code.wireshark.org/review/18956 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c551e06e797577abb688060babf660489b65e800 commit c551e06e797577abb688060babf660489b65e800 Author: Birol Capa <birol.capa at siemens.com> Date: Fri Nov 25 11:26:40 2016 +0300 PROFINET: Update LineDelay Dissection When LineDelay is decoded, the FormatIndicator is not evaluted. Sample LineDelay: 2147483658 (0x80 00 00 0a) This value should be 10, since FormatIndicator (Bit 31) = 0x01 states that this is a CableDelay. Change-Id: I08ae8e6de8b6f8c493122109e29e91dc47096734 Reviewed-on: https://code.wireshark.org/review/18950 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ce90d98ee007b205efec802046f7299c4eb56e67 commit ce90d98ee007b205efec802046f7299c4eb56e67 Author: Michael Mann <mmann78 at netscape.net> Date: Sun Nov 20 22:46:10 2016 -0500 packet-dcm.c: Cleanup memory usage with strings wmem_file_scope() was used too many times when wmem_packet_scope() will do. Also, use the wmem string functions to only allocate enough space to handle a string instead of using MAX_BUF_LEN. Change-Id: I3031d3aef34b7105264b17dc83e3b1f4cfb4b3d4 Reviewed-on: https://code.wireshark.org/review/18910 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=dd5697b02e0575d2da0b6c041b4cda06101fc261 commit dd5697b02e0575d2da0b6c041b4cda06101fc261 Author: Jan Spevak <jan.spevak at nokia.com> Date: Wed Nov 23 10:04:39 2016 +0100 diameter: add values for AVP 2037 Change-Id: I7bddb48d1c6c88f9a6edfce2dd527603878c5ac4 Reviewed-on: https://code.wireshark.org/review/18931 Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ebf4c91d8377e34ccf9207e7410c8041bef57fb2 commit ebf4c91d8377e34ccf9207e7410c8041bef57fb2 Author: Dario Lombardo <lomato at gmail.com> Date: Fri Oct 21 17:22:40 2016 +0200 Add .gitlab-ci.yml. As for .travis.yml, this file triggers the CI module of GITLAB. On the public instance of gitlab (gitlab.com) the runners are active by default, then any mirror of wireshark on gitlab.com will result in an automated build. The current version of .gitlab-ci.yml builds with gcc 4,5,6 and with default config, without extcap and without pcap. Change-Id: I0800045e7f1b4a137dbd69a185d3b09a89398948 Reviewed-on: https://code.wireshark.org/review/18936 Reviewed-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b87a2be0810f6758f4782aaf6424da23d030f902 commit b87a2be0810f6758f4782aaf6424da23d030f902 Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Mon Nov 21 14:33:00 2016 +0100 ieee80211: Add Meru (Fortinet) Vendor Specific TLV Change-Id: Iaa554ac94d248c67c635ac180ea2d1c1e3775b6a Reviewed-on: https://code.wireshark.org/review/18915 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2e8bbe410e652d9038aa3be839602941f313ee25 commit 2e8bbe410e652d9038aa3be839602941f313ee25 Author: Petr Sumbera <petr.sumbera at oracle.com> Date: Tue Nov 22 06:09:24 2016 -0800 Fix git description for out-of-tree builds from a tarball version.conf is to be found in the source dir after unpacking. Bug: 13163 Change-Id: Ib8308e341b771d991ab48b48553f8d92b0b0621c Reviewed-on: https://code.wireshark.org/review/18923 Reviewed-by: João Valverde <j at v6e.pt> Petri-Dish: João Valverde <j at v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=cc09fbd2142607a43c2677f51e93095d0a7cb966 commit cc09fbd2142607a43c2677f51e93095d0a7cb966 Author: Guy Harris <guy at alum.mit.edu> Date: Thu Nov 24 19:32:54 2016 -0800 Mark another dictionary as commented out due to no RFC 6929 support. Change-Id: I0b119fdc786970842d39b92b504e361d80a5624c Reviewed-on: https://code.wireshark.org/review/18948 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=26b3b78b86b82213db0ea6edf8db9993eb0675d0 commit 26b3b78b86b82213db0ea6edf8db9993eb0675d0 Author: Guy Harris <guy at alum.mit.edu> Date: Thu Nov 24 17:44:34 2016 -0800 Get rid of "cast throws away constness" warnings. Change-Id: I62cf58798341a5301a787c321f65ecc2a3cec171 Reviewed-on: https://code.wireshark.org/review/18947 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=174db53cf49ee9b692d70959e024f10447c2c54f commit 174db53cf49ee9b692d70959e024f10447c2c54f Author: Guy Harris <guy at alum.mit.edu> Date: Thu Nov 24 17:41:04 2016 -0800 Update comments. Change-Id: I72a90fe4af08de3585d3df92a28ff3dbd693b260 Reviewed-on: https://code.wireshark.org/review/18946 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=513fa607d3ebeed555d49661d6cf8af561e66e42 commit 513fa607d3ebeed555d49661d6cf8af561e66e42 Author: Guy Harris <guy at alum.mit.edu> Date: Thu Nov 24 14:32:43 2016 -0800 Squelch warnings. There's some problem with our RADIUS dictionary reader that causes it to produce radius: Vendor: 'integer', does not exist in .../dictionary.rfc7930 warnings when reading entries such as ATTRIBUTE Response-Length 241.3 integer Change-Id: I90548281ce4e5ffce974b9fe074266adbfdf2a5c Reviewed-on: https://code.wireshark.org/review/18945 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ab55444590e006b24dbd372fa7dc307ddd7076ec commit ab55444590e006b24dbd372fa7dc307ddd7076ec Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Mon Nov 21 12:06:43 2016 +0100 RADIUS: Add RFC7930 dictionnary From FreeRADIUS master commit 42e55cca4cee6524475f0461b00f0f96769ab40b Author: Alan T. DeKok <aland at freeradius.org> Date: Wed Oct 12 10:13:00 2016 -0400 added RFC 7930 Change-Id: Icb69117cad84fcaf9d9ffe8040962afb33709441 Reviewed-on: https://code.wireshark.org/review/18913 Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=75bf4637073fb50918ce9be2bc6b799b6a0801c1 commit 75bf4637073fb50918ce9be2bc6b799b6a0801c1 Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Mon Nov 21 12:13:04 2016 +0100 RADIUS: Add Microsemi dictionnary commit 503e1e78daaa51d9a47e85bd7c9f5fb096a25b87 Author: Alan T. DeKok <aland at freeradius.org> Date: Fri Nov 11 06:56:23 2016 -0500 from Microsemi Change-Id: Icc5e5f74f7d34aaebdb192c83908856189082cf0 Reviewed-on: https://code.wireshark.org/review/18914 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=f39ce7de420ba38a8c90075099bac2132c47fa9f commit f39ce7de420ba38a8c90075099bac2132c47fa9f Author: Günther Deschner <gd at samba.org> Date: Wed Sep 21 16:50:21 2016 +0200 dissectors: add PRINTER_INFO_5 decoding for DCE/RPC spoolss dissector. Guenther Change-Id: I9eb8be636ebdf81092b7abd8d4749410cc5dcc06 Signed-off-by: Guenther Deschner <gd at samba.org> Reviewed-on: https://code.wireshark.org/review/18932 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8eb6b3ee1476c23f2b7794716e09eb26779ad9d8 commit 8eb6b3ee1476c23f2b7794716e09eb26779ad9d8 Author: Seth Alexander <seth.alexander at cosmicaes.com> Date: Wed Nov 23 15:09:18 2016 -0700 Removed Manipulation of Visited Flag Change-Id: Ic77afa3fd0b9cabb3f2681be099e11be79d271be Reviewed-on: https://code.wireshark.org/review/18938 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=19b6062ffde208c3609581f306fc05594bfccfb7 commit 19b6062ffde208c3609581f306fc05594bfccfb7 Author: Guy Harris <guy at alum.mit.edu> Date: Wed Nov 23 18:25:53 2016 -0800 Note that we can't use a child setup routine in g_spawn routines. They don't work on Windows, and we support Windows, so.... Change-Id: Icdbdfcfd930ae13aba6d8fb018d7e2af55b76fa1 Reviewed-on: https://code.wireshark.org/review/18943 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=7dbe9b49879e06e1d86c11140e2bfdacbabde74b commit 7dbe9b49879e06e1d86c11140e2bfdacbabde74b Author: Martin Mathieson <martin.r.mathieson at googlemail.com> Date: Wed Nov 23 16:31:57 2016 -0800 Return from snort_start early if dissector not enabled. Change-Id: Idf63210ce33d92ac8619fe3295bd3e6c0bb304a9 Reviewed-on: https://code.wireshark.org/review/18941 Reviewed-by: Martin Mathieson <martin.r.mathieson at googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=76c39702656a34d9343719013457a321add5018a commit 76c39702656a34d9343719013457a321add5018a Author: Martin Mathieson <martin.r.mathieson at googlemail.com> Date: Wed Nov 23 15:53:28 2016 -0800 Add missing header file for distcheck Change-Id: I230c8886585f30fae101ac40a1cd5018a2a62e8b Reviewed-on: https://code.wireshark.org/review/18940 Reviewed-by: Martin Mathieson <martin.r.mathieson at googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=28fb531cdd96ea1bbd48c6907a60f444ec2415a2 commit 28fb531cdd96ea1bbd48c6907a60f444ec2415a2 Author: Martin Mathieson <martin.r.mathieson at googlemail.com> Date: Wed Nov 16 12:33:09 2016 -0800 Initial commit of Snort post-dissector. This dissector allows Snort to process all of the packets passed to Wireshark, and for the alerts to be shown in the protocol tree. It is also possible to set the source of alerts to be packet comments. Change-Id: I6e0a50d3418001cbac2d185639adda2553a40de8 Reviewed-on: https://code.wireshark.org/review/18848 Petri-Dish: Martin Mathieson <martin.r.mathieson at googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson at googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=24f7b93dc12577b5d9d72ff4f3fe786b65c517a1 commit 24f7b93dc12577b5d9d72ff4f3fe786b65c517a1 Author: Dario Lombardo <lomato at gmail.com> Date: Mon Nov 21 23:52:04 2016 +0100 debian-setup: check for both libgnutls-dev and libgnutls28-dev. Change-Id: Ibe63e1d9b7527295223fc817889a60db79869e27 Reviewed-on: https://code.wireshark.org/review/18935 Reviewed-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a85d1361024e9e93f3f73575d7adaef23c2a19a8 commit a85d1361024e9e93f3f73575d7adaef23c2a19a8 Author: Dario Lombardo <lomato at gmail.com> Date: Mon Nov 21 22:51:26 2016 +0100 debian-setup: remove lsb_relese check. It is not used anymore and breaks docker builds. Change-Id: Ic4a2e6abf2da8059f28fcee19e611a8a83165895 Reviewed-on: https://code.wireshark.org/review/18934 Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=6930ded24ab64b6de646ae3e120995b44188bc84 commit 6930ded24ab64b6de646ae3e120995b44188bc84 Author: Guy Harris <guy at alum.mit.edu> Date: Tue Nov 22 11:19:37 2016 -0800 Include <io.h> and <fcntl.h> for _setmode(). Change-Id: I1910275653ef4a985e9894f01cf5cb5fa33070d4 Reviewed-on: https://code.wireshark.org/review/18928 Petri-Dish: Guy Harris <guy at alum.mit.edu> Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=f4d6c7abbc32c5eee10e4f771f5e7fc1cc2639ef commit f4d6c7abbc32c5eee10e4f771f5e7fc1cc2639ef Author: Guy Harris <guy at alum.mit.edu> Date: Tue Nov 22 10:01:29 2016 -0800 On Windows, put the standard output in binary mode if we're writing the capture file to it. While we're at it, explicitly compare the restult of strcmp() against 0, to make it clearer that it's testing for the argument *not* being equal to "-". Bug: 13165 Change-Id: Ic63085abb2de5f5c60d2101d19c1a269b7e0c9d7 Reviewed-on: https://code.wireshark.org/review/18924 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=fb9a356e46c5adbc74e9d117463c0fb2b4778afe commit fb9a356e46c5adbc74e9d117463c0fb2b4778afe Author: Michael Mann <mmann78 at netscape.net> Date: Thu Nov 17 21:45:28 2016 -0500 Add prefs_get_uint_value and prefs_get_range_value This allows dissectors to not need to know about the internal preference structure. Change-Id: I1ae67248cd0b0132aefc225ea0a9befaf9afdde2 Reviewed-on: https://code.wireshark.org/review/18864 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ba67963fd4ef287124cd9bf8f35a22d8a5663a11 commit ba67963fd4ef287124cd9bf8f35a22d8a5663a11 Author: Jaap Keuter <jaap.keuter at xs4all.nl> Date: Sat Nov 19 18:13:47 2016 +0100 Improve name resolution preference tooltips. Change the tooltips texts to make them better describe the preference. Bug: 13130 Bug: 13131 Change-Id: Ie753e3703a702bdafed91cf0f41b306347088526 Reviewed-on: https://code.wireshark.org/review/18878 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=03a2539b227ee2adc547b6c755cc1d17235a09b9 commit 03a2539b227ee2adc547b6c755cc1d17235a09b9 Author: Dmitry Lazurkin <dmitry.lazurkin at synesis.ru> Date: Sun Nov 20 16:39:31 2016 +0300 extract common logic of proto_item_set_len/proto_item_set_end Change-Id: I55f9303624471d09b446c10939e5c22bf8e21511 Reviewed-on: https://code.wireshark.org/review/18894 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=0f36cf62b705a25c8b932d9bd2725f4d83248f2e commit 0f36cf62b705a25c8b932d9bd2725f4d83248f2e Author: Yasuyuki Tanaka <yatch at isl.rdc.toshiba.co.jp> Date: Mon Nov 14 23:47:51 2016 +0100 ieee802154: support 6top protocol (6P) draft-03 - support draft-ietf-6tisch-6top-protocol-03 - rename variables and constants to reflect the protocol hierarchy - show 6P specific information in the "Protocol" and "Info" column - cleanup Bug: 13136 Change-Id: I83ca8a55d59225e0cce64f3463100b3750a58b8f Reviewed-on: https://code.wireshark.org/review/18824 Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3e1828e35188e1987554b50ed2451de90398b5af commit 3e1828e35188e1987554b50ed2451de90398b5af Author: Seth Alexander <seth.alexander at cosmicaes.com> Date: Tue Nov 1 09:42:46 2016 -0700 Added Path Value and CRC to DOCSIS Plugin DOCSIS update with basic defragmentation Bug: 13106 Change-Id: Idbb42c80b87c0c3189da087b523733cf0b19967c Reviewed-on: https://code.wireshark.org/review/18676 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=fe38577409e1cf5c1eb9c45f27bfa51e607fa270 commit fe38577409e1cf5c1eb9c45f27bfa51e607fa270 Author: Franklin "Snaipe" Mathieu <snaipe at diacritic.io> Date: Mon Nov 21 19:20:41 2016 +0100 lua: Allow FT_ETHER protofields to be inserted in TreeItems. Change-Id: If1daef88dce166ec92f00a8c6e71bcb220d25e0c Signed-off-by: Franklin "Snaipe" Mathieu <snaipe at diacritic.io> Reviewed-on: https://code.wireshark.org/review/18917 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=76911025a38ae9092f61f2ed0c501d1ce14ce074 commit 76911025a38ae9092f61f2ed0c501d1ce14ce074 Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Tue Nov 22 08:10:53 2016 +0100 PW-ATM: fix code will never be executed [-Wunreachable-code] Change-Id: If838db823dd1c7614fcfdfc2774952bf70da3c6e Reviewed-on: https://code.wireshark.org/review/18919 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5c5409735d49850692fff9958f95a927eac88845 commit 5c5409735d49850692fff9958f95a927eac88845 Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Mon Nov 21 10:09:50 2016 +0100 ieee80211: Add 20/40 BSS Coexistence IE Parameters (72) Bug: 13148 Change-Id: I60bb679b8b8221f5229146ca1120d00ce9e2ec66 Reviewed-on: https://code.wireshark.org/review/18911 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> http://cgit.osmocom.org/wireshark/commit/?id=7617286f32135051800998cb3a4b07badc8c6719 commit 7617286f32135051800998cb3a4b07badc8c6719 Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Tue Nov 22 07:16:17 2016 +0100 RLC: always initialize LI length, even when it is malformed Bug: 13162 Change-Id: Ie0938611b4c90fd54e7ccda0ee5f3d791078be06 Reviewed-on: https://code.wireshark.org/review/18918 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4a3a6b1bbb30a0bf0d154e2f1abaf771e880be68 commit 4a3a6b1bbb30a0bf0d154e2f1abaf771e880be68 Author: Dario Lombardo <lomato at gmail.com> Date: Sun Nov 20 22:13:52 2016 +0100 bgp: remove dead code (CID 1158699). Change-Id: Ib7f766819bb81858fa0c3a0b49fe39de7123bf6d Reviewed-on: https://code.wireshark.org/review/18908 Petri-Dish: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=bb4ecec2d027c75524374fe28ceb26cc869471fa commit bb4ecec2d027c75524374fe28ceb26cc869471fa Author: Martin Mathieson <martin.r.mathieson at googlemail.com> Date: Sun Nov 20 01:43:02 2016 -0800 Kafka: show API versions in root, and don't show bogus size for GZIP messages. Change-Id: Ib8182537a791ed24bcc417594713dd6c206ce0ce Reviewed-on: https://code.wireshark.org/review/18885 Reviewed-by: Dmitry Lazurkin <dilaz03 at gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson at googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=975461af4b7dc5a5da02d14f73eee63426ed416d commit 975461af4b7dc5a5da02d14f73eee63426ed416d Author: Michael Mann <mmann78 at netscape.net> Date: Sun Nov 20 17:38:14 2016 -0500 packet-dcm.c: Assorted cleanup 1. Use tvb_get_guintXX with encoding parameter rather than have an "is_little_endian" flag 2. Replace proto_tree_add_xxx_format with proto_tree_add_xxx_format_value or proto_tree_add_item 3. Create some value_strings in favor of functions. Change-Id: If4b8e8992662bda768b39ba5f1932272760eef65 Reviewed-on: https://code.wireshark.org/review/18909 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=79c2bdcea94eac9a70068f09fddb67e4367f3c25 commit 79c2bdcea94eac9a70068f09fddb67e4367f3c25 Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Mon Nov 21 10:41:08 2016 +0100 NAS EPS: fill info column when receiving a ciphered message Change-Id: I2aaad1e7682025f38d78198c7fef7c759629d762 Reviewed-on: https://code.wireshark.org/review/18912 Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c3706a9226dc38f76107da349734a0f928c90c1a commit c3706a9226dc38f76107da349734a0f928c90c1a Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Sun Nov 20 12:39:39 2016 +0100 bthci_evt: Fix conflict for hf fields 'bthci_evt.pending_response_delta' exists multiple times with NOT compatible types: FT_BOOLEAN and FT_DOUBLE Change-Id: I7665ea0c007ef089c6986c102f2358d08d4628df Reviewed-on: https://code.wireshark.org/review/18889 Petri-Dish: Michal Labedzki <michal.labedzki at tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> Reviewed-by: Michal Labedzki <michal.labedzki at tieto.com> http://cgit.osmocom.org/wireshark/commit/?id=3bf6a189994475a5a1a82bb518e7fdd047cc7777 commit 3bf6a189994475a5a1a82bb518e7fdd047cc7777 Author: Etienne Dechamps <etienne at edechamps.fr> Date: Sun Nov 20 18:37:19 2016 +0000 Fix -1 lengths in proto_tree_add_item_ret_string_and_length(). Currently, when passing a -1 length to proto_tree_add_item_ret_string_and_length() or proto_tree_add_item_ret_string(), the -1 length will be passed directly to the field info. The calculated length should be used instead. Bug: 13159 Change-Id: I980d18fb9bde3c452e64a8735e62d4830ce53b64 Reviewed-on: https://code.wireshark.org/review/18904 Reviewed-by: Michael Mann <mmann78 at netscape.net> Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=035e404fff4ce11348fc0e019a368ddd080a1266 commit 035e404fff4ce11348fc0e019a368ddd080a1266 Author: Dario Lombardo <lomato at gmail.com> Date: Sun Nov 20 20:34:09 2016 +0100 cmake: add creation of version.conf to be shipped in tarball. Change-Id: I2bb66844b29cd4805d201891ffba342d26ee475f Reviewed-on: https://code.wireshark.org/review/18731 Reviewed-by: Peter Wu <peter at lekensteyn.nl> Tested-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=48c423a7244e10894991a964d5a4eca0e465ef84 commit 48c423a7244e10894991a964d5a4eca0e465ef84 Author: Nick Lowe <nick.lowe at gmail.com> Date: Sun Nov 20 15:20:48 2016 +0000 QBSS Load IE: Correct 'Available Admission Capabilities' to 'Available Admission Capacity' Change-Id: Ic4e6fe7978382854b4f36eebc8372eb3cd8e7551 Signed-off-by: Nick Lowe <nick.lowe at gmail.com> Reviewed-on: https://code.wireshark.org/review/18895 Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=1f512906db7dd98f6c47b85d081d4dd7b2877e5e commit 1f512906db7dd98f6c47b85d081d4dd7b2877e5e Author: Guy Harris <guy at alum.mit.edu> Date: Sun Nov 20 10:45:03 2016 -0800 Make something to which we assign a string pointer const. Change-Id: I4b292f252f0e4290fc8adc1e76aa589108fc597e Reviewed-on: https://code.wireshark.org/review/18905 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=a95667b388f75a40f7a63fb9b80e7ed896a836d9 commit a95667b388f75a40f7a63fb9b80e7ed896a836d9 Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Sun Nov 20 17:36:02 2016 +0100 PDCP LTE: add NB-IoT channels Change-Id: I3dfb54bc4614ea033ba89ab1fc8be83ad5025473 Reviewed-on: https://code.wireshark.org/review/18900 Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=22f6ab034d75b0bb03cb8f388533b77e024878f1 commit 22f6ab034d75b0bb03cb8f388533b77e024878f1 Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Sun Nov 20 17:21:06 2016 +0100 PDCP LTE: cache LTE RRC dissectors handles Change-Id: I35ac69aaf5ce6c3fe14c5af2182e4e53f2aded9b Reviewed-on: https://code.wireshark.org/review/18899 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=390674f309eb84215281b1b97254fc4936554a18 commit 390674f309eb84215281b1b97254fc4936554a18 Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Sun Nov 20 10:37:41 2016 +0100 uds: Fix conflict for hf fields 'uds.tp.suppress_reply' exists multiple times with NOT compatible types: FT_BOOLEAN and FT_UINT8 Change-Id: I8f6035c79c7b6481dd2915cfcfc99963fef7fc23 Reviewed-on: https://code.wireshark.org/review/18884 Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=95325a2e399d86b67a04f13dccbcdfdabe192087 commit 95325a2e399d86b67a04f13dccbcdfdabe192087 Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Sun Nov 20 12:23:42 2016 +0100 hsms: Fix conflict for hf fields 'hsms.data.item.value' exists multiple times with NOT compatible types: FT_BOOLEAN and FT_BYTES 'hsms.data.item.value' exists multiple times with NOT compatible types: FT_STRING and FT_BOOLEAN 'hsms.data.item.value' exists multiple times with NOT compatible types: FT_INT64 and FT_STRING 'hsms.data.item.value' exists multiple times with NOT compatible types: FT_INT8 and FT_INT64 'hsms.data.item.value' exists multiple times with NOT compatible types: FT_DOUBLE and FT_INT32 'hsms.data.item.value' exists multiple times with NOT compatible types: FT_UINT64 and FT_FLOAT 'hsms.data.item.value' exists multiple times with NOT compatible types: FT_UINT8 and FT_UINT64 Change-Id: I83697e72ebfa4e164178141d789c4ca2d9d09db0 Reviewed-on: https://code.wireshark.org/review/18887 Petri-Dish: Michael Mann <mmann78 at netscape.net> Reviewed-by: Benjamin Parzella <bparzella at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=01d1abcec075cab84454a7a42a8bd561ce3ae5d3 commit 01d1abcec075cab84454a7a42a8bd561ce3ae5d3 Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Sun Nov 20 10:18:56 2016 +0100 uftp4: fix last argument of proto_tree_add_item It can be not FALSE Change-Id: I938011296b40013a1dad813c3196e899b1b90347 Reviewed-on: https://code.wireshark.org/review/18883 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=cbbaf1d9343d0e063e9b46ca3c69706e9ee32075 commit cbbaf1d9343d0e063e9b46ca3c69706e9ee32075 Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Sun Nov 20 10:13:18 2016 +0100 uftp4: Fix conflict for hf fields 'uftp4.announce.publicmcast' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 'uftp4.announce.privatemcast' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 'uftp4.fileinfo.tstamp' exists multiple times with NOT compatible types: FT_ABSOLUTE_TIME and FT_UINT32 Change-Id: I94b235e9ba8ebe8a036620f9537eb674f418f1e5 Reviewed-on: https://code.wireshark.org/review/18882 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=88f65ca0756ea1252e180dd69aa0c690c3f8c9f3 commit 88f65ca0756ea1252e180dd69aa0c690c3f8c9f3 Author: Gerald Combs <gerald at wireshark.org> Date: Sun Nov 20 08:12:08 2016 -0800 [Automatic update for 2016-11-20] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I037cbaa9226ddf6630ae95865da7f67920592295 Reviewed-on: https://code.wireshark.org/review/18896 Reviewed-by: Gerald Combs <gerald at wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=08e5d9ad7d82f6349aee3d13ad6d11e0a1f42d5e commit 08e5d9ad7d82f6349aee3d13ad6d11e0a1f42d5e Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Sun Nov 20 12:20:12 2016 +0100 radiotap: Fix conflict for hf fields 'radiotap.present.flags' exists multiple times with NOT compatible types: FT_BOOLEAN and FT_UINT32 Change-Id: Ib53eb43c2103b24bd02bd41fd20030b7e7ae321b Reviewed-on: https://code.wireshark.org/review/18886 Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ded081ccecfbba91cacabba70d69a7eb36a5288d commit ded081ccecfbba91cacabba70d69a7eb36a5288d Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Sun Nov 20 10:06:18 2016 +0100 VXLAN: Fix conflict for hf fields 'vxlan.flags_reserved' exists multiple times with NOT compatible types: FT_UINT8 and FT_BOOLEAN Change-Id: I98d296393796defc5741c41a496432eb8f927be2 Reviewed-on: https://code.wireshark.org/review/18881 Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=c63609b360cf8fa3a9f86d4dcdaaada2d2be87f8 commit c63609b360cf8fa3a9f86d4dcdaaada2d2be87f8 Author: Uli Heilmeier <uh at heilmeier.eu> Date: Tue Nov 15 00:14:51 2016 +0100 DICOM: Fix handling of AT tag elements A Attribute Identifier List can have more than one AT element. Therefore we have to loop through the elements list. Bug: 13077 Change-Id: I3adaa5ba50a1ad01e7c5bacd05118c65afcf4442 Reviewed-on: https://code.wireshark.org/review/18825 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=7ecbad89a91a2e978da97489484bbbbced55dd15 commit 7ecbad89a91a2e978da97489484bbbbced55dd15 Author: Martin Mathieson <martin.r.mathieson at googlemail.com> Date: Sun Nov 20 03:37:03 2016 -0800 kafka: fix mac build breakage by adding int cast Change-Id: Ic57d49f7408f041b60b719a3da4971c499122930 Reviewed-on: https://code.wireshark.org/review/18888 Petri-Dish: Martin Mathieson <martin.r.mathieson at googlemail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson at googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=548bf927d427723ad22e8e23186a63a63e4abf43 commit 548bf927d427723ad22e8e23186a63a63e4abf43 Author: Guy Harris <guy at alum.mit.edu> Date: Sat Nov 19 21:59:28 2016 -0800 proto_item_set_end() should set the FT_BYTES value length as well. Change-Id: I33459aabf059e1dc746e7e5f9d5ca28095e056f4 Reviewed-on: https://code.wireshark.org/review/18880 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=6bd322223d3f13612a449cbba20ce36e9da30ebb commit 6bd322223d3f13612a449cbba20ce36e9da30ebb Author: Alex Badea <abadea at ixiacom.com> Date: Thu Nov 17 16:46:16 2016 +0200 tcp: fix "calculated checksum" tree item for bad checksums The Calculated Checksum tree item prints the checksum from the tvb, instead of the computed one (the "should be 0x...." tree item above it _does_ print the computed one). As such, in a packet with bad checksum, the Calculated Checksum is incorrect. Fix the value. This seems to have been introduced in ad6fc87d ("Add proto_tree_add_checksum.") Change-Id: Ia20d5addc40956713a944102e79d25317b969a0e Reviewed-on: https://code.wireshark.org/review/18859 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=abf802baf77bca3c0b4f94e81e8308b4c2d527fb commit abf802baf77bca3c0b4f94e81e8308b4c2d527fb Author: John A. Thacker <johnthacker at gmail.com> Date: Fri Nov 18 18:35:28 2016 -0500 Reassemble: fix premature free Fix a memory error found by the buildbot and valgrind in my recent patch Bug: 13100 Change-Id: Ieb21aa25e048f90ce7192546b0ad3d4718ff07df Reviewed-on: https://code.wireshark.org/review/18877 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=4eb61deedc79c8c446e6a162a1dc8ebea6e7353f commit 4eb61deedc79c8c446e6a162a1dc8ebea6e7353f Author: Dmitry Lazurkin <dilaz03 at gmail.com> Date: Fri Nov 18 00:19:18 2016 +0300 kafka: Update supported api keys to latest spec Details: - update supported api keys - add api key ApiVersions - change api key names according to documentation - add pcapng files for supported api keys - add new documentation link - add declaration of lz4 message codec Change-Id: I943dc31144890dcd3dd333981a86754668c2bec4 Reviewed-on: https://code.wireshark.org/review/18861 Reviewed-by: Martin Mathieson <martin.r.mathieson at googlemail.com> http://cgit.osmocom.org/wireshark/commit/?id=231ad4f6ff1dc675947739a107bd639a67b7cd35 commit 231ad4f6ff1dc675947739a107bd639a67b7cd35 Author: Dario Lombardo <lomato at gmail.com> Date: Thu Nov 10 10:35:56 2016 +0100 cpack: improve source tarball generation by adding the "dist" target. The source package must not contain compiled objects. If the build dir is under the source tree, it is included too. By excluding /build/ we avoid to add every build dir, but if the build dir doesn't contain build the problem still persist. Change-Id: I75021565c058c1a93945f43b9b49cb3d04c960d4 Reviewed-on: https://code.wireshark.org/review/18729 Reviewed-by: Peter Wu <peter at lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6926cf0294032e88f267b98000211037882326f9 commit 6926cf0294032e88f267b98000211037882326f9 Author: Jaap Keuter <jaap.keuter at xs4all.nl> Date: Fri Nov 18 10:42:26 2016 +0100 LBM_UIMflow: Fix range_ratio calculation (CID-1355421) Port the same calculation from sequence_dialog.cpp. Resolves the Coverity issue and aligns the output just a bit better. Change-Id: Iaa464149630e0fafb5bdff20019440c3fb67bbbd Reviewed-on: https://code.wireshark.org/review/18868 Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter at xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=c27404655650a3648f576663d07394105fd5ef30 commit c27404655650a3648f576663d07394105fd5ef30 Author: Peter Wu <peter at lekensteyn.nl> Date: Tue Nov 8 15:20:30 2016 +0100 cmake: install icons and .desktop files Based on the install-data-local target from Makefile.am. Change-Id: Ia2ff6b90475a30ed219019fd80afd1a498e3133c Reviewed-on: https://code.wireshark.org/review/18708 Reviewed-by: Peter Wu <peter at lekensteyn.nl> Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Balint Reczey <balint at balintreczey.hu> Tested-by: Balint Reczey <balint at balintreczey.hu> http://cgit.osmocom.org/wireshark/commit/?id=a12399018c6c0e0721c54c8982aacc53e8b823eb commit a12399018c6c0e0721c54c8982aacc53e8b823eb Author: Guy Harris <guy at alum.mit.edu> Date: Fri Nov 18 10:51:12 2016 -0800 Create /etc/paths.d and /etc/manpaths.d if they don't exist. Bug: 13152 Change-Id: I6ecfd1e3f7f10a3a63b44b0d8bf137f0b3450391 Reviewed-on: https://code.wireshark.org/review/18871 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=58c4a4e018a3e1086ccbea773a05fa3f005a1a14 commit 58c4a4e018a3e1086ccbea773a05fa3f005a1a14 Author: Peter Wu <peter at lekensteyn.nl> Date: Tue Nov 15 21:13:45 2016 +0100 cmake/FindPCAP: fix use of bad cached function checks When libpcap-dev is not installed, do not look for functions like pcap_datalink_name_to_val since the negative result would be cached. Then after installing libpcap-dev, the build would fail due to redeclaration of functions. Change-Id: Ifdbad09e9cf160383b16b6459693f7ea5d65b9c3 Reviewed-on: https://code.wireshark.org/review/18834 Petri-Dish: Peter Wu <peter at lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=bba62e296bc500f2fca48aaeb0c440916ae470d9 commit bba62e296bc500f2fca48aaeb0c440916ae470d9 Author: AndersBroman <anders.broman at ericsson.com> Date: Fri Nov 18 13:47:06 2016 +0100 [GSM A RR] Fix dissection of c1_delta. Change-Id: I500b3e0abd4368511842ff795b91d1ebbbf46bbc Reviewed-on: https://code.wireshark.org/review/18869 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6a91e8aba70336284ad3dc09d46ecd9421799ab6 commit 6a91e8aba70336284ad3dc09d46ecd9421799ab6 Author: Dario Lombardo <lomato at gmail.com> Date: Thu Nov 17 11:33:02 2016 +0100 androiddump: check return value in useSndTimeout() (CID 1394378). Change-Id: I14109ffe1b9930c464ce2c42767f96b8ba4e5b67 Reviewed-on: https://code.wireshark.org/review/18855 Petri-Dish: Dario Lombardo <lomato at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki at tieto.com> http://cgit.osmocom.org/wireshark/commit/?id=a90d196ce8f8dee4beb22c508080dfef6efdf71b commit a90d196ce8f8dee4beb22c508080dfef6efdf71b Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Fri Nov 18 09:39:24 2016 +0100 GTP: fix dissection of GGSN Back-Off Time IE Bug: 13153 Change-Id: I2f404515187f9f29a45f101c8ff294a971ffddac Reviewed-on: https://code.wireshark.org/review/18865 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a3d3ebf16260a1ea831b421c3d59f592d9ae54f4 commit a3d3ebf16260a1ea831b421c3d59f592d9ae54f4 Author: Joakim Karlsson <oakimk at gmail.com> Date: Thu Nov 17 20:10:07 2016 +0100 gtpv2: correct order in bearer qos Change-Id: I4acc4d0546f90fcb574a77b5f8abe1b9f9e5bdc5 Reviewed-on: https://code.wireshark.org/review/18860 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=08e15a8f43200c76ee45bc20000d5b8d6679ae1f commit 08e15a8f43200c76ee45bc20000d5b8d6679ae1f Author: Guy Harris <guy at alum.mit.edu> Date: Thu Nov 17 18:35:11 2016 -0800 Don't assume we have a protocol tree. In the association_sanity_check_t structure: Have separate flags to indicate whether we *have* an IE specifying an FT AKM suite and whether we *have* an IE specifying a non-FT AKM suite. Use those to decide whether to add an expert info, so we add it regardless of whether we are building a protocol tree or not. Set the protocol tree item for the first FT AKM suite and the first non-FT AKM suite only if we have a protocol tree. Bug: 13149 Change-Id: I16a3194017b34d8d2c9128364c2761d1c202969d Reviewed-on: https://code.wireshark.org/review/18863 Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=50515b9ebf8db7e97369e0cdbc748db9d0fd818b commit 50515b9ebf8db7e97369e0cdbc748db9d0fd818b Author: Will Glynn <will at willglynn.com> Date: Thu Nov 17 15:48:18 2016 -0600 ieee80211: warn about FT AKM suite mismatches Bug: 13149 Change-Id: I8bceeeadf30c9594aa4be8cc195e694594de1d97 Reviewed-on: https://code.wireshark.org/review/18862 Petri-Dish: Guy Harris <guy at alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Guy Harris <guy at alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=de5580a8ff5f8558386c51c7d56f09970d553fe3 commit de5580a8ff5f8558386c51c7d56f09970d553fe3 Author: Uli Heilmeier <uh at heilmeier.eu> Date: Wed Nov 16 23:32:34 2016 +0100 BGP: Fix length in decode_prefix4() When decode_prefix4() gets called with more prefixes the length of proto_tree_add_subtree_format() should not be the total length. As the "Withdrawn route" part was the only one where decode_prefix4() has been called with a tlen not equal 0 we can eliminate the tlen parameter. Bug: 13146 Change-Id: I708dec2cecbed6054b60190104b82c72d54e8037 Reviewed-on: https://code.wireshark.org/review/18852 Reviewed-by: Michael Mann <mmann78 at netscape.net> Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9c514d8fc312aa1ff0485d1ce7b1e833ed629662 commit 9c514d8fc312aa1ff0485d1ce7b1e833ed629662 Author: Jaap Keuter <jaap.keuter at xs4all.nl> Date: Thu Nov 17 00:49:10 2016 +0100 TCP: Add MD5 signature option dissection Bug: 13147 Change-Id: Icfd1343458c0795c4e3a74e4ed4f06d18f1c1831 Reviewed-on: https://code.wireshark.org/review/18854 Reviewed-by: Michael Mann <mmann78 at netscape.net> Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3dee62ec923db5c1faea40dc6353660dc10ea829 commit 3dee62ec923db5c1faea40dc6353660dc10ea829 Author: Dario Lombardo <lomato at gmail.com> Date: Tue Nov 15 17:10:11 2016 +0100 debian-setup: remove libssh-dev from basic list. Change-Id: I34c0c24bc9240e27cbdf71f6ef1ae0adbb27cd7f Reviewed-on: https://code.wireshark.org/review/18830 Tested-by: Dario Lombardo <lomato at gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0b4b521377592de83e5b14051691f4fbb6b60aa1 commit 0b4b521377592de83e5b14051691f4fbb6b60aa1 Author: Deep Datta <deepdatta2010 at yahoo.co.in> Date: Mon Nov 14 15:43:05 2016 -0600 Adding new Ixia netflow fields for Source and Dest AS Names and Transaction Latency Change-Id: I48c0cb58cd5643ad1c930b668b81cc3cc7270afa Reviewed-on: https://code.wireshark.org/review/18837 Reviewed-by: Michael Mann <mmann78 at netscape.net> Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bf7db022c35f408199b4c4baed187d5fc19ac77c commit bf7db022c35f408199b4c4baed187d5fc19ac77c Author: Jaap Keuter <jaap.keuter at xs4all.nl> Date: Tue Nov 15 23:36:26 2016 +0100 Resolv: various code / comment cleanups Various cleanups and corrections regarding MAC address handling. Change-Id: I31e2e377bc1c73705a89517c776d51bbb19b9ce3 Reviewed-on: https://code.wireshark.org/review/18836 Reviewed-by: Michael Mann <mmann78 at netscape.net> Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2902edb325f66679c8949a24808b387c8fd97ecc commit 2902edb325f66679c8949a24808b387c8fd97ecc Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Wed Nov 9 19:58:34 2016 +0100 gsm_abis_pgsl: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I2ad9621c632060fba1010ab5fed0b62557580dff Reviewed-on: https://code.wireshark.org/review/18726 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=737dabb0437bd5a0a1f4c07189ca59f1c83afb55 commit 737dabb0437bd5a0a1f4c07189ca59f1c83afb55 Author: novakji <j.novak at netsystem.cz> Date: Sun Nov 13 20:20:17 2016 +0100 SDP: Payload type name for dynamic payload is wrong for reverse RTP channels Bug: 13132 Change-ID: I61a2575f9d8da958ae2fb01c71f3c71c9643ddea Reviewed-on: https://code.wireshark.org/review/18804 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Reviewed-by: Michael Mann <mmann78 at netscape.net> Tested-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=1de9f3ccebdef5b2423c70cd565dc9c4ec203177 commit 1de9f3ccebdef5b2423c70cd565dc9c4ec203177 Author: Gerald Combs <gerald at wireshark.org> Date: Tue Nov 15 15:56:57 2016 -0800 Double the fuzz testing memory limit. Increase MAX_VMEM to 1000000 in order to accomodate a large capture file in the menagerie and allow some breathing room for future large captures. Change-Id: I61d1a56d30d49af5c25785f8d43f104b6a300da5 Ping-Bug: 13049 Reviewed-on: https://code.wireshark.org/review/18838 Reviewed-by: Gerald Combs <gerald at wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=ba2c79ff32d64159be233396f7d0cc1671fc02f6 commit ba2c79ff32d64159be233396f7d0cc1671fc02f6 Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Tue Nov 15 22:27:48 2016 +0100 PER: add support for fragmented octet string Change-Id: Ia649825c250fee89b6f9513df22c38cdb4669cf4 Reviewed-on: https://code.wireshark.org/review/18835 Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1431b97430d1c7bcf31b9969c5a8f4cabdef71f0 commit 1431b97430d1c7bcf31b9969c5a8f4cabdef71f0 Author: Gerald Combs <gerald at wireshark.org> Date: Tue Nov 15 10:30:31 2016 -0800 Add more information about UTF 8 in our source code. Change-Id: I81d41fdc1aa66dd904160508c4a2e634337b5ba0 Reviewed-on: https://code.wireshark.org/review/18833 Reviewed-by: Gerald Combs <gerald at wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=d84e46ff1004018f88be6011f11f70dce4e3227b commit d84e46ff1004018f88be6011f11f70dce4e3227b Author: D. Ulis <daulis0 at gmail.com> Date: Fri Nov 4 15:50:25 2016 -0400 CIP: Properly handle EPATH attributes that do not specify path size Most attributes specify the path length before the EPATH data, but some do not. The previous code for parsing EPATHs just looped until there was no more data. This is a problem for EPATH that do not specify a length, because it will eat up too many bytes. This mainly affects Get Attribute List Responses and Set Attribute List Requests. For the small number of attributes like this, the Spec says exactly what kind of segment should be in the EPATH, so just parse a single segment. This fixes: Port attributes: 'Port Number and Node Address' and 'Chassis Identity' There is still one that is a problem in packet-cipsafety.c, but we will have to deal with it later. See the TODO in that file. I use the .pcap attached to https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12049, to make sure I didn't break any existing path/segment handling. Ping-Bug: 12049 Change-Id: Id035f9809f6cc747ea7b6327d94dd26dc66cb466 Reviewed-on: https://code.wireshark.org/review/18675 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=062378920a2e5f49c1cc43135f13740073d56b5b commit 062378920a2e5f49c1cc43135f13740073d56b5b Author: AndersBroman <anders.broman at ericsson.com> Date: Tue Nov 15 14:14:51 2016 +0100 [SIP export-pdu] Don't export SIP messages from the body of another SIP message Change-Id: I48336eb721ce730e3d09d4343a8d1170cb985214 Reviewed-on: https://code.wireshark.org/review/18829 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a01d9821f48b0c961b575bec8ef0c15cf24f4543 commit a01d9821f48b0c961b575bec8ef0c15cf24f4543 Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Sat Nov 12 14:05:30 2016 +0100 OSPF: Enhance dissector of RI TLV Update the list Add dissection of SR Algorithm use value string for TLV list Change-Id: If3573320a182235b720620af949e540b3706f538 Ping-Bug: 13118 Reviewed-on: https://code.wireshark.org/review/18813 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=456a3f1768ad28a6adedcc5c21f02ea0c8adee3e commit 456a3f1768ad28a6adedcc5c21f02ea0c8adee3e Author: Andre Puschmann <andre at softwareradiosystems.com> Date: Tue Nov 15 10:23:38 2016 +0100 MAC LTE: call LTE RRC dissectors for NB-IoT when respective flag is set Change-Id: I678ea851d1afa3fd68fc75272dbc11814437d697 Reviewed-on: https://code.wireshark.org/review/18828 Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d0cf1de0f976a4283cbc0a021cf8394bf8956fe4 commit d0cf1de0f976a4283cbc0a021cf8394bf8956fe4 Author: dario <lomato at gmail.com> Date: Tue Nov 15 09:56:22 2016 +0100 per: add initializer. Travis CI found the following errors: wireshark/epan/dissectors/packet-per.c: In function âdissect_per_open_type_internalâ: wireshark/epan/dissectors/packet-per.c:193:24: error: âpdu_tvbâ may be used uninitialized in this function [-Werror=maybe-uninitialized] tvb_composite_append(pdu_tvb, tvb_new_octet_aligned(tvb, offset, 8*type_length)); ^ wireshark/epan/dissectors/packet-per.c: In function âdissect_per_bit_stringâ: wireshark/epan/dissectors/packet-per.c:2269:24: error: âfragmented_tvbâ may be used uninitialized in this function [-Werror=maybe-uninitialized] tvb_composite_append(fragmented_tvb, tvb_new_octet_aligned(tvb, offset, length)); Change-Id: Idfd8bfc20439485f53e906a46e0717fc6199071c Reviewed-on: https://code.wireshark.org/review/18827 Petri-Dish: Dario Lombardo <lomato at gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> Reviewed-by: Dario Lombardo <lomato at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f3670b9fa51c0fe04744c630bcab80ef81708e89 commit f3670b9fa51c0fe04744c630bcab80ef81708e89 Author: AndersBroman <anders.broman at ericsson.com> Date: Mon Nov 14 17:38:24 2016 +0100 [SIP] Parse Via parameters for Overload Control RFC 7339 Change-Id: Iec22e947b3e52b406c380066a8e5e178f804d04a Reviewed-on: https://code.wireshark.org/review/18819 Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=dc2645217e8a87b0b6d93c054e68413d1c327eb7 commit dc2645217e8a87b0b6d93c054e68413d1c327eb7 Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Mon Nov 14 21:55:25 2016 +0100 tshark: fix activation of heuristic dissectors by command line Change-Id: I9499be0d0efd24ce1049513171c657795fa69250 Reviewed-on: https://code.wireshark.org/review/18823 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=67385b184cd4939a301658c813e444f8dbb97813 commit 67385b184cd4939a301658c813e444f8dbb97813 Author: Dario Lombardo <lomato at gmail.com> Date: Sun Nov 6 00:43:14 2016 +0100 travis: improve test matrix. Details: - remove the original broken environments and create multi-variable ones - remove old comments - exclude some OSX builds Change-Id: Iec98d13350444678823fa52bb3b9faefe02859d6 Reviewed-on: https://code.wireshark.org/review/18689 Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=70c326008367985fb1b88d142f3f422943a17a17 commit 70c326008367985fb1b88d142f3f422943a17a17 Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Mon Nov 14 08:09:06 2016 +0100 profinet (dcerpc pn io): Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I5b7d97b6238c26dd8fa748aaa59a84eb4a03274c Reviewed-on: https://code.wireshark.org/review/18814 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=17db0dca8bb0a79af28260fe7e6c71a2adc4f524 commit 17db0dca8bb0a79af28260fe7e6c71a2adc4f524 Author: Jan Spevak <jan.spevak at nokia.com> Date: Mon Nov 14 08:54:39 2016 +0100 diameter_3gpp: add decoding of Sd feature list Change-Id: I431cb2cb39328a7aa537eaa00b1cb1ab07723d3e Reviewed-on: https://code.wireshark.org/review/18815 Reviewed-by: Anders Broman <a.broman58 at gmail.com> Petri-Dish: Anders Broman <a.broman58 at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Roland Knall <rknall at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=271ee471ddc801dc89b3c7953f4f2bcff75ffa83 commit 271ee471ddc801dc89b3c7953f4f2bcff75ffa83 Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Sun Nov 13 22:52:06 2016 +0100 SABP: add support for messages >= 16KB Because of the way PER specification encodes length determinant >= 16K, we cannot get the PDU length from a fixed position at the beginning of the message. So drop tcp_dissect_pdus() (that cannot work for this use case) and manually request extra chunks until the full PDU is available. Bug: 8221 Change-Id: I91e32160fc2180f74b3edb9699ba510798b46983 Reviewed-on: https://code.wireshark.org/review/18808 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c88b8ad55badf6f92c0e43664766c44759506312 commit c88b8ad55badf6f92c0e43664766c44759506312 Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Sun Nov 13 22:41:11 2016 +0100 PER: add support for fragmented open type Change-Id: Ie4282cc859518977686da13f017ad79dfffa359b Reviewed-on: https://code.wireshark.org/review/18807 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> Reviewed-by: Anders Broman <a.broman58 at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fde5e29fc14d593ef90ae32adf2c9016c7a550c2 commit fde5e29fc14d593ef90ae32adf2c9016c7a550c2 Author: Uli Heilmeier <uh at heilmeier.eu> Date: Sun Nov 13 20:16:49 2016 +0100 DICOM: Reassemble only when "More Fragments" is set. When a TCP frame contains more DICOM segments, make sure that only segments with "More fragments" bit set gets reassembled. Bug: 13110 Change-Id: Ie19c71285a00240a035ff92ce3183de4d9048cbd Reviewed-on: https://code.wireshark.org/review/18805 Reviewed-by: Michael Mann <mmann78 at netscape.net> Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a7d9c74be0b8b0115f01729a94455350e7e92e8f commit a7d9c74be0b8b0115f01729a94455350e7e92e8f Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Sun Nov 13 17:24:06 2016 +0100 OSPF: fix indent (use 4 spaces) Change-Id: I3ba3fa626398718fefcc3430fffeaed2f4ea47b9 Reviewed-on: https://code.wireshark.org/review/18799 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=63776db384f75b2dc793cab46cf27250d8913711 commit 63776db384f75b2dc793cab46cf27250d8913711 Author: Michael Mann <mmann78 at netscape.net> Date: Fri Nov 11 21:58:45 2016 -0500 packet-dtn.c break loop if evaluate_sdnv doesn't succeed. Bug: 13097 Change-Id: If6128f5a3c940b4713c396e1a4a8f002a6bd03b8 Reviewed-on: https://code.wireshark.org/review/18764 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=4fd9872d11d3d575d8f261097c51a7d30b36ee40 commit 4fd9872d11d3d575d8f261097c51a7d30b36ee40 Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Sun Nov 13 22:05:01 2016 +0100 tvbuff_composite.c: fix composite_get_ptr when length is over 2 segments When storing a copy of the composite tvb in tvb->real_data, ensure to copy the full data and not only the length currently requested by the call to tvb_get_ptr() Change-Id: I6b42f3d46c4fba83fadf4d06f465c8d2486f4853 Reviewed-on: https://code.wireshark.org/review/18806 Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a9626210f165aa9b9d4a3668ecfeb70784bd087f commit a9626210f165aa9b9d4a3668ecfeb70784bd087f Author: Pascal Quantin <pascal.quantin at gmail.com> Date: Sun Nov 13 19:11:57 2016 +0100 PER: fixes for fragmented bitstring Follow-up of g54c3df8: - fix byte highlighting - return correct offset - return correct length Change-Id: Ib689ea72706c2e1d697c0e8f619b1b846c088001 Reviewed-on: https://code.wireshark.org/review/18803 Petri-Dish: Pascal Quantin <pascal.quantin at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7f2a83892204821145768b76bbdd0719b57787f8 commit 7f2a83892204821145768b76bbdd0719b57787f8 Author: Franklin "Snaipe" Mathieu <snaipe at diacritic.io> Date: Tue Nov 8 17:13:41 2016 +0100 lua: Allow proto:register_heuristic to be used on multiple list names In the C API, one can register a heuristic for the same protocol on different lists by specifying another unique short_name. This is impossible in the lua API, as the protocol name is used as the short name itself. This change fixes that by creating an unique shortname composed of the protocol name and the target list name. Change-Id: I2c30ce6e4f7a3b38879180c64cf8564f779163b4 Signed-off-by: Franklin "Snaipe" Mathieu <snaipe at diacritic.io> Reviewed-on: https://code.wireshark.org/review/18711 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Peter Wu <peter at lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=67e1ed5252ae27e3becdb6108683ba053de87cce commit 67e1ed5252ae27e3becdb6108683ba053de87cce Author: Gerald Combs <gerald at wireshark.org> Date: Sun Nov 13 09:32:35 2016 -0800 [Automatic update for 2016-11-13] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I83298430701c25aaba15cc5db02603bacd6d196a Reviewed-on: https://code.wireshark.org/review/18798 Reviewed-by: Gerald Combs <gerald at wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=4994d3dbf3f43b1f8c72723f6d682a6ead97d2a4 commit 4994d3dbf3f43b1f8c72723f6d682a6ead97d2a4 Author: Birol Capa <birol.capa at siemens.com> Date: Wed Nov 9 11:22:10 2016 +0300 PROFINET: Add Asset Management Record Dissection Identification and Maintenance (I&M) and AssetManagement (AM) functions are to collect information about the assets of an automation plant to cover the use cases such as identification, configuration, commissioning, diagnosis etc.. PROFINET plugin should support the Asset Management Record (AMR). Bug: 13112 Change-Id: I9c557b5f7f4f633fdd475c2c9e8900a8e6c2ba47 Reviewed-on: https://code.wireshark.org/review/18719 Reviewed-by: Michael Mann <mmann78 at netscape.net> Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte at gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5b348a48e5b240f703f400be3161fd4bc3caa56e commit 5b348a48e5b240f703f400be3161fd4bc3caa56e Author: novakji <j.novak at netsystem.cz> Date: Sat Nov 12 21:16:53 2016 +0100 Allocate transport_info->encoding_name from correct memory pool Bug: 13127 Change-Id: I09893fadc6f64316a373ddb8ac72e07a6743e149 Reviewed-on: https://code.wireshark.org/review/18758 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Reviewed-by: Michael Mann <mmann78 at netscape.net> Tested-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=efe95fa8fd79d4c087ce587143c000dd61218bc0 commit efe95fa8fd79d4c087ce587143c000dd61218bc0 Author: Peter Wu <peter at lekensteyn.nl> Date: Thu Nov 10 16:51:41 2016 +0100 Qt: populate Bookmarks menu in capture options dialog The bookmarks menu is populated for the main window when the appInitialized signal is emitted, this ensures that any preferences are applied. For the Capture Options dialog however, the appInitialized signal is never triggered since the GUI has already started. Just invoke it from the constructor such the menu is populated at least once. Bug: 12986 Change-Id: I04457fd25e52a25714ac471131b90e3a128515d8 Reviewed-on: https://code.wireshark.org/review/18734 Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter at xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=7ba0c0cc02573d102a6cc883b1bbb61cc2e27fea commit 7ba0c0cc02573d102a6cc883b1bbb61cc2e27fea Author: Bruno Verstuyft <bruno.verstuyft at excentis.com> Date: Fri Nov 4 16:30:55 2016 +0100 DOCSIS: Added dissector for type51 UCD Change-Id: Ifb46b2bd0a6eeae3e641ebcb3ecc89fc4f74b3f9 Reviewed-on: https://code.wireshark.org/review/18673 Reviewed-by: Jaap Keuter <jaap.keuter at xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter at xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=42bd5f92e91145f57bb25cba87495434ed2227d6 commit 42bd5f92e91145f57bb25cba87495434ed2227d6 Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Sat Nov 12 16:29:30 2016 +0100 QUIC: Update error code Change-Id: I797da3c55ecb1a8a61166d8fbf503c4bdeffc213 Reviewed-on: https://code.wireshark.org/review/18755 Petri-Dish: Michael Mann <mmann78 at netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=40b98600bd6a26ab716de2577246f00cd52bf4ef commit 40b98600bd6a26ab716de2577246f00cd52bf4ef Author: Alexis La Goutte <alexis.lagoutte at gmail.com> Date: Sat Nov 12 15:46:43 2016 +0100 fix no previous prototype for âcapture_*â [-Wmissing-prototypes] Change-Id: Ie5bfe4d366a679ebcb561716f23d174e7b9bf487 Reviewed-on: https://code.wireshark.org/review/18754 Petri-Dish: Alexis La Goutte <alexis.lagoutte at gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=76f74ac6058f78d563265699e137679eb429a109 commit 76f74ac6058f78d563265699e137679eb429a109 Author: Martin Kaiser <wireshark at kaiser.cx> Date: Fri Nov 11 19:15:09 2016 +0100 iso14443: dissect the TA(1) byte in the ATS Change-Id: I17785d32ca1f5ef69731c5dfba04892aa09648a0 Reviewed-on: https://code.wireshark.org/review/18756 Petri-Dish: Martin Kaiser <wireshark at kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Martin Kaiser <wireshark at kaiser.cx> http://cgit.osmocom.org/wireshark/commit/?id=f773e6cbf47e7b81b3596b3e6ff33581f4865b45 commit f773e6cbf47e7b81b3596b3e6ff33581f4865b45 Author: Jaap Keuter <jaap.keuter at xs4all.nl> Date: Sat Nov 12 13:19:34 2016 +0100 Really return manufacturer name if it's known. Bug: 13126 Change-Id: I56e935cea7aa323941ac612d4954875a01910684 Reviewed-on: https://code.wireshark.org/review/18752 Petri-Dish: Jaap Keuter <jaap.keuter at xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply at wireshark.org> Reviewed-by: Michael Mann <mmann78 at netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=b085a2379aa61dbf90381acfff286f36f95e9794 commit b085a2379aa61dbf90381acfff286f36f95e9794 Author: Harald Welte <laforge at gnumonks.org> Date: Sat Nov 12 13:31:10 2016 +0100 gsm_abis_om2000: Expand bit-width of CON CCP and CI fields It seems more recent RBS2000 models have extended the range of the CON Connection Point (CCP) by one bit, as I'm seeing CCP 1896 in protocol traces. Similarly, the Contiguity Index can at least reach 96. Using the full 8bit value to make sure IS and CON dissectors use the same ranges for connection points and contiguity index. Change-Id: Iece34106fc97a11dc8a01cf2578b5e4245a4c9e8 Reviewed-on: https://code.wireshark.org/review/18753 Reviewed-by: Pascal Quantin <pascal.quantin at gmail.com> ----------------------------------------------------------------------- hooks/post-receive -- wireshark with Osmocom specific dissectors