osmo-bts.git branch neels/dyn_fixes updated. 0.4.0-258-g42b8a25

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.

gitosis at osmocom.org gitosis at osmocom.org
Tue Aug 9 19:52:20 UTC 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".

The branch, neels/dyn_fixes has been updated
  discards  38ad25b1b01e765d85ee586cc5bf15135ec9a0a5 (commit)
  discards  5659824068d38556f8f7e0d72f76385194fe13c4 (commit)
  discards  7238da56593ecd4b5e291f6ea761d74dd1e2349f (commit)
  discards  a0e336ce6c7b847be2bd581ab2f2307127c3afa3 (commit)
       via  42b8a25b0bd8eb53a79841fe463742a4aa259b02 (commit)
       via  f476da552fda7c6255008e0fd4c0da13e629f70d (commit)
       via  a85b43430cd3d44d017d3d40f728e89e1523be4d (commit)
       via  e82c02e68c25caefab5b4a33cac744a7de5148f5 (commit)
       via  0dcccec33083c6b4db00d733aeb2601ebeab2a58 (commit)
       via  d6ebab44a4cbc7d61ce079f472ba7ee9bc60182f (commit)
       via  488d920242fa37910cb9ac060b07a5e5701bd6bc (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (38ad25b1b01e765d85ee586cc5bf15135ec9a0a5)
            \
             N -- N -- N (42b8a25b0bd8eb53a79841fe463742a4aa259b02)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=42b8a25b0bd8eb53a79841fe463742a4aa259b02

commit 42b8a25b0bd8eb53a79841fe463742a4aa259b02
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Tue Aug 9 19:56:50 2016 +0200

    dyn TS: sysmo,lc15: ph_data_req: fix PDCH mode detection
    
    Though this patch theoretically makes a lot of sense, it is not entirely clear
    why dyn TS are working without it. Committing due to common sense, not to fix
    any actual breakage.
    
    Change-Id: I6136cb42a4d627ebefc963eb5321fadfe63cca4b

http://cgit.osmocom.org/osmo-bts/commit/?id=f476da552fda7c6255008e0fd4c0da13e629f70d

commit f476da552fda7c6255008e0fd4c0da13e629f70d
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Tue Aug 9 20:15:09 2016 +0200

    cosmetic: common ts_is_pdch()
    
    Have one common ts_is_pdch(), placed in lchan.c, since this file is pretty
    empty and pretty close to ts. Publish in gsm_data.h.
    
    Remove the if-style implementation from l1sap.c, and instead implement in a
    switch statement.
    
    This prepares for upcoming ts_is_pdch() usage in ph_data_req() for sysmo and
    lc15.
    
    Change-Id: Ib78d663fdbac5a1d7053f1b9d543649b66da00e2

http://cgit.osmocom.org/osmo-bts/commit/?id=a85b43430cd3d44d017d3d40f728e89e1523be4d

commit a85b43430cd3d44d017d3d40f728e89e1523be4d
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Wed Jul 27 15:16:29 2016 +0200

    dyn TS: measurement: use correct nr of subslots, rm code dup
    
    In measurement.c, fix the number of sublots for TCH/F_TCH/H_PDCH, by using
    ts_subslots() from gsm_data_shared.c. The local dup of subslots_per_pchan[] is
    no longer needed. (depends on recent commit to openbsc.git for ts_sublots())
    
    Change-Id: I9d9df470c49487bffd56dde42c7bec0da2f50642

http://cgit.osmocom.org/osmo-bts/commit/?id=e82c02e68c25caefab5b4a33cac744a7de5148f5

commit e82c02e68c25caefab5b4a33cac744a7de5148f5
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Fri Jul 29 17:56:35 2016 +0200

    sysmo,lc15: ts_connect_as(): log error also for pchan_as == TCH/F_PDCH
    
    Change-Id: I76c868a1e70af16268a6fa42dc736cf0b288ecdb

http://cgit.osmocom.org/osmo-bts/commit/?id=0dcccec33083c6b4db00d733aeb2601ebeab2a58

commit 0dcccec33083c6b4db00d733aeb2601ebeab2a58
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Fri Jul 29 17:55:26 2016 +0200

    dyn TS: measurement.c: replace fixme with comment
    
    Change-Id: I04668f6f01a48157a98c6326a9ee48982a09ee62

http://cgit.osmocom.org/osmo-bts/commit/?id=d6ebab44a4cbc7d61ce079f472ba7ee9bc60182f

commit d6ebab44a4cbc7d61ce079f472ba7ee9bc60182f
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Fri Jul 29 17:54:57 2016 +0200

    dyn TS: complete for TRX
    
    Apply similar fixes as for TCH/F_PDCH also for TCH/F_TCH/H_PDCH:
    
    Detect dyn TS in PDCH mode in ts_is_pdch().
    
    In trx_set_ts(), enhance the "if (TCH_F_PDCH)" to a switch statement including
    both dynamic channel types. Adjust the comment to include both kinds.
    
    Change-Id: I6669739cd08780cd9ffb9451cdae9f6b9704c4fe

http://cgit.osmocom.org/osmo-bts/commit/?id=488d920242fa37910cb9ac060b07a5e5701bd6bc

commit 488d920242fa37910cb9ac060b07a5e5701bd6bc
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Tue Aug 9 20:25:31 2016 +0200

    sysmo: fix dyn TS: Revert "Activate PTCCH UL" [in sysmobts]
    
    This reverts commit 53d792c3b027bfb42d77804e3e687a287e122ef3.
    The commit caused this error with SysmoBTS:
    
    DL1P <0007> l1_if.c:164 Tx L1 prim MPH-ACTIVATE.req
    DL1C <0006> oml.c:811 Error activating L1 SAPI PTCCH on TS 7: Invalid parameter
    DL1C <0006> oml.c:1089 (bts=0,trx=0,ts=7,ss=0) act failed mark broken due status: -4
    
    Since dynamic timeslots wait for the activation to succeed, the broken status
    breaks dynamic timeslots on SysmoBTS. Initially GPRS works, but the state in
    the BSC is messed up and placing calls fails for dyn TS:
    
    DRLL <0000> chan_alloc.c:355 Failed to allocate TCH_H channel
    DRSL <0004> abis_rsl.c:1656 BTS 0 CHAN RQD: no resources for TCH_H 0x45
    
    Normal PDCH on SysmoBTS was not broken -- the error message occurs, but that
    doesn't seem to matter much. Plain GPRS still works since there is no
    switchover involved. But I can see no benefit in enabling PTCCH UL on sysmo.
    
    Since the commit only enabled PTCCH UL in sysmobts, no other BTS models are
    affected. Notice that lc15 still has PTCCH UL disabled all the while, before
    and after this commit and its revert.
    
    Change-Id: Ia59d95c75a8a5d3bd596f55cd1dc0906a6a95f7f

-----------------------------------------------------------------------

Summary of changes:
 include/osmo-bts/gsm_data.h     |  1 +
 src/common/l1sap.c              | 11 -----------
 src/common/lchan.c              | 16 ++++++++++++++++
 src/osmo-bts-litecell15/l1_if.c |  2 +-
 src/osmo-bts-sysmo/l1_if.c      |  2 +-
 src/osmo-bts-sysmo/oml.c        |  3 +--
 6 files changed, 20 insertions(+), 15 deletions(-)


hooks/post-receive
-- 
Osmocom BTS-side code (Abis, scheduling, ...)



More information about the osmocom-commitlog mailing list