openbsc.git branch neels/logging_for_1778 created. 0.15.0-379-g8679409

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.

gitosis at osmocom.org gitosis at osmocom.org
Tue Aug 9 19:47:50 UTC 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, neels/logging_for_1778 has been created
        at  8679409ab56bba16591f8133b2a89abea321fc33 (commit)

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=8679409ab56bba16591f8133b2a89abea321fc33

commit 8679409ab56bba16591f8133b2a89abea321fc33
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Thu Jul 28 17:05:50 2016 +0200

    logging for #1778
    
    Change-Id: I6abba6665d9beda354dc66399ab80829874307fa

http://cgit.osmocom.org/openbsc/commit/?id=572d5eb0967a3179ca846988e86320ec732e204b

commit 572d5eb0967a3179ca846988e86320ec732e204b
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Sat Jul 23 16:47:07 2016 +0200

    gsm_ts2chan_nr(): use constants instead of magic numbers
    
    Change-Id: I14dceab6ac9f0d4ad852259eae643f567d0982f2

http://cgit.osmocom.org/openbsc/commit/?id=2b8eefc37ec603340085044f73081902d498e5ed

commit 2b8eefc37ec603340085044f73081902d498e5ed
Author: Neels Hofmeyr <neels at hofmeyr.de>
Date:   Sat Jul 23 20:15:28 2016 +0200

    dyn TS: OS#1778 workaround: disable TCH/F on dyn TS for nitb
    
    To avoid two phones picking mismatching TCH pchans, never pick TCH/F on dynamic
    TS in osmo-nitb.
    
    Add gsm_network flag dyn_ts_allow_tch_f, set to true by default in
    gsm_network_init().
    
    Set this flag to false in osmo-nitb's main().
    
    See http://osmocom.org/issues/1778
    
    Reasoning about ways to solve this:
    
    * a compile time switch doesn't work because libbsc is first compiled and then
      linked to both osmo-nitb and osmo-bsc.
    
    * we could test net->bsc_api == msc_bsc_api(), but I have the so-called MSC
      split waiting on branch sysmocom/cscn, which will result in msc_bsc_api() not
      being linked in the osmo-bsc binary.
    
    * have a function am_i_nitb() with different implementations in osmo-nitb and
      osmo-bsc, but then we'd need to add implementations to all tests and other
      binaries linking lchan_alloc().
    
    * have a flag in struct bsc_api, but so far there are only function pointers
      there.
    
    Having a "global" flag in gsm_network allows to add a VTY command in case we
    decide to keep this feature (#1781), has no linking implications and is nicely
    explicit.
    
    Related: OS#1778, OS#1781
    Change-Id: If7e4797a72815fc6e2bbef27756ea5df69f4bde7

-----------------------------------------------------------------------


hooks/post-receive
-- 
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)



More information about the osmocom-commitlog mailing list